From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jjian Zhou <jjian.zhou@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH RFC v2 3/3] dt-bindings: mailbox: mtk,vcp-mbox: add mtk vcp-mbox document
Date: Mon, 17 Mar 2025 18:08:40 +0100 [thread overview]
Message-ID: <e5d2f827-9edb-4d0b-952d-24eadf8dfeb7@kernel.org> (raw)
In-Reply-To: <df592920-cdf3-40fe-8357-2fbdfc0afd78@kernel.org>
On 17/03/2025 10:00, Krzysztof Kozlowski wrote:
> On 17/03/2025 09:38, Jjian Zhou wrote:
>> This patch adds document for mediatek vcp mbox.
>>
>> Signed-off-by: Jjian Zhou <jjian.zhou@mediatek.com>
>> ---
>> .../bindings/mailbox/mtk,mt8196-vcp-mbox.yaml | 49 +++++++++++++++++++
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
>> 1 file changed, 49 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml
>
> Filename based on compatible. You already got this comment. Copy paste
> your filename here:
>
> <here goes filename>
>
> and here your compatible:
>
> <here goes compatible>
>
> Are the the same?
Can you do this exercise here, instead of sending next versions?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-17 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 8:38 [PATCH RFC v2 0/3] add VCP mailbox and IPC driver Jjian Zhou
2025-03-17 8:38 ` [PATCH RFC v2 1/3] mailbox: mediatek: Add mtk-vcp-mailbox driver Jjian Zhou
2025-03-17 8:38 ` [PATCH RFC v2 2/3] firmware: mediatek: Add VCP IPC protocol interface Jjian Zhou
2025-03-17 8:38 ` [PATCH RFC v2 3/3] dt-bindings: mailbox: mtk,vcp-mbox: add mtk vcp-mbox document Jjian Zhou
2025-03-17 9:00 ` Krzysztof Kozlowski
2025-03-17 17:08 ` Krzysztof Kozlowski [this message]
2025-03-17 10:07 ` [PATCH RFC v2 0/3] add VCP mailbox and IPC driver AngeloGioacchino Del Regno
2025-03-18 7:44 ` Chen-Yu Tsai
2025-04-02 9:58 ` AngeloGioacchino Del Regno
2025-04-17 7:16 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d2f827-9edb-4d0b-952d-24eadf8dfeb7@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jjian.zhou@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.