From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1744396D09 for ; Thu, 3 Sep 2026 05:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788415182; cv=none; b=Qg1SPzju9z0GbVO5HQkonNBY6I84fHmb3eMqFdun81GuYk3pfDB+QNEeabIMDnhceXmYHp8R7OLKtpY65PfinewQS4IhtivxPOt7vkwFEZfy0f6Vl2JKLUSqoSsFSk6pmOOWKM6R13qm/Rx79fPFWaEc1ix4tsyjpABANsNWcJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788415182; c=relaxed/simple; bh=FfxYG0CZyWtxZUhsaC3BQ6+9g8CCmMqS+gpG7CSvN6Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=seYVRB8VKX8ZvOR2kaPCX2jnuFw+gT908JzrKRhrQXXpGeA+mqx+bbA/0DAV2AoN6KtB6PtW9jOHJn9KVRVlhbfKELZ9qo/ZyxgyfLPRaFnLH5tm6dCW4LxWlpHtCVyu/S8hAhQD9jm6Phd7L6yaSkv66obONMW67xmCAgUuzBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HMLW8bYH; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HMLW8bYH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788415175; x=1819951175; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FfxYG0CZyWtxZUhsaC3BQ6+9g8CCmMqS+gpG7CSvN6Q=; b=HMLW8bYHK0B8MgU24YFUVNTWpVBERz+H2FjFte/rC+y6MYSQrvt2j/87 X43QmKeIa5ELNL2bhNAvEPThsu2VcrjTZ9mwPcWjK46cRz6fdtVUcRfq1 ydMFXQPscQWZvE/1AejasVBRZCH4Y2SePP6LAWtQ1+T/foRMYhPjHlgnf 1BUHneq9TmdeLjkOgb+ZI40vav+ugJSXbiTcXgZ7CT5erfp4ViPI9AKSk 4lrmirXH2uZP2Iqo2YGQXrlhxXAlneHJgSIwUx+2D18hkJ+zrLT455cVW YmEnNdp3x0d0zJnp4b8XmiUJJVF/Af/mhQMPFoasjnWUITWL8tOsn3cNk g==; X-CSE-ConnectionGUID: vTgefpYoS02l2nCiNzqMNQ== X-CSE-MsgGUID: J5FbBnL6Qj6F6StwvLS8uQ== X-IronPort-AV: E=McAfee;i="6800,10657,11894"; a="92586133" X-IronPort-AV: E=Sophos;i="6.25,258,1779174000"; d="scan'208";a="92586133" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2026 22:59:33 -0700 X-CSE-ConnectionGUID: SPhLGJ/LReSeuEdcucE+GQ== X-CSE-MsgGUID: xhaZAg/dQ7S+U423fKUGtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,258,1779174000"; d="scan'208";a="269626375" Received: from unknown (HELO [10.238.208.122]) ([10.238.208.122]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2026 22:59:30 -0700 Message-ID: Date: Thu, 3 Sep 2026 13:59:25 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] virt: tdx-guest: Use a variable to store the Quote buffer size To: Peter Fang , Kuppuswamy Sathyanarayanan Cc: Dave Hansen , Kiryl Shutsemau , Rick Edgecombe , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Binbin Wu References: <20260729122939.1340412-1-peter.fang@intel.com> <20260729122939.1340412-4-peter.fang@intel.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/3/2026 7:15 AM, Peter Fang wrote: > You are also dropping PAGE_ALIGN() in alloc and free calls. You can > mention it in commit log. I think it's better to keep the PAGE_ALIGN() when assign quote_data_len, although GET_QUOTE_BUF_SIZE is aligned already. This makes it super clear we want to page size align the buffer. And in next patch, we can make it quote_data_len = PAGE_ALIGN(get_quote_buf_size());