From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4A29C79FB9 for ; Thu, 10 Sep 2026 08:31:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3B0C10F37A; Thu, 10 Sep 2026 08:31:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="wZAvjPqc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EOtPurJF"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tvtGiQog"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KSCFtnoO"; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABA3A10F376 for ; Thu, 10 Sep 2026 08:31:22 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 12F2621BFC; Thu, 10 Sep 2026 08:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789029077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9UTAZuVbCsliP/vbyrL+HlsQlGf+OtK32EJ3r+2gfpM=; b=wZAvjPqcoKTESz3cGAPSAMvD3W7jy0h9CCTs3XtndkE+RFNYeAxqga4G31fqzNvZKJE56b 9RFrscoBZBxufGKiq8V7c90v6bt2EggvZdFjvZ/dNLDF83gbaYMSJMJ5R+mH/lU0GaLJ5T s7WxRLwIUgL6g/83GgXEIGaEXoNoSbc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789029077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9UTAZuVbCsliP/vbyrL+HlsQlGf+OtK32EJ3r+2gfpM=; b=EOtPurJFwKzvrWPK40qF8zE9ztYxSCOE17ZZtpLJycfsgcL687tmefPnRAyAOe5xFize0J o9ilkv0Y1K5zz1Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tvtGiQog; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KSCFtnoO DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789029073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9UTAZuVbCsliP/vbyrL+HlsQlGf+OtK32EJ3r+2gfpM=; b=tvtGiQog/roSgaLNzQA4h9BrQ/sr4YIZG29Bywn+2qWnp8ePN88ln2jGsk8HSH2HUYV67J mI000ncDZyeCL5zgYjaMH5kWjMbKMfgLn4kccKv0YRwP9hivIzZLVIdtoGFS1p6A1aD0bm Y1GngDOpeICc0PuIx6oXvRBG+dG13eE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789029073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9UTAZuVbCsliP/vbyrL+HlsQlGf+OtK32EJ3r+2gfpM=; b=KSCFtnoOfqoQA8J5ifafG4prUlzfIVct+JeugvbSfDjkq3gDuFEmtz4DxZYuoaCphsVKaN V6ktyAg3DSW8hVCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A6E17137FD; Thu, 10 Sep 2026 08:31:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id teTtHdBqompWVwAAD6G6ig (envelope-from ); Thu, 10 Sep 2026 08:31:12 +0000 Message-ID: Date: Thu, 10 Sep 2026 10:31:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/verisilicon: set blend mode for the primary plane To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260901171703.1161592-1-zhengxingda@iscas.ac.cn> <35cf76a67f7473d5ef86d01c812d680abc41687e.camel@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 12F2621BFC X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,suse.de:dkim,suse.de:mid,iscas.ac.cn:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Am 10.09.26 um 10:00 schrieb Icenowy Zheng: > 在 2026-09-10四的 09:58 +0200，Thomas Zimmermann写道： >> Hi >> >> Am 10.09.26 um 09:09 schrieb Icenowy Zheng: >>> 在 2026-09-02三的 01:17 +0800，Icenowy Zheng写道： >>>> Blend modes are now required to expose pixel formats w/ alpha. >>>> >>>> As it's the primary plane and blending is explicitly disabled, >>>> just >>>> expose PIXEL_NONE blend mode. >>> Gently ping for reviews. >> What do these alpha formats do?  Are they a hardware feature?  It >> looks >> like they are programmable, but don't differ from XRGB at all. > I think they're for consistency with overlay planes. But there are no overlay planes in this driver, are there? What I want to get at is that it might be preferable to remove ARGB entirely from the primary plane if it does not to serve a purpose. But if the driver can do something useful with these formats, it might be worth exposing that instead. In pl111, we now remove the ARGB foramts because the hardware does not handle them at all. The situation seems less clear in verisilicon. Best regards Thomas > > Thanks, > Icenowy > >> Best regards >> Thomas >> >>> Thanks, >>> Icenowy >>> >>>> Signed-off-by: Icenowy Zheng >>>> --- >>>>   drivers/gpu/drm/verisilicon/vs_primary_plane.c | 3 +++ >>>>   1 file changed, 3 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> index 1f2be41ae496c..8d58682d88ef8 100644 >>>> --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> @@ -7,6 +7,7 @@ >>>> >>>>   #include >>>>   #include >>>> +#include >>>>   #include >>>>   #include >>>>   #include >>>> @@ -179,5 +180,7 @@ struct drm_plane >>>> *vs_primary_plane_init(struct >>>> drm_device *drm_dev, struct vs_dc >>>> >>>>    drm_plane_helper_add(plane, >>>> &vs_primary_plane_helper_funcs); >>>> >>>> + drm_plane_create_blend_mode_property(plane, >>>> + >>>> BIT(DRM_MODE_BLEND_PIXEL_NONE)); >>>>    return plane; >>>>   } -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)