From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Sanket Goswami <Sanket.Goswami@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Michael J <michael.j.ruhl@intel.com>
Subject: Re: [PATCH 5/6] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC
Date: Thu, 1 Feb 2024 15:19:39 +0200 [thread overview]
Message-ID: <e6241509-4bf4-4144-a7fb-694fc9fc83cc@linux.intel.com> (raw)
In-Reply-To: <ZbuHrjeOV7Wd-HBs@smile.fi.intel.com>
On 2/1/24 13:59, Andy Shevchenko wrote:
> On Wed, Jan 31, 2024 at 04:16:51PM +0200, Jarkko Nikula wrote:
>> I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It
>> must be at least 1 since code is able to read received data from the
>> DW_IC_DATA_CMD register.
>>
>> For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk()
>> doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but
>> is needed when converting code into generic polling mode implementation.
>
> Shouldn't this formally have a Fixes tag?
>
I don't think so since this define is not in use before my last patch.
May needlessly bother stable bot & folks.
next prev parent reply other threads:[~2024-02-01 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:16 [PATCH 0/6] i2c: designware: Generic polling mode code Jarkko Nikula
2024-01-31 14:16 ` [PATCH 1/6] i2c: designware: Uniform initialization flow for polling mode Jarkko Nikula
2024-02-01 11:57 ` Andy Shevchenko
2024-02-05 0:03 ` Andi Shyti
2024-01-31 14:16 ` [PATCH 2/6] i2c: designware: Do not enable interrupts shortly in " Jarkko Nikula
2024-01-31 14:16 ` [PATCH 3/6] i2c: designware: Use accessors to DW_IC_INTR_MASK register Jarkko Nikula
2024-01-31 14:16 ` [PATCH 4/6] i2c: designware: Move interrupt handling functions before i2c_dw_xfer() Jarkko Nikula
2024-01-31 14:16 ` [PATCH 5/6] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC Jarkko Nikula
2024-02-01 11:59 ` Andy Shevchenko
2024-02-01 13:19 ` Jarkko Nikula [this message]
2024-01-31 14:16 ` [PATCH 5/5] i2c: designware: Implement generic polling mode code for " Jarkko Nikula
2024-02-01 12:06 ` Andy Shevchenko
2024-02-01 13:21 ` Jarkko Nikula
2024-01-31 14:16 ` [PATCH 6/6] " Jarkko Nikula
2024-02-01 12:08 ` [PATCH 0/6] i2c: designware: Generic polling mode code Andy Shevchenko
2024-02-01 13:18 ` Jarkko Nikula
2024-02-04 3:20 ` Jiawen Wu
2024-02-05 7:30 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6241509-4bf4-4144-a7fb-694fc9fc83cc@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.