From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Roberts Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() Date: Wed, 28 Jun 2023 12:09:07 +0100 Message-ID: References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> List-ID: Content-Type: text/plain; charset="windows-1252" To: Yin Fengwei , Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org On 28/06/2023 03:20, Yin Fengwei wrote: >=20 >=20 > On 6/27/23 16:09, Ryan Roberts wrote: >> On 27/06/2023 08:08, Yu Zhao wrote: >>> On Mon, Jun 26, 2023 at 11:14=E2=80=AFAM Ryan Roberts wrote: >>>> >>>> Like folio_add_new_anon_rmap() but batch-rmaps a range of pages >>>> belonging to a folio, for effciency savings. All pages are accounted as >>>> small pages. >>>> >>>> Signed-off-by: Ryan Roberts >>>> --- >>>> include/linux/rmap.h | 2 ++ >>>> mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 45 insertions(+) >>>> >>>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>>> index a3825ce81102..15433a3d0cbf 100644 >>>> --- a/include/linux/rmap.h >>>> +++ b/include/linux/rmap.h >>>> @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct = vm_area_struct *, >>>> unsigned long address); >>>> void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, >>>> unsigned long address); >>>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *= page, >>>> + int nr, struct vm_area_struct *vma, unsigned long addr= ess); >>> >>> We should update folio_add_new_anon_rmap() to support large() && >>> !folio_test_pmd_mappable() folios instead. >>> >>> I double checked all places currently using folio_add_new_anon_rmap(), >>> and as expected, none actually allocates large() && >>> !folio_test_pmd_mappable() and maps it one by one, which makes the >>> cases simpler, i.e., >>> if (!large()) >>> // the existing basepage case >>> else if (!folio_test_pmd_mappable()) >>> // our new case >>> else >>> // the existing THP case >> >> I don't have a strong opinion either way. Happy to go with this suggesti= on. But >> the reason I did it as a new function was because I was following the pa= ttern in >> [1] which adds a new folio_add_file_rmap_range() function. >> >> [1] https://lore.kernel.org/linux-mm/20230315051444.3229621-35-willy@inf= radead.org/ > Oh. There is different here: > For page cache, large folio could be created by previous file access. But= later > file access by other process just need map partial large folio. In this c= ase, we need > _range for filemap. >=20 > But for anonymous, I suppose we always map whole folio in. So I agree wit= h Yu. We > don't need _range for folio_add_new_anon_rmap(). Thanks. Yes that makes sense - thanks. I'll merge the new case into folio_add_new_anon_rmap() for v2. >=20 >=20 > Regards > Yin, Fengwei >=20 >> >> >>> >>>> void page_add_file_rmap(struct page *, struct vm_area_struct *, >>>> bool compound); >>>> void folio_add_file_rmap_range(struct folio *, struct page *, unsigne= d int nr, >>>> diff --git a/mm/rmap.c b/mm/rmap.c >>>> index 1d8369549424..4050bcea7ae7 100644 >>>> --- a/mm/rmap.c >>>> +++ b/mm/rmap.c >>>> @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *foli= o, struct vm_area_struct *vma, >>>> __page_set_anon_rmap(folio, &folio->page, vma, address, 1); >>>> } >>>> >>>> +/** >>>> + * folio_add_new_anon_rmap_range - Add mapping to a set of pages with= in a new >>>> + * anonymous potentially large folio. >>>> + * @folio: The folio containing the pages to be mapped >>>> + * @page: First page in the folio to be mapped >>>> + * @nr: Number of pages to be mapped >>>> + * @vma: the vm area in which the mapping is added >>>> + * @address: the user virtual address of the first page to be mapp= ed >>>> + * >>>> + * Like folio_add_new_anon_rmap() but batch-maps a range of pages wit= hin a folio >>>> + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-= and-test is >>>> + * bypassed and the folio does not have to be locked. All pages in th= e folio are >>>> + * individually accounted. >>>> + * >>>> + * As the folio is new, it's assumed to be mapped exclusively by a si= ngle >>>> + * process. >>>> + */ >>>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *= page, >>>> + int nr, struct vm_area_struct *vma, unsigned long addr= ess) >>>> +{ >>>> + int i; >>>> + >>>> + VM_BUG_ON_VMA(address < vma->vm_start || >>>> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); >>> >>> BTW, VM_BUG_ON* shouldn't be used in new code: >>> Documentation/process/coding-style.rst >> >> Thanks, sorry about that. Was copy-pasting from folio_add_new_anon_rmap(= ). >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898A9C001B3 for ; Wed, 28 Jun 2023 11:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbjF1LJ0 (ORCPT ); Wed, 28 Jun 2023 07:09:26 -0400 Received: from foss.arm.com ([217.140.110.172]:53840 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231782AbjF1LJM (ORCPT ); Wed, 28 Jun 2023 07:09:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E2D2113E; Wed, 28 Jun 2023 04:09:55 -0700 (PDT) Received: from [10.57.76.180] (unknown [10.57.76.180]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67543F663; Wed, 28 Jun 2023 04:09:08 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 12:09:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() To: Yin Fengwei , Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> From: Ryan Roberts In-Reply-To: <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ia64@vger.kernel.org On 28/06/2023 03:20, Yin Fengwei wrote: > > > On 6/27/23 16:09, Ryan Roberts wrote: >> On 27/06/2023 08:08, Yu Zhao wrote: >>> On Mon, Jun 26, 2023 at 11:14 AM Ryan Roberts wrote: >>>> >>>> Like folio_add_new_anon_rmap() but batch-rmaps a range of pages >>>> belonging to a folio, for effciency savings. All pages are accounted as >>>> small pages. >>>> >>>> Signed-off-by: Ryan Roberts >>>> --- >>>> include/linux/rmap.h | 2 ++ >>>> mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 45 insertions(+) >>>> >>>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>>> index a3825ce81102..15433a3d0cbf 100644 >>>> --- a/include/linux/rmap.h >>>> +++ b/include/linux/rmap.h >>>> @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, >>>> unsigned long address); >>>> void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, >>>> unsigned long address); >>>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >>>> + int nr, struct vm_area_struct *vma, unsigned long address); >>> >>> We should update folio_add_new_anon_rmap() to support large() && >>> !folio_test_pmd_mappable() folios instead. >>> >>> I double checked all places currently using folio_add_new_anon_rmap(), >>> and as expected, none actually allocates large() && >>> !folio_test_pmd_mappable() and maps it one by one, which makes the >>> cases simpler, i.e., >>> if (!large()) >>> // the existing basepage case >>> else if (!folio_test_pmd_mappable()) >>> // our new case >>> else >>> // the existing THP case >> >> I don't have a strong opinion either way. Happy to go with this suggestion. But >> the reason I did it as a new function was because I was following the pattern in >> [1] which adds a new folio_add_file_rmap_range() function. >> >> [1] https://lore.kernel.org/linux-mm/20230315051444.3229621-35-willy@infradead.org/ > Oh. There is different here: > For page cache, large folio could be created by previous file access. But later > file access by other process just need map partial large folio. In this case, we need > _range for filemap. > > But for anonymous, I suppose we always map whole folio in. So I agree with Yu. We > don't need _range for folio_add_new_anon_rmap(). Thanks. Yes that makes sense - thanks. I'll merge the new case into folio_add_new_anon_rmap() for v2. > > > Regards > Yin, Fengwei > >> >> >>> >>>> void page_add_file_rmap(struct page *, struct vm_area_struct *, >>>> bool compound); >>>> void folio_add_file_rmap_range(struct folio *, struct page *, unsigned int nr, >>>> diff --git a/mm/rmap.c b/mm/rmap.c >>>> index 1d8369549424..4050bcea7ae7 100644 >>>> --- a/mm/rmap.c >>>> +++ b/mm/rmap.c >>>> @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >>>> __page_set_anon_rmap(folio, &folio->page, vma, address, 1); >>>> } >>>> >>>> +/** >>>> + * folio_add_new_anon_rmap_range - Add mapping to a set of pages within a new >>>> + * anonymous potentially large folio. >>>> + * @folio: The folio containing the pages to be mapped >>>> + * @page: First page in the folio to be mapped >>>> + * @nr: Number of pages to be mapped >>>> + * @vma: the vm area in which the mapping is added >>>> + * @address: the user virtual address of the first page to be mapped >>>> + * >>>> + * Like folio_add_new_anon_rmap() but batch-maps a range of pages within a folio >>>> + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-and-test is >>>> + * bypassed and the folio does not have to be locked. All pages in the folio are >>>> + * individually accounted. >>>> + * >>>> + * As the folio is new, it's assumed to be mapped exclusively by a single >>>> + * process. >>>> + */ >>>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >>>> + int nr, struct vm_area_struct *vma, unsigned long address) >>>> +{ >>>> + int i; >>>> + >>>> + VM_BUG_ON_VMA(address < vma->vm_start || >>>> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); >>> >>> BTW, VM_BUG_ON* shouldn't be used in new code: >>> Documentation/process/coding-style.rst >> >> Thanks, sorry about that. Was copy-pasting from folio_add_new_anon_rmap(). >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE43AEB64D7 for ; Wed, 28 Jun 2023 11:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i1pfcsDmIrdELtnvOn8VlVWLUwZs0qETADUHiUS29kA=; b=2SBOyJacDBhxEX vfVKdU1EHhjTH5WaeZzSiPd3lZuYOEN0xjj9ZQW6Y7VjorMlJXPCAxdJpv0tVHXHqdzHhPkBaiOJ9 m1PQUEthzYGeY6kQV63m9S4BVeS9dWJH6RZ5dY3/n+JDm7Sgag5u3ddfFkAIKf2zG5Q/qyazB2OJb kqyX5FdfZpd/942vyWgIl5FJADW/1u4FF4A6OtQg477zXn3vRVAtU6atVjsEYPpmMVyhteUoIuaWs Sb2tmltu7odjpKW9DxE01AGvVBCPYcyZ6lXeQltqZgVZK7wDlZ5vnFhfBEi9alOi6TG2We+L/ITGB NEDB6Pxzs0FfaLKzFEmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qET2z-00FYc9-2e; Wed, 28 Jun 2023 11:09:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qET2v-00FYb6-2e for linux-arm-kernel@lists.infradead.org; Wed, 28 Jun 2023 11:09:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E2D2113E; Wed, 28 Jun 2023 04:09:55 -0700 (PDT) Received: from [10.57.76.180] (unknown [10.57.76.180]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67543F663; Wed, 28 Jun 2023 04:09:08 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 12:09:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() To: Yin Fengwei , Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> From: Ryan Roberts In-Reply-To: <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_040913_955306_684A4FA3 X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjgvMDYvMjAyMyAwMzoyMCwgWWluIEZlbmd3ZWkgd3JvdGU6Cj4gCj4gCj4gT24gNi8yNy8y MyAxNjowOSwgUnlhbiBSb2JlcnRzIHdyb3RlOgo+PiBPbiAyNy8wNi8yMDIzIDA4OjA4LCBZdSBa aGFvIHdyb3RlOgo+Pj4gT24gTW9uLCBKdW4gMjYsIDIwMjMgYXQgMTE6MTTigK9BTSBSeWFuIFJv YmVydHMgPHJ5YW4ucm9iZXJ0c0Bhcm0uY29tPiB3cm90ZToKPj4+Pgo+Pj4+IExpa2UgZm9saW9f YWRkX25ld19hbm9uX3JtYXAoKSBidXQgYmF0Y2gtcm1hcHMgYSByYW5nZSBvZiBwYWdlcwo+Pj4+ IGJlbG9uZ2luZyB0byBhIGZvbGlvLCBmb3IgZWZmY2llbmN5IHNhdmluZ3MuIEFsbCBwYWdlcyBh cmUgYWNjb3VudGVkIGFzCj4+Pj4gc21hbGwgcGFnZXMuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5 OiBSeWFuIFJvYmVydHMgPHJ5YW4ucm9iZXJ0c0Bhcm0uY29tPgo+Pj4+IC0tLQo+Pj4+ICBpbmNs dWRlL2xpbnV4L3JtYXAuaCB8ICAyICsrCj4+Pj4gIG1tL3JtYXAuYyAgICAgICAgICAgIHwgNDMg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+ICAyIGZpbGVz IGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKykKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRl L2xpbnV4L3JtYXAuaCBiL2luY2x1ZGUvbGludXgvcm1hcC5oCj4+Pj4gaW5kZXggYTM4MjVjZTgx MTAyLi4xNTQzM2EzZDBjYmYgMTAwNjQ0Cj4+Pj4gLS0tIGEvaW5jbHVkZS9saW51eC9ybWFwLmgK Pj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L3JtYXAuaAo+Pj4+IEBAIC0xOTYsNiArMTk2LDggQEAg dm9pZCBwYWdlX2FkZF9uZXdfYW5vbl9ybWFwKHN0cnVjdCBwYWdlICosIHN0cnVjdCB2bV9hcmVh X3N0cnVjdCAqLAo+Pj4+ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGFkZHJlc3MpOwo+ Pj4+ICB2b2lkIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKHN0cnVjdCBmb2xpbyAqLCBzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKiwKPj4+PiAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRy ZXNzKTsKPj4+PiArdm9pZCBmb2xpb19hZGRfbmV3X2Fub25fcm1hcF9yYW5nZShzdHJ1Y3QgZm9s aW8gKmZvbGlvLCBzdHJ1Y3QgcGFnZSAqcGFnZSwKPj4+PiArICAgICAgICAgICAgICAgaW50IG5y LCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgdW5zaWduZWQgbG9uZyBhZGRyZXNzKTsKPj4+ Cj4+PiBXZSBzaG91bGQgdXBkYXRlIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCkgdG8gc3VwcG9y dCBsYXJnZSgpICYmCj4+PiAhZm9saW9fdGVzdF9wbWRfbWFwcGFibGUoKSBmb2xpb3MgaW5zdGVh ZC4KPj4+Cj4+PiBJIGRvdWJsZSBjaGVja2VkIGFsbCBwbGFjZXMgY3VycmVudGx5IHVzaW5nIGZv bGlvX2FkZF9uZXdfYW5vbl9ybWFwKCksCj4+PiBhbmQgYXMgZXhwZWN0ZWQsIG5vbmUgYWN0dWFs bHkgYWxsb2NhdGVzIGxhcmdlKCkgJiYKPj4+ICFmb2xpb190ZXN0X3BtZF9tYXBwYWJsZSgpIGFu ZCBtYXBzIGl0IG9uZSBieSBvbmUsIHdoaWNoIG1ha2VzIHRoZQo+Pj4gY2FzZXMgc2ltcGxlciwg aS5lLiwKPj4+ICAgaWYgKCFsYXJnZSgpKQo+Pj4gICAgIC8vIHRoZSBleGlzdGluZyBiYXNlcGFn ZSBjYXNlCj4+PiAgIGVsc2UgaWYgKCFmb2xpb190ZXN0X3BtZF9tYXBwYWJsZSgpKQo+Pj4gICAg IC8vIG91ciBuZXcgY2FzZQo+Pj4gICBlbHNlCj4+PiAgICAgLy8gdGhlIGV4aXN0aW5nIFRIUCBj YXNlCj4+Cj4+IEkgZG9uJ3QgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIGVpdGhlciB3YXkuIEhhcHB5 IHRvIGdvIHdpdGggdGhpcyBzdWdnZXN0aW9uLiBCdXQKPj4gdGhlIHJlYXNvbiBJIGRpZCBpdCBh cyBhIG5ldyBmdW5jdGlvbiB3YXMgYmVjYXVzZSBJIHdhcyBmb2xsb3dpbmcgdGhlIHBhdHRlcm4g aW4KPj4gWzFdIHdoaWNoIGFkZHMgYSBuZXcgZm9saW9fYWRkX2ZpbGVfcm1hcF9yYW5nZSgpIGZ1 bmN0aW9uLgo+Pgo+PiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtbW0vMjAyMzAz MTUwNTE0NDQuMzIyOTYyMS0zNS13aWxseUBpbmZyYWRlYWQub3JnLwo+IE9oLiBUaGVyZSBpcyBk aWZmZXJlbnQgaGVyZToKPiBGb3IgcGFnZSBjYWNoZSwgbGFyZ2UgZm9saW8gY291bGQgYmUgY3Jl YXRlZCBieSBwcmV2aW91cyBmaWxlIGFjY2Vzcy4gQnV0IGxhdGVyCj4gZmlsZSBhY2Nlc3MgYnkg b3RoZXIgcHJvY2VzcyBqdXN0IG5lZWQgbWFwIHBhcnRpYWwgbGFyZ2UgZm9saW8uIEluIHRoaXMg Y2FzZSwgd2UgbmVlZAo+IF9yYW5nZSBmb3IgZmlsZW1hcC4KPiAKPiBCdXQgZm9yIGFub255bW91 cywgSSBzdXBwb3NlIHdlIGFsd2F5cyBtYXAgd2hvbGUgZm9saW8gaW4uIFNvIEkgYWdyZWUgd2l0 aCBZdS4gV2UKPiBkb24ndCBuZWVkIF9yYW5nZSBmb3IgZm9saW9fYWRkX25ld19hbm9uX3JtYXAo KS4gVGhhbmtzLgoKWWVzIHRoYXQgbWFrZXMgc2Vuc2UgLSB0aGFua3MuIEknbGwgbWVyZ2UgdGhl IG5ldyBjYXNlIGludG8KZm9saW9fYWRkX25ld19hbm9uX3JtYXAoKSBmb3IgdjIuCgo+IAo+IAo+ IFJlZ2FyZHMKPiBZaW4sIEZlbmd3ZWkKPiAKPj4KPj4KPj4+Cj4+Pj4gIHZvaWQgcGFnZV9hZGRf ZmlsZV9ybWFwKHN0cnVjdCBwYWdlICosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqLAo+Pj4+ICAg ICAgICAgICAgICAgICBib29sIGNvbXBvdW5kKTsKPj4+PiAgdm9pZCBmb2xpb19hZGRfZmlsZV9y bWFwX3JhbmdlKHN0cnVjdCBmb2xpbyAqLCBzdHJ1Y3QgcGFnZSAqLCB1bnNpZ25lZCBpbnQgbnIs Cj4+Pj4gZGlmZiAtLWdpdCBhL21tL3JtYXAuYyBiL21tL3JtYXAuYwo+Pj4+IGluZGV4IDFkODM2 OTU0OTQyNC4uNDA1MGJjZWE3YWU3IDEwMDY0NAo+Pj4+IC0tLSBhL21tL3JtYXAuYwo+Pj4+ICsr KyBiL21tL3JtYXAuYwo+Pj4+IEBAIC0xMzA1LDYgKzEzMDUsNDkgQEAgdm9pZCBmb2xpb19hZGRf bmV3X2Fub25fcm1hcChzdHJ1Y3QgZm9saW8gKmZvbGlvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3Qg KnZtYSwKPj4+PiAgICAgICAgIF9fcGFnZV9zZXRfYW5vbl9ybWFwKGZvbGlvLCAmZm9saW8tPnBh Z2UsIHZtYSwgYWRkcmVzcywgMSk7Cj4+Pj4gIH0KPj4+Pgo+Pj4+ICsvKioKPj4+PiArICogZm9s aW9fYWRkX25ld19hbm9uX3JtYXBfcmFuZ2UgLSBBZGQgbWFwcGluZyB0byBhIHNldCBvZiBwYWdl cyB3aXRoaW4gYSBuZXcKPj4+PiArICogYW5vbnltb3VzIHBvdGVudGlhbGx5IGxhcmdlIGZvbGlv Lgo+Pj4+ICsgKiBAZm9saW86ICAgICAgVGhlIGZvbGlvIGNvbnRhaW5pbmcgdGhlIHBhZ2VzIHRv IGJlIG1hcHBlZAo+Pj4+ICsgKiBAcGFnZTogICAgICAgRmlyc3QgcGFnZSBpbiB0aGUgZm9saW8g dG8gYmUgbWFwcGVkCj4+Pj4gKyAqIEBucjogICAgICAgICBOdW1iZXIgb2YgcGFnZXMgdG8gYmUg bWFwcGVkCj4+Pj4gKyAqIEB2bWE6ICAgICAgICB0aGUgdm0gYXJlYSBpbiB3aGljaCB0aGUgbWFw cGluZyBpcyBhZGRlZAo+Pj4+ICsgKiBAYWRkcmVzczogICAgdGhlIHVzZXIgdmlydHVhbCBhZGRy ZXNzIG9mIHRoZSBmaXJzdCBwYWdlIHRvIGJlIG1hcHBlZAo+Pj4+ICsgKgo+Pj4+ICsgKiBMaWtl IGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCkgYnV0IGJhdGNoLW1hcHMgYSByYW5nZSBvZiBwYWdl cyB3aXRoaW4gYSBmb2xpbwo+Pj4+ICsgKiB1c2luZyBub24tVEhQIGFjY291bnRpbmcuIExpa2Ug Zm9saW9fYWRkX25ld19hbm9uX3JtYXAoKSwgdGhlIGluYy1hbmQtdGVzdCBpcwo+Pj4+ICsgKiBi eXBhc3NlZCBhbmQgdGhlIGZvbGlvIGRvZXMgbm90IGhhdmUgdG8gYmUgbG9ja2VkLiBBbGwgcGFn ZXMgaW4gdGhlIGZvbGlvIGFyZQo+Pj4+ICsgKiBpbmRpdmlkdWFsbHkgYWNjb3VudGVkLgo+Pj4+ ICsgKgo+Pj4+ICsgKiBBcyB0aGUgZm9saW8gaXMgbmV3LCBpdCdzIGFzc3VtZWQgdG8gYmUgbWFw cGVkIGV4Y2x1c2l2ZWx5IGJ5IGEgc2luZ2xlCj4+Pj4gKyAqIHByb2Nlc3MuCj4+Pj4gKyAqLwo+ Pj4+ICt2b2lkIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwX3JhbmdlKHN0cnVjdCBmb2xpbyAqZm9s aW8sIHN0cnVjdCBwYWdlICpwYWdlLAo+Pj4+ICsgICAgICAgICAgICAgICBpbnQgbnIsIHN0cnVj dCB2bV9hcmVhX3N0cnVjdCAqdm1hLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpCj4+Pj4gK3sKPj4+ PiArICAgICAgIGludCBpOwo+Pj4+ICsKPj4+PiArICAgICAgIFZNX0JVR19PTl9WTUEoYWRkcmVz cyA8IHZtYS0+dm1fc3RhcnQgfHwKPj4+PiArICAgICAgICAgICAgICAgICAgICAgYWRkcmVzcyAr IChuciA8PCBQQUdFX1NISUZUKSA+IHZtYS0+dm1fZW5kLCB2bWEpOwo+Pj4KPj4+IEJUVywgVk1f QlVHX09OKiBzaG91bGRuJ3QgYmUgdXNlZCBpbiBuZXcgY29kZToKPj4+IERvY3VtZW50YXRpb24v cHJvY2Vzcy9jb2Rpbmctc3R5bGUucnN0Cj4+Cj4+IFRoYW5rcywgc29ycnkgYWJvdXQgdGhhdC4g V2FzIGNvcHktcGFzdGluZyBmcm9tIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCkuCj4+CgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=