From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: [PATCH] xentrace: fix bug in t_info size Date: Fri, 7 May 2010 19:25:47 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: george.dunlap@eu.citrix.com List-Id: xen-devel@lists.xenproject.org t_info size should be in bytes, not pages. This fixes a bug that crashes the hypervisor if the total number of all pages is more than 1024 but less than 2048. Signed-off-by: George Dunlap diff -r caea94988515 -r e633befe28ec xen/common/trace.c --- a/xen/common/trace.c Fri May 07 11:45:18 2010 +0100 +++ b/xen/common/trace.c Fri May 07 19:20:52 2010 -0500 @@ -340,7 +340,7 @@ case XEN_SYSCTL_TBUFOP_get_info: tbc->evt_mask = tb_event_mask; tbc->buffer_mfn = t_info ? virt_to_mfn(t_info) : 0; - tbc->size = T_INFO_PAGES; + tbc->size = T_INFO_PAGES * PAGE_SIZE; break; case XEN_SYSCTL_TBUFOP_set_cpu_mask: xenctl_cpumap_to_cpumask(&tb_cpu_mask, &tbc->cpu_mask);