From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/19] drm/i915: Pull the context->pin_count dec into the common intel_context_unpin Date: Thu, 17 May 2018 11:20:22 +0100 Message-ID: References: <20180517074055.14638-1-chris@chris-wilson.co.uk> <20180517074055.14638-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 346AE6E798 for ; Thu, 17 May 2018 10:20:27 +0000 (UTC) In-Reply-To: <20180517074055.14638-4-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA1LzIwMTggMDg6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBcyBhbGwgYmFja2Vu ZHMgaW1wbGVtZW50IHRoZSBzYW1lIHBpbl9jb3VudCBtZWNoYW5pc20gYW5kIGRvIGEKPiBkZWMt YW5kLXRlc3QgYXMgdGhlaXIgZmlyc3Qgc3RlcCwgcHVsbCB0aGF0IGludG8gdGhlIGNvbW1vbgo+ IGludGVsX2NvbnRleHRfdW5waW4oKS4gVGhpcyBhbHNvIHB1bGxzIGludG8gdGhlIGNhbGxlciwg ZWxpbWluYXRpbmcgdGhlCj4gaW5kaXJlY3QgY2FsbCBpbiB0aGUgdXN1YWwgc3RlYWR5IHN0YXRl IGNhc2UuIFRoZSBpbnRlbF9jb250ZXh0X3BpbigpCj4gc2lkZSBpcyBhIGxpdHRsZSBtb3JlIGNv bXBsaWNhdGVkIGFzIGl0IGNvbWJpbmVzIHRoZSBsb29rdXAvYWxsb2MgYXMKPiB3ZWxsIGFzIHBp bm5pbmcgdGhlIHN0YXRlLCBhbmQgc28gaXMgbGVmdCBmb3IgYSBsYXRlciBkYXRlLgo+IAo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENj OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oICAgICAgfCAgNCArKysrCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgICAgICB8IDEzICstLS0tLS0t LS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyAgICAgIHwg IDYgLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19lbmdpbmUu YyB8ICAzIC0tLQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIxIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9j b250ZXh0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmgKPiBpbmRl eCA3NDlhNGZmNTY2ZjUuLmMzMjYyYjRkZDJlZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9jb250ZXh0LmgKPiBAQCAtMjg1LDYgKzI4NSwxMCBAQCBzdGF0aWMgaW5saW5lIHZv aWQgX19pbnRlbF9jb250ZXh0X3BpbihzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpCj4gICAKPiAg IHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9jb250ZXh0X3VucGluKHN0cnVjdCBpbnRlbF9jb250 ZXh0ICpjZSkKPiAgIHsKPiArCUdFTV9CVUdfT04oIWNlLT5waW5fY291bnQpOwo+ICsJaWYgKC0t Y2UtPnBpbl9jb3VudCkKPiArCQlyZXR1cm47Cj4gKwo+ICAgCUdFTV9CVUdfT04oIWNlLT5vcHMp Owo+ICAgCWNlLT5vcHMtPnVucGluKGNlKTsKPiAgIH0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+IGluZGV4IDk2MDk0ODYxNzc0OC4uZjM0NzBiOTVkNjRlIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPiBAQCAtMTM0NCw3ICsxMzQ0LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3Rz X2NvbnRleHRfZGVzdHJveShzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpCj4gICAJX19pOTE1X2dl bV9vYmplY3RfcmVsZWFzZV91bmxlc3NfYWN0aXZlKGNlLT5zdGF0ZS0+b2JqKTsKPiAgIH0KPiAg IAo+IC1zdGF0aWMgdm9pZCBfX2V4ZWNsaXN0c19jb250ZXh0X3VucGluKHN0cnVjdCBpbnRlbF9j b250ZXh0ICpjZSkKPiArc3RhdGljIHZvaWQgZXhlY2xpc3RzX2NvbnRleHRfdW5waW4oc3RydWN0 IGludGVsX2NvbnRleHQgKmNlKQo+ICAgewo+ICAgCWludGVsX3JpbmdfdW5waW4oY2UtPnJpbmcp Owo+ICAgCj4gQEAgLTEzNTUsMTcgKzEzNTUsNiBAQCBzdGF0aWMgdm9pZCBfX2V4ZWNsaXN0c19j b250ZXh0X3VucGluKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSkKPiAgIAlpOTE1X2dlbV9jb250 ZXh0X3B1dChjZS0+Z2VtX2NvbnRleHQpOwo+ICAgfQo+ICAgCj4gLXN0YXRpYyB2b2lkIGV4ZWNs aXN0c19jb250ZXh0X3VucGluKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSkKPiAtewo+IC0JbG9j a2RlcF9hc3NlcnRfaGVsZCgmY2UtPmdlbV9jb250ZXh0LT5pOTE1LT5kcm0uc3RydWN0X211dGV4 KTsKCkRvIHlvdSB3YW50IHRvIHByZXNlcnZlIHRoZXNlIGFzc2VydHM/Cgo+IC0JR0VNX0JVR19P TihjZS0+cGluX2NvdW50ID09IDApOwo+IC0KPiAtCWlmICgtLWNlLT5waW5fY291bnQpCj4gLQkJ cmV0dXJuOwo+IC0KPiAtCV9fZXhlY2xpc3RzX2NvbnRleHRfdW5waW4oY2UpOwo+IC19Cj4gLQo+ ICAgc3RhdGljIGludCBfX2NvbnRleHRfcGluKHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgs IHN0cnVjdCBpOTE1X3ZtYSAqdm1hKQo+ICAgewo+ICAgCXVuc2lnbmVkIGludCBmbGFnczsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5kZXggMGMwYzlmNTMxZTRl Li4wMDFjZjZiY2IzNDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5jCj4gQEAgLTExOTUsMTIgKzExOTUsNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9yaW5nX2NvbnRl eHRfZGVzdHJveShzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpCj4gICAKPiAgIHN0YXRpYyB2b2lk IGludGVsX3JpbmdfY29udGV4dF91bnBpbihzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpCj4gICB7 Cj4gLQlsb2NrZGVwX2Fzc2VydF9oZWxkKCZjZS0+Z2VtX2NvbnRleHQtPmk5MTUtPmRybS5zdHJ1 Y3RfbXV0ZXgpOwo+IC0JR0VNX0JVR19PTihjZS0+cGluX2NvdW50ID09IDApOwo+IC0KPiAtCWlm ICgtLWNlLT5waW5fY291bnQpCj4gLQkJcmV0dXJuOwo+IC0KPiAgIAlpZiAoY2UtPnN0YXRlKSB7 Cj4gICAJCWNlLT5zdGF0ZS0+b2JqLT5waW5fZ2xvYmFsLS07Cj4gICAJCWk5MTVfdm1hX3VucGlu KGNlLT5zdGF0ZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0 cy9tb2NrX2VuZ2luZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5n aW5lLmMKPiBpbmRleCAzM2VkZGZjMWY4Y2UuLmYxYWM3NDUzMDUzZSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19lbmdpbmUuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jCj4gQEAgLTc0LDkgKzc0LDYg QEAgc3RhdGljIHZvaWQgaHdfZGVsYXlfY29tcGxldGUoc3RydWN0IHRpbWVyX2xpc3QgKnQpCj4g ICAKPiAgIHN0YXRpYyB2b2lkIG1vY2tfY29udGV4dF91bnBpbihzdHJ1Y3QgaW50ZWxfY29udGV4 dCAqY2UpCj4gICB7Cj4gLQlpZiAoLS1jZS0+cGluX2NvdW50KQo+IC0JCXJldHVybjsKPiAtCj4g ICAJaTkxNV9nZW1fY29udGV4dF9wdXQoY2UtPmdlbV9jb250ZXh0KTsKPiAgIH0KPiAgIAo+IAoK UmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpS ZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK