From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B73CDCA5FB1 for ; Wed, 30 Sep 2026 06:37:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1436871.1655541 (Exim 4.92) (envelope-from ) id 1xBnwW-0001oN-Qv; Wed, 30 Sep 2026 06:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1436871.1655541; Wed, 30 Sep 2026 06:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xBnwW-0001oG-Nv; Wed, 30 Sep 2026 06:37:28 +0000 Received: by outflank-mailman (input) for mailman id 1436871; Wed, 30 Sep 2026 06:37:27 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1xBnwV-0001o1-B6 for xen-devel@lists.xenproject.org; Wed, 30 Sep 2026 06:37:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xBnwU-008QDX-O0 for xen-devel@lists.xenproject.org; Wed, 30 Sep 2026 08:37:26 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6abcae21-bab6-0a2a0a5309dd-0a2a4506a39c-12 for ; Wed, 30 Sep 2026 08:37:26 +0200 Received: from [74.125.225.76] (helo=mail-wr2-f12.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6abcae26-195a-0a2a45060019-4a7de14cd5aa-3 for ; Wed, 30 Sep 2026 08:37:26 +0200 Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48434392b02so4281937f8f.3 for ; Tue, 29 Sep 2026 23:37:26 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b029f3b1fsm966362f8f.26.2026.09.29.23.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 23:37:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1790750246; x=1791355046; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RFuKiIy+5nS0zSkaiJ5R/eNFcfx+G4jHm5xUKwaK1XM=; b=V3dJe0Crx9X+Kce4EjnjG62pmP9VvI0yl4sozJ4gVIQGAP87clZZ2hV6VOJ+9Bptaa L3VbrzYwBA/awLEyd/KEyDlxS0bV7vv8HysRK+u7NLC4wnNRKv+6wDVgQ0/lLAegOibH gwrGHjrnCNStxd8xcEeDAeIIgRAoNre3qfyukRUOJmlS2QCxwjKMTafURWyAd9W01RAn znI7uiNdGo/sZ1jWLJTXL+mDYMDZzl8Bf4rtGEdfisEDadx77Kt6Wla0eZGwqdPuEckQ 2ivnOrU7iNmLVznjP3zYijvc9c8oTcrNIUBX4xo/0c47ao+R6CemoTIVqDAYGBrz3Khf 4GYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790750246; x=1791355046; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RFuKiIy+5nS0zSkaiJ5R/eNFcfx+G4jHm5xUKwaK1XM=; b=TAv4TxuUkJkF/MZlR133NMUmd+sWs7SI9jIUX+Tb5MuvsqyjFB9u/McJFNpGrYynpl ZXjMpuhWx8gogjulrINNkI3Q5hEyOFvoTvChuwYsgDcqRBnAHk9MEiMyz3v0XpZ0vpFa j0KZu7QiQC5DH3dZZ9RiSVn1ADDfemMRsc+TgCv6cJd11abcBs+4kdh3BNxPTaqlFHfY /2mXWW311YWxSEmWzu0PrxN5GNV0CogwxO3Zz4qcKJkfNLU37trV8ZFKd0IEiPhuX8Db zslz+a0MLwTUjdYVC6apeCHTqA+RZjIqi4p0QTWbEKOXv4naIc4yiGszgf7pzOkgay8e CbHQ== X-Forwarded-Encrypted: i=1; AKwUvBy8xEzGqD5WANSFEwmf6kHT5g7rSEUXUctIa45ISXJXmSgSqq3U5SaEpCrB/Ouf8M4lnlvZgX9s5W4=@lists.xenproject.org X-Gm-Message-State: AFq9FYKpuLX67sSa4EouPnwVk+idyVwpuO2hQGSQvH0kIoC5NR1/3ADy HBh195de6o280Op+YLppNFanN3g4ygl+8eZwsf29EUUF87Y4Pew2wug3AvTtS70dhQ== X-Gm-Gg: AYBFou2gh06h7GCFsQkmamPHpOEoHcF52/imFAhm4VxVNDvKEdvsuo1jj995dFZ66FY qrnUhaT3GJgF8AoJRnlUDroZrQZImeZjYV4IiBKUxT8bzKpCG109YlSw6gzUVnjveohaL1XZo3A KlTIUPv6Qtjm1yOJsoo/C/GT7kWu8DWEcVnYyIgPVLQqd+fGZTAlv9T4RuJmZrNJzjz8++5+XjB SG4zvqwkymdnnAdd4Cf1YjChCjmuIihLVjlhC2yyKnE2ZSdR7Md/mJ7wGl4poBnI1oua3ClzTof JCdaytR4+1P1Fhx5NbGKnEeHyTdifYP2/AoPkY0BTf7AfJlXSnaii7HC8/R5Nj+PDmmTmo092l9 aztrTFx5kDra26aPrHJXjEhcYU7ORUWkyhemjwKad4NfOLowjPMIwzXPftEKW12dblc8jTr6I5b Qcre/Qsd19U7C/bWYDn7ZnWrIL8PeBRdBHnFyxBCroiqhk19Db/eoKhZME3Oc49x0tDqAWUl/RO Z3lC2foG6nC96QfXzNhh5vTwDXT8mkibZ61+hpr+VhjtYRiRjtHvFfUuD8f8g== X-Received: by 2002:a05:6000:3c7:b0:485:ac96:7251 with SMTP id ffacd0b85a97d-48b02503143mr819954f8f.21.1790750246254; Tue, 29 Sep 2026 23:37:26 -0700 (PDT) Message-ID: Date: Wed, 30 Sep 2026 08:37:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] x86/svm: Cleanup ns_hostflags type To: Ross Lagerwall Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk , Teddy Astie , xen-devel@lists.xenproject.org References: <20260928140248.1543013-1-ross.lagerwall@citrix.com> <20260928140248.1543013-6-ross.lagerwall@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260928140248.1543013-6-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1790750246-1EEC477B-28DFB91B/10/78276251493 X-purgate-type: spam X-purgate-size: 781 On 28.09.2026 16:02, Ross Lagerwall wrote: > @@ -182,7 +182,7 @@ static int nsvm_vcpu_hostsave(struct vcpu *v, unsigned int inst_len) > n1vmcb->_cr4 = v->arch.hvm.guest_cr[4]; > > /* Remember the host interrupt flag */ > - svm->ns_hostflags.fields.rflagsif = !!(n1vmcb->rflags & X86_EFLAGS_IF); > + svm->ns_hostflags.rflagsif = !!(n1vmcb->rflags & X86_EFLAGS_IF); No neeed for !! anymore. > @@ -651,7 +651,7 @@ nsvm_vcpu_vmentry(struct vcpu *v, struct cpu_user_regs *regs, > svm->ns_hap_enabled = vmcb_get_np(ns_vmcb); > > /* Remember the V_INTR_MASK in hostflags */ > - svm->ns_hostflags.fields.vintrmask = !!ns_vmcb->_vintr.intr_masking; > + svm->ns_hostflags.vintrmask = !!ns_vmcb->_vintr.intr_masking; Same here. Jan