Re: [PATCH 09/13] ARM: stm32mp: add ETZPC system bus driver for STM32MP1

[Patrice CHOTARD <patrice.chotard@foss.st.com>]

On 4/22/25 10:31, Patrick DELAUNAY wrote:
> Hi,
> 
> 
> On 4/1/25 15:14, Patrice Chotard wrote:
>> From: Lionel Debieve <lionel.debieve@foss.st.com>
>>
>> This driver is checking the access rights of the different
>> peripherals connected to the ETZPC bus. If access is denied,
>> the associated device is not bound.
>>
>> Signed-off-by: Lionel Debieve <lionel.debieve@foss.st.com>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/mach-stm32mp/include/mach/etzpc.h |  32 ++++
>>   arch/arm/mach-stm32mp/stm32mp1/Makefile    |   1 +
>>   arch/arm/mach-stm32mp/stm32mp1/etzpc.c     | 194 +++++++++++++++++++++
>>   3 files changed, 227 insertions(+)
>>   create mode 100644 arch/arm/mach-stm32mp/include/mach/etzpc.h
>>   create mode 100644 arch/arm/mach-stm32mp/stm32mp1/etzpc.c
>>
> ...
>> diff --git a/arch/arm/mach-stm32mp/stm32mp1/etzpc.c b/arch/arm/mach-stm32mp/stm32mp1/etzpc.c
>> new file mode 100644
>> index 00000000000..b7aefb84069
>> --- /dev/null
>> +++ b/arch/arm/mach-stm32mp/stm32mp1/etzpc.c
>> @@ -0,0 +1,194 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-3-Clause
>> +/*
>> + * Copyright (C) 2023, STMicroelectronics - All Rights Reserved
>> + */
>> +
>> +#define LOG_CATEGORY UCLASS_SIMPLE_BUS
> 
> 
> minor  => why SIMPLE_BUS here ?
> 
> 
> #define LOG_CATEGORY UCLASS_NOP

Ok will update it

Thanks

> 
> 
>> +
>> +#include <dm.h>
>> +#include <asm/io.h>
>> +#include <dm/device.h>
>> +#include <dm/device_compat.h>
>> +#include <dm/lists.h>
>> +#include <linux/bitfield.h>
>> +#include <mach/etzpc.h>
>> +
> ...
>> +
>> +U_BOOT_DRIVER(stm32_etzpc) = {
>> +    .name = "stm32_etzpc",
>> +    .id = UCLASS_NOP,
>> +    .of_match = stm32_etzpc_ids,
>> +    .bind = stm32_etzpc_bind,
>> +    .plat_auto = sizeof(struct stm32_etzpc_plat),
>> +};
> 
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
> 
>