答复: [PATCH] page_pool: mark unbound node page as reusable pages

["Li,Rongqing" <lirongqing@baidu.com>]

> -----邮件原件-----
> 发件人: Yunsheng Lin [mailto:linyunsheng@huawei.com]
> 发送时间: 2019年12月5日 8:55
> 收件人: Li,Rongqing <lirongqing@baidu.com>; netdev@vger.kernel.org;
> saeedm@mellanox.com
> 主题: Re: [PATCH] page_pool: mark unbound node page as reusable pages
> 
> On 2019/12/4 18:14, Li RongQing wrote:
> > some drivers uses page pool, but not require to allocate page from
> > bound node, so pool.p.nid is NUMA_NO_NODE, and this fixed patch will
> > block this kind of driver to recycle
> >
> > Fixes: d5394610b1ba ("page_pool: Don't recycle non-reusable pages")
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
> > Cc: Saeed Mahameed <saeedm@mellanox.com>
> > ---
> >  net/core/page_pool.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/core/page_pool.c b/net/core/page_pool.c index
> > a6aefe989043..4054db683178 100644
> > --- a/net/core/page_pool.c
> > +++ b/net/core/page_pool.c
> > @@ -317,7 +317,9 @@ static bool __page_pool_recycle_direct(struct page
> *page,
> >   */
> >  static bool pool_page_reusable(struct page_pool *pool, struct page
> > *page)  {
> > -	return !page_is_pfmemalloc(page) && page_to_nid(page) == pool->p.nid;
> > +	return !page_is_pfmemalloc(page) &&
> > +		(page_to_nid(page) == pool->p.nid ||
> > +		 pool->p.nid == NUMA_NO_NODE);
> 
> If I understand it correctly, you are allowing recycling when
> pool->p.nid is NUMA_NO_NODE, which does not seems match the commit
> log: "this fixed patch will block this kind of driver to recycle".
> 
> Maybe you mean "commit d5394610b1ba" by this fixed patch?
> 


I maybe should change the commit header as below:


    page_pool: take unbound numa node allocated pages as reusable
    
    some drivers uses page pool, but not require to allocate
    page from bound node, so pool.p.nid is NUMA_NO_NODE, and
    the commit d5394610b1ba ("page_pool: Don't recycle
    non-reusable pages") will block this kind of driver to
    recycle
    
    Fixes: d5394610b1ba ("page_pool: Don't recycle non-reusable pages")

Thanks

-RongQing


> Also, maybe it is better to allow recycling if the below condition is matched:
> 
> 	pool->p.nid == NUMA_NO_NODE && page_to_nid(page) ==
> numa_mem_id()
> 
> >  }
> >
> >  void __page_pool_put_page(struct page_pool *pool, struct page *page,
> >