All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.caveayland@nutanix.com>
To: "Cédric Le Goater" <clg@redhat.com>,
	john.levon@nutanix.com, thanos.makatos@nutanix.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value
Date: Wed, 21 Jan 2026 12:06:17 +0000	[thread overview]
Message-ID: <e64cc3a1-2192-4bc1-b616-0676c4798a19@nutanix.com> (raw)
In-Reply-To: <21dea4e5-9a08-44c6-b18a-c7da790a173a@redhat.com>

On 21/01/2026 11:15, Cédric Le Goater wrote:

> On 1/21/26 11:59, Mark Cave-Ayland wrote:
>> The constant value should represent the next bit in the VFIOProxy 
>> flags which
>> is 0x10 and not 0x16.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> 
> Should there be a Fixes tag ?

Yes indeed, it should be:

Fixes: 1a0c32a9da ("vfio-user: add coalesced posted writes")

Would you like me to resend a v2?


ATB,

Mark.

> Thanks,
> 
> C.
> 
> 
>> ---
>>   hw/vfio-user/proxy.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
>> index 61e64a0020..b09fd886f1 100644
>> --- a/hw/vfio-user/proxy.h
>> +++ b/hw/vfio-user/proxy.h
>> @@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
>>   #define VFIO_PROXY_CLIENT        0x1
>>   #define VFIO_PROXY_FORCE_QUEUED  0x4
>>   #define VFIO_PROXY_NO_POST       0x8
>> -#define VFIO_PROXY_USE_MULTI     0x16
>> +#define VFIO_PROXY_USE_MULTI     0x10
>>   /* coalescing high and low water marks for VFIOProxy num_outgoing */
>>   #define VFIO_USER_OUT_HIGH       1024




  reply	other threads:[~2026-01-21 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 10:59 [PATCH 0/2] vfio-user: trivial VFIOProxy flags fix Mark Cave-Ayland
2026-01-21 10:59 ` [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value Mark Cave-Ayland
2026-01-21 11:13   ` John Levon
2026-01-21 11:15   ` Cédric Le Goater
2026-01-21 12:06     ` Mark Cave-Ayland [this message]
2026-01-21 11:16   ` John Levon
2026-01-21 10:59 ` [PATCH 2/2] vfio-user: update VFIOProxy flag constants to use the BIT() macro Mark Cave-Ayland
2026-01-21 11:15   ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e64cc3a1-2192-4bc1-b616-0676c4798a19@nutanix.com \
    --to=mark.caveayland@nutanix.com \
    --cc=clg@redhat.com \
    --cc=john.levon@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thanos.makatos@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.