From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"Xu, Yilun" <yilun.xu@intel.com>,
"artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Gao, Chao" <chao.gao@intel.com>,
"Fang, Peter" <peter.fang@intel.com>,
"Maloor, Kishen" <kishen.maloor@intel.com>
Subject: Re: [PATCH v5 5/6] x86/virt/tdx: Make TDX module initialize the extensions
Date: Wed, 18 Nov 2026 22:44:06 +0000 [thread overview]
Message-ID: <e658fad644d8f79afa77f48368f0dcd375554bad.camel@intel.com> (raw)
In-Reply-To: <20261111-tdx-module-ext-v5-5-c74f764abc3d@linux.intel.com>
On Wed, 2026-11-11 at 11:48 +0800, Xu Yilun wrote:
> Continue fleshing out the extension initialization process. At this
> point the kernel has provided all memory and the TDX module is ready to
> initialize the extensions on the memory.
>
> Initialize TDX module extensions via TDH.EXT.INIT. This process takes on
> the order of 100's of milliseconds, during which the TDX module loads
> its internal extension image into this memory and builds the execution
> environment. Once initialized, those add-on features can use their
> SEAMCALL leafs normally.
>
> Note that TDH.EXT.INIT builds all configured extensions. The SEAMCALL
> leaf fails if any extension fails to initialize. The kernel does simple
> error handling - just fails the whole TDX initialization on any error.
> This is OK cause all extensions are considered necessary for security.
^because? "cause" in the use is more of a colloquialism. As a word
"cause" is like "The cause of A is B". But sometimes informally "because" is
said like "'cause" where the "be" is sort of sloppily dropped. So this reads
like that.
> If a nice-to-have extension appears in the future, this can be
> revisited. A potential solution is to have a new metadata field
> indicating which extensions get enabled/failed, then the kernel decides
> whether to continue or abort.
>
> The original changelog was written by hand. AI was used to help correct
> grammatical errors and polish individual sentences for better
> readability.
>
> Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Reviewed-by: Tony Lindgren <tony.lindgren@linux.intel.com>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> ---
> v5:
> - A new paragraph to describe the error handling.
> - Refactor the existing changelog.
> - Better clarify the AI usage.
>
> v4:
> - Specify what TDH.EXT.INIT is doing in the changelog (Rick)
> - Collect Reviewed-by tags
>
> v1:
> - Fix return value for SEAMCALL wrappers (Chao)
> - Print SEAMCALL error code for SEAMCALL wrappers (Xiaoyao)
> - Changelog & code comments
> ---
> arch/x86/virt/vmx/tdx/tdx.h | 1 +
> arch/x86/virt/vmx/tdx/tdx.c | 25 ++++++++++++++++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h
> index 2adc5d31d258..cac0a5abbff1 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.h
> +++ b/arch/x86/virt/vmx/tdx/tdx.h
> @@ -50,6 +50,7 @@
> #define TDH_SYS_UPDATE 53
> #define TDH_PHYMEM_PAMT_ADD 58
> #define TDH_PHYMEM_PAMT_REMOVE 59
> +#define TDH_EXT_INIT 60
> #define TDH_EXT_MEM_ADD 61
> #define TDH_SYS_DISABLE 69
>
> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index 3440f1878978..3a1ba4e73cfe 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -1343,12 +1343,35 @@ static __init int tdx_ext_mem_setup(void)
> return ret;
> }
>
> +static __init int tdx_ext_init(void)
> +{
> + struct tdx_module_args args = {};
> + u64 ret;
> +
> + do {
> + ret = seamcall(TDH_EXT_INIT, &args);
> + } while (ret == TDX_INTERRUPTED_RESUMABLE);
> +
> + if (ret != TDX_SUCCESS) {
> + pr_err("TDH.EXT.INIT failed: 0x%016llx\n", ret);
> + return -EIO;
> + }
> +
> + return 0;
> +}
> +
> static __init int init_tdx_module_extensions(void)
> {
> + int ret;
> +
> if (!(tdx_sysinfo.features.tdx_features0 & TDX_FEATURES0_EXT))
> return 0;
>
> - return tdx_ext_mem_setup();
> + ret = tdx_ext_mem_setup();
> + if (ret)
> + return ret;
> +
> + return tdx_ext_init();
> }
>
> static __init int init_tdx_module(void)
>
next prev parent reply other threads:[~2026-11-18 22:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 3:48 [PATCH v5 0/6] Enable TDX module extensions Xu Yilun
2026-11-11 3:48 ` [PATCH v5 1/6] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper Xu Yilun
2026-11-13 15:06 ` Nikolay Borisov
2026-11-18 18:51 ` Edgecombe, Rick P
2026-11-19 3:31 ` Xu Yilun
2026-11-11 3:48 ` [PATCH v5 2/6] x86/virt/tdx: Configure add-on features on TDX module init Xu Yilun
2026-11-11 3:48 ` [PATCH v5 3/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-11-17 3:06 ` Alexey Kardashevskiy
2026-11-18 2:32 ` Xu Yilun
2026-11-18 22:18 ` Edgecombe, Rick P
2026-11-19 4:50 ` Xu Yilun
2026-11-11 3:48 ` [PATCH v5 4/6] x86/virt/tdx: Support DPAMT when adding memory " Xu Yilun
2026-11-11 3:48 ` [PATCH v5 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-11-13 16:13 ` Nikolay Borisov
2026-11-18 22:44 ` Edgecombe, Rick P [this message]
2026-11-19 5:20 ` Xu Yilun
2026-11-11 3:48 ` [PATCH v5 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e658fad644d8f79afa77f48368f0dcd375554bad.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=peter.fang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.