From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: michal.orzel@amd.com, xenia.ragiadakou@amd.com,
ayan.kumar.halder@amd.com, consulting@bugseng.com,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Nicola Vetrini <nicola.vetrini@bugseng.com>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH v2 1/3] xen/arch/arm: fix violations of MISRA C:2012 Rule 3.1
Date: Mon, 19 Jun 2023 12:25:30 +0200 [thread overview]
Message-ID: <e6cf2ec6-070d-1c8a-9273-478cf5587d9c@suse.com> (raw)
In-Reply-To: <51501199-80e6-e33f-e70a-7a36d26c1894@xen.org>
On 19.06.2023 12:01, Julien Grall wrote:
> On 19/06/2023 10:56, Nicola Vetrini wrote:
>> In the files `xen/arch/arm/include/asm/arm(32|64)/flushtlb.h' there are a
>> few occurrences of nested '//' character sequences inside C-style comment
>> blocks, which violate Rule 3.1. The patch aims to resolve those by removing
>> the nested comments.
>
> As I wrote in
> https://lore.kernel.org/xen-devel/f3fc1848-68ca-37a1-add2-e100b4773190@xen.org/,
> I am against replacing '//' with nothing. I have proposed to use ';'
> because this is also a valid way to comment in assembly.
Are you sure about this? For gas most targets use ; as a statement separator,
not as a comment character. Afaics arm-* and aarch64-* are no exception there.
Jan
next prev parent reply other threads:[~2023-06-19 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 9:56 [XEN PATCH v2 0/3] fix violations of MISRA C:2012 Rule 3.1 Nicola Vetrini
2023-06-19 9:56 ` [XEN PATCH v2 1/3] xen/arch/arm: " Nicola Vetrini
2023-06-19 10:01 ` Julien Grall
2023-06-19 10:25 ` Jan Beulich [this message]
2023-06-19 10:29 ` Julien Grall
2023-06-20 13:56 ` Nicola Vetrini
2023-06-19 9:56 ` [XEN PATCH v2 2/3] xen/drivers/passthrough/arm/smmu-v3.c: " Nicola Vetrini
2023-06-19 10:10 ` Julien Grall
2023-06-20 8:06 ` Nicola Vetrini
2023-06-19 9:56 ` [XEN PATCH v2 3/3] xen: " Nicola Vetrini
2023-06-19 10:29 ` Jan Beulich
2023-06-20 8:00 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6cf2ec6-070d-1c8a-9273-478cf5587d9c@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=nicola.vetrini@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.