From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net,
Felix Fietkau <nbd@nbd.name>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC v2 1/4] mac80211: Add TXQ scheduling API
Date: Mon, 30 Jul 2018 17:19:18 -0700 [thread overview]
Message-ID: <e6d2908652d7915ed6b61eaeab3f8ece@codeaurora.org> (raw)
In-Reply-To: <87effkz6ft.fsf@toke.dk>
On 2018-07-30 15:48, Toke Høiland-Jørgensen wrote:
> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>
> Hmm, the driver really shouldn't need to do any locking apart from
> using
> the next_txq() API. But I think you are right that the seqno mechanism
> doesn't play well with unserialised access to through next_txq() from
> multiple CPUs. I'll see what I can do about that, and also incorporate
> the other changes we've been discussing into a new RFC series.
>
Great.. :)
>> Hmm.. reorder_txq() API may not needed. Calling next_txq() takes care
>> of reordering list though the driver is accessing txqs directly.
>
> Right, as long as the next_txq() path is still called even while
> fetch_ind() is active, that should be fine.
>
I am still wondering how and when to refill deficit in case next_txq()
won't be called. :(
Will post RFC change on top of yours.
-Rajkumar
next prev parent reply other threads:[~2018-07-31 1:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 16:37 [RFC v2 0/4] Move TXQ scheduling into mac80211 Toke Høiland-Jørgensen
2018-07-09 16:37 ` [RFC v2 1/4] mac80211: Add TXQ scheduling API Toke Høiland-Jørgensen
2018-07-11 0:14 ` Rajkumar Manoharan
2018-07-11 20:48 ` Toke Høiland-Jørgensen
2018-07-12 22:40 ` Rajkumar Manoharan
2018-07-12 23:13 ` Toke Høiland-Jørgensen
2018-07-13 0:33 ` Rajkumar Manoharan
2018-07-13 13:39 ` Toke Høiland-Jørgensen
2018-07-17 1:06 ` Rajkumar Manoharan
2018-07-19 14:18 ` Toke Høiland-Jørgensen
2018-07-21 1:01 ` Rajkumar Manoharan
2018-07-21 20:54 ` Toke Høiland-Jørgensen
2018-07-24 0:42 ` Rajkumar Manoharan
2018-07-24 11:08 ` Toke Høiland-Jørgensen
2018-07-30 21:10 ` Rajkumar Manoharan
2018-07-30 22:48 ` Toke Høiland-Jørgensen
2018-07-31 0:19 ` Rajkumar Manoharan [this message]
2018-08-29 7:36 ` Johannes Berg
2018-08-29 9:22 ` Toke Høiland-Jørgensen
2018-08-29 9:24 ` Johannes Berg
2018-08-29 10:09 ` Toke Høiland-Jørgensen
2018-07-09 16:37 ` [RFC v2 4/4] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs Toke Høiland-Jørgensen
2018-07-09 16:37 ` [RFC v2 3/4] cfg80211: Add airtime statistics and settings Toke Høiland-Jørgensen
2018-07-09 16:37 ` [RFC v2 2/4] mac80211: Add airtime accounting and scheduling to TXQs Toke Høiland-Jørgensen
2018-08-29 7:44 ` Johannes Berg
2018-08-29 9:27 ` Toke Høiland-Jørgensen
2018-08-29 10:14 ` Johannes Berg
2018-08-29 10:33 ` Toke Høiland-Jørgensen
2018-08-29 10:40 ` Johannes Berg
2018-08-29 14:16 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6d2908652d7915ed6b61eaeab3f8ece@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.