From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Val Packett <val@packett.cool>,
Daniel Scally <djrscally@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] media: dt-bindings: i2c: add DW9719/DW9718S VCM binding
Date: Mon, 10 Feb 2025 12:04:43 +0100 [thread overview]
Message-ID: <e6daacbf-2cfe-4489-942d-037b542143d4@kernel.org> (raw)
In-Reply-To: <Z6nWp3bpoiqpvpS-@kekkonen.localdomain>
On 10/02/2025 11:36, Sakari Ailus wrote:
> Hi Krzysztof,
>
> On Mon, Feb 10, 2025 at 09:29:25AM +0100, Krzysztof Kozlowski wrote:
>>> + dongwoon,vcm-freq:
>>> + description:
>>> + The switching frequency for the voice coil motor.
>>
>> Frequency is in Hertz, so use proper property unit suffix. BTW, you
>> cannot add incorrect properties post-factum based on already accepted
>> ACPI driver. This would be nice bypass of review, right?
>
> What's actually configured here is the divisor (10 MHz clock, divisor seems
> to be value + 2). It's similar to existing
> Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml . I prefer
> this as it's much easier to use that in a driver (think of having values
> like 1428571 in DT, too).
Sure, but then this should be renamed to match purpose and description
rephrased.
>
>>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
And this would stay + constraints.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-10 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 8:19 [PATCH 0/5] media: i2c: dw9719: add DT compatible and DW9718S support Val Packett
2025-02-10 8:19 ` [PATCH 1/5] media: dt-bindings: i2c: add DW9719/DW9718S VCM binding Val Packett
2025-02-10 8:29 ` Krzysztof Kozlowski
2025-02-10 10:36 ` Sakari Ailus
2025-02-10 11:04 ` Krzysztof Kozlowski [this message]
2025-07-02 20:31 ` André Apitzsch
2025-02-10 8:19 ` [PATCH 2/5] media: i2c: dw9719: add an of_match_table Val Packett
2025-02-10 8:19 ` [PATCH 3/5] media: i2c: dw9719: increase tOPR wait time Val Packett
2025-02-10 8:19 ` [PATCH 4/5] media: i2c: dw9719: update PM last busy time upon close Val Packett
2025-02-10 8:19 ` [PATCH 5/5] media: i2c: dw9719: add support for dw9718s Val Packett
2025-02-10 10:47 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6daacbf-2cfe-4489-942d-037b542143d4@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.