[parisc-linux] Re: FDDI (defxx) and Linux/PA = HPMC

[Max Grabert <parisc@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

On Apr 10, 2005 10:31 PM, Max Grabert <parisc@gmail.com> wrote:
> On Apr 10, 2005 9:20 PM, Max Grabert <parisc@gmail.com> wrote:
> 
> [...]
> 
> > I'm trying to get FDDI working on Linux/PA.
> >
> > So I put a DEFPA card into my c3k (2.6.12-rc2-pa1, 32bit,
> > gcc-3.4, Debian/testing), but it didn't get far:
> 
> Sorry, hat to reply to myself, forgot to attach a 'ser pim' output ...
> 
> Note the driver (defxx.c) is quite old, but is reported to
> work on x86 and 2.6 (and ppc on 2.4).

Well, apparently the report that the driver was working on
ppc is not true. The driver is not big-endian safe.

BTW, the HPMC is caused by drivers/net/defxx.c#527,
which is the initialization routine for EISA cards, which
is executed regardless whether there is EISA support
compiled into the kernel or not. The inl() in there causes
the HPMC.

Attached a patch that adresses at least the obvious big-endian
issues and disables the EISA initialization if CONFIG_EISA
is not defined.
With the patch my c3k boots up, detects the card and it
seems to work, but I can't test it properly right now, since
I don't have a second FDDI card here (yet).

Greetings,
   Max

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fddi.patch --]
[-- Type: text/x-patch; name="fddi.patch", Size: 900 bytes --]

--- linux-2.6/drivers/net/defxx.c	2005-04-11 23:17:24.000000000 +0100
+++ defxx.c	2005-04-11 23:34:51.000000000 +0100
@@ -534,7 +534,7 @@
 	}
 	return rc;
 }
-\f
+
 /*
  * ================
  * = dfx_bus_init =
@@ -857,6 +857,7 @@
 		       print_name);
 		return(DFX_K_FAILURE);
 	}
+	data = cpu_to_le32(data);
 	memcpy(&bp->factory_mac_addr[0], &data, sizeof(u32));
 
 	if (dfx_hw_port_ctrl_req(bp, PI_PCTRL_M_MLA, PI_PDATA_A_MLA_K_HI, 0,
@@ -865,6 +866,7 @@
 		       print_name);
 		return(DFX_K_FAILURE);
 	}
+	data = cpu_to_le32(data);
 	memcpy(&bp->factory_mac_addr[4], &data, sizeof(u16));
 
 	/*
@@ -3433,7 +3435,11 @@
 	rc_pci = pci_module_init(&dfx_driver);
 	if (rc_pci >= 0) dfx_have_pci = 1;
 	
+#ifdef CONFIG_EISA
 	rc_eisa = dfx_eisa_init();
+#else
+	rc_eisa = -1;
+#endif
 	if (rc_eisa >= 0) dfx_have_eisa = 1;
 
 	return ((rc_eisa < 0) ? 0 : rc_eisa)  + ((rc_pci < 0) ? 0 : rc_pci); 

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux