From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E97CDCD6E6B for ; Fri, 5 Jun 2026 09:07:39 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1329243.1593442 (Exim 4.92) (envelope-from ) id 1wVQWQ-0005ZX-Vr; Fri, 05 Jun 2026 09:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1329243.1593442; Fri, 05 Jun 2026 09:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wVQWQ-0005ZQ-SU; Fri, 05 Jun 2026 09:07:22 +0000 Received: by outflank-mailman (input) for mailman id 1329243; Fri, 05 Jun 2026 09:07:22 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wVQWP-0005ZK-W9 for xen-devel@lists.xenproject.org; Fri, 05 Jun 2026 09:07:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wVQWP-00ADDE-Cg for xen-devel@lists.xenproject.org; Fri, 05 Jun 2026 11:07:21 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a2291bf-e002-0a2a0a5209dd-0a2a450681c4-34 for ; Fri, 05 Jun 2026 11:07:21 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a2291c8-7371-0a2a45060019-d1558031ad34-3 for ; Fri, 05 Jun 2026 11:07:21 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso13186815e9.1 for ; Fri, 05 Jun 2026 02:07:21 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cbfe4sm139609345e9.7.2026.06.05.02.07.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 02:07:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780650440; x=1781255240; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=MlIKbjTr565sibBp653JfGTAsuJxQFinncMXO3YrjCY=; b=V6tbeqWY3TXDkdYST4wRlUiNV9o205c80Fsx+x03lxSAAOgUOzc7bpE27FZYRycKZ3 A+E27yqodg+XZ9sERyzs44MpKXiKLYG5hOa8DXMSW/1qqbhf/1CM4saQJGC8jSPESe1H ZEwSNyGqINE1oPDlgQrUW5J+NWK13P4yntpWHWJBDSo6fsa9HJtH8aPNG3nypQFLX0Ho Q+k5HgCq0DJYtqv6JI4fJfv/p14sW99EKSfmYUDcd74Oq4NQGDfHdKl8wKnOI0AETqLB GSLnbGSD+IDvM3xYtqnlh/aCQuLq4dDwv2b4k55BPWrFlcljXfccCQfCy0i0JWm7XYFB RoOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780650440; x=1781255240; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MlIKbjTr565sibBp653JfGTAsuJxQFinncMXO3YrjCY=; b=CvpfrIQy1LIRVylhkE4o1pyQ2+hpsh9ohVoss+wTVrkc9akxU1+QrxLQK3iEv+z/u0 jMRPVmxwCd8V5yY9y36KKxORJfz0ZfwS9AM0ToKJd07xhttHw6ZSofPQl4CLyQDpEwxe i+pxxaId1KMxkL9EcsQc2XAn03bZEkll8EKap49DW1UU67O60vOWCKJPzudK9nQEWam4 Rz+UZ2LGNCWIuYoMJ79PT4LKzE5T9x9JDZq6aZqNS2jQtTHUP6NWkUCKfwOQypQgdV3u Z/5EO0ePVkA/Z9GLVka1GKK8pT1QK+kcJDzjjm8ViqYh328VUNbvhW0l7G3wps9mDdsq VUhA== X-Forwarded-Encrypted: i=1; AFNElJ/OoprXcyK/GszjS6yiLSZk1b2ORhZwPFCUdoqx5kP5NOQ5xKJfHOXXD4zUGXf4/iqsYCLDLDvURlE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxAjwLReazJ7cKGpEelMohJPsyNs0OGDzjR/gv70KNoI9bHyRN7 BSWsOd3O75cQtHR8u8rfPlX3nIUEc47SFTZhJf4tBBPlTcTFZHq8Xh/S5JMSZqh47A== X-Gm-Gg: Acq92OGQCzQNSvWA5RF/FuP4suvciEqmxVf94lyvwR+cQ8UpQBLSxBs0QkgmFeOcZzm dggFbk5lTaqXIa/vEhqi7DdJEhNW8KDgkw7+qfVB6btrjEhX2oHB9RIQd4/2+NQ8TUlDmfco+4x IPIg2jI6DsQx4zotAemD5P+VZn/0D9bK254RZRKckYKrQNTSdeplk2zxZGjzaRMr9CdsELpQN5/ 6ooFqT7Oh6MGNiz+K3XVQYgo/44eJbd/74HsyF+n7nA8UURhdx0ODyON/QyZmFbV/hAD21TrOfs NczyAEMdonWBlCproqgMei1mui8ad/gBljvGaqopxs8YbqfOsotdYYAx1nZKhyeMmxsSDkTUhB3 DAzJjMA6/rKRQl2qln803vnBgtxjsaMdUXXw/4Zs2S+aa2Pg0/SdK27EwwraOTysrbvNWBaBgtR vPUUYvO0kA8Xp8Yh34T1tqpQmjWxnaoi42BVgq6+6yW4dcug6ClC82IZf+e4zcR7dE8+ZlNpIHq Hyt/K62Pa67zlJEkbu4/xxTQ7jB1VUGhuJh X-Received: by 2002:a05:600c:4e43:b0:490:b9c3:6c69 with SMTP id 5b1f17b1804b1-490c2622cf7mr38582885e9.30.1780650440431; Fri, 05 Jun 2026 02:07:20 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 11:07:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/26] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h. To: Oleksii Kurochko Cc: Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <736349477470f316da7020c4c1c7e92e37470d31.1778250616.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1780650441-8556ED75-660B15AF/0/0 X-purgate-type: clean X-purgate-size: 2400 On 05.06.2026 10:48, Oleksii Kurochko wrote: > On 6/3/26 5:36 PM, Jan Beulich wrote: >> On 08.05.2026 16:43, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/include/asm/aplic.h >>> +++ b/xen/arch/riscv/include/asm/aplic.h >>> @@ -15,6 +15,11 @@ >>> >>> #include >>> >>> +#define APLIC_REG_OFFSET_MASK 0x3fff >> >> This I can see this as wanting to live separately. Yet ... >> >>> +#define APLIC_TARGET_IPRIO_MASK 0xff > > This could be dropped as I don't use this mask anymore. > >>> +#define APLIC_TARGET_GUEST_IDX_SHIFT 12 >>> +#define APLIC_TARGET_EIID_MASK 0x7ff >> >> ... what (set of) register(s) do these apply to? Perhaps ... >> >>> @@ -26,6 +31,36 @@ >>> #define APLIC_SOURCECFG_SM_LEVEL_HIGH 0x6 >>> #define APLIC_SOURCECFG_SM_LEVEL_LOW 0x7 >>> >>> +#define APLIC_DOMAINCFG 0x0000 >>> +#define APLIC_SOURCECFG_BASE 0x0004 >>> +#define APLIC_SOURCECFG_LAST 0x0ffc >>> + >>> +#define APLIC_SMSICFGADDR 0x1bc8 >>> +#define APLIC_SMSICFGADDRH 0x1bcc >>> + >>> +#define APLIC_SETIP_BASE 0x1c00 >>> +#define APLIC_SETIP_LAST 0x1c7c >>> +#define APLIC_SETIPNUM 0x1cdc >>> + >>> +#define APLIC_CLRIP_BASE 0x1d00 >>> +#define APLIC_CLRIP_LAST 0x1d7c >>> +#define APLIC_CLRIPNUM 0x1ddc >>> + >>> +#define APLIC_SETIE_BASE 0x1e00 >>> +#define APLIC_SETIE_LAST 0x1e7c >>> +#define APLIC_SETIENUM 0x1edc >>> + >>> +#define APLIC_CLRIE_BASE 0x1f00 >>> +#define APLIC_CLRIE_LAST 0x1f7c >>> +#define APLIC_CLRIENUM 0x1fdc >>> + >>> +#define APLIC_SETIPNUM_LE 0x2000 >>> + >>> +#define APLIC_GENMSI 0x3000 >>> + >>> +#define APLIC_TARGET_BASE 0x3004 >>> +#define APLIC_TARGET_LAST 0x3ffc >> >> ... these? And then is ... > > Yes, it is applied to target register. > >> >>> #define APLIC_TARGET_HART_IDX_SHIFT 18 >> >> ... this also covering some part of them? Can't they (a) live together and (b) >> have some kind of connection to what they apply to? > > Agreed, they could live together. The intent was simply to keep all MMIO > definitions in sequence, That would also be fine, but then please add a comment to the register field definition groups. Jan > but I'm okay with grouping macros related to a > specific register together.