From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 21/38] drm/i915: Fix I915_EXEC_RING_MASK Date: Fri, 1 Mar 2019 15:29:34 +0000 Message-ID: References: <20190301140404.26690-1-chris@chris-wilson.co.uk> <20190301140404.26690-21-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190301140404.26690-21-chris@chris-wilson.co.uk> Content-Language: en-US Sender: stable-owner@vger.kernel.org To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Tvrtko Ursulin , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On 01/03/2019 14:03, Chris Wilson wrote: > This was supposed to be a mask of all known rings, but it is being used > by execbuffer to filter out invalid rings, and so is instead mapping high > unused values onto valid rings. Instead of a mask of all known rings, > we need it to be the mask of all possible rings. > > Fixes: 549f7365820a ("drm/i915: Enable SandyBridge blitter ring") > Fixes: de1add360522 ("drm/i915: Decouple execbuf uAPI from internal implementation") > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: # v4.6+ > --- > include/uapi/drm/i915_drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index 60cbb2e4f140..4e59cc87527b 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -1004,7 +1004,7 @@ struct drm_i915_gem_execbuffer2 { > * struct drm_i915_gem_exec_fence *fences. > */ > __u64 cliprects_ptr; > -#define I915_EXEC_RING_MASK (7<<0) > +#define I915_EXEC_RING_MASK (0x3f) > #define I915_EXEC_DEFAULT (0<<0) > #define I915_EXEC_RENDER (1<<0) > #define I915_EXEC_BSD (2<<0) > Easy pickings first. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko