From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5457F3D971 for ; Thu, 12 Oct 2023 20:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T/IGlDQL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7E70C433C7; Thu, 12 Oct 2023 20:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697142996; bh=qfX1SodUJMazOEDs5JlmUHg0AtVW+L6/EyjHuDRfotg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T/IGlDQLSLZXodptqjPsCe0oLd2w5yn2DZDLWytelFLxee011GUtQir3kcxKUaCJt QDUCbnHpHixhfPdP82/TmVJdQ8xrjgDlJFM7vjfqvLl/3P7fLO4O4KrCwVTMBjS2Rm zAPfOcgM2km+8dzmSJaeD5SOmeJyNh/2SnkbnO3di5ESRFN++0WNbmT/9fsQvPuLY4 oT3PQ3dVuYA4aPCq2nN/tdbVe+/4WllbwBoTncgi8bwSjq95gWlLKoF9k9q5BZNZlk QFraeoe2QTtRDPVPCYTRtmhKwu2jgHzCNTVOVuwNmjgAcp3WqLqmY/i5Gpz4zIns97 Kb1ngR6GQ0XMA== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qr2Q6-003eHp-47; Thu, 12 Oct 2023 21:36:34 +0100 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 12 Oct 2023 21:36:33 +0100 From: Marc Zyngier To: eric.auger@redhat.com Cc: Miguel Luis , Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v3 3/3] arm64/kvm: Fine grain _EL2 system registers list that affect nested virtualization In-Reply-To: <7df53e6b-9141-de85-b7a3-b9eb092ef7b4@redhat.com> References: <20231011180103.91774-1-miguel.luis@oracle.com> <20231011180103.91774-4-miguel.luis@oracle.com> <7df53e6b-9141-de85-b7a3-b9eb092ef7b4@redhat.com> User-Agent: Roundcube Webmail/1.4.14 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, miguel.luis@oracle.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On 2023-10-12 16:22, Eric Auger wrote: > Hi Miguel, > > On 10/11/23 20:01, Miguel Luis wrote: >> Implement a fine grained approach in the _EL2 sysreg ranges. >> >> Fixes: d0fc0a2519a6 ("KVM: arm64: nv: Add trap forwarding for >> HCR_EL2") >> Signed-off-by: Miguel Luis >> --- >> arch/arm64/kvm/emulate-nested.c | 88 >> ++++++++++++++++++++++++++++++--- >> 1 file changed, 82 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm64/kvm/emulate-nested.c >> b/arch/arm64/kvm/emulate-nested.c >> index 9ced1bf0c2b7..3af49e130ee6 100644 >> --- a/arch/arm64/kvm/emulate-nested.c >> +++ b/arch/arm64/kvm/emulate-nested.c >> @@ -648,15 +648,91 @@ static const struct encoding_to_trap_config >> encoding_to_cgt[] __initconst = { >> SR_TRAP(SYS_APGAKEYLO_EL1, CGT_HCR_APK), >> SR_TRAP(SYS_APGAKEYHI_EL1, CGT_HCR_APK), >> /* All _EL2 registers */ >> - SR_RANGE_TRAP(sys_reg(3, 4, 0, 0, 0), >> - sys_reg(3, 4, 3, 15, 7), CGT_HCR_NV), >> + SR_TRAP(SYS_VPIDR_EL2, CGT_HCR_NV), > I think you miss DBGVCR32_EL2 I don't think this register should be part of this list. We don't support AArch32 with NV, and the spec says that DBGVCR32_EL2 UNDEFs when EL1 doesn't support AArch32. So the change that needs to happen is to inject an UNDEF when trapping a DBGVCR32_EL2and not forward the trap to the guest. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C85BBCDB46E for ; Thu, 12 Oct 2023 20:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DIKgsCGEax0DeScoLdl1Rei5b5Wwk4wJoewE8bAqV7s=; b=CYE+g37+gG0/AmUx7ZwfloWjrX V5gX/P02CwZLEzo7SIrst3BP/NQIOscY1j5OrNLI4EtydxXq8zUhRSHNt0TelaSiVQUCLzKrYhs54 bbjFdsjSk6mEaoyN4/G5/ySJXKwt38keSkJcQZoH6qsvjKjU2yqVghRi9rmreUpPxjJsJctSZ4Vv0 3C8uMv8w/+XogBatB54qNG8hnTovnOakbiGBhwerguxo8K/hnSFgXRwVK81HzT1VsjU1TG7belzVV XsLkiJ7SOVEINaqhCQ6dQ1JvfYxAvQ3VggSlGZoPZGOpjA4sn2YY7x3XO1NOMSOSWHhpVgoBC9fEQ Jz9KSgwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qr2QH-001nwv-1W; Thu, 12 Oct 2023 20:36:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qr2QD-001nvN-1P for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 20:36:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 392F061F6C; Thu, 12 Oct 2023 20:36:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7E70C433C7; Thu, 12 Oct 2023 20:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697142996; bh=qfX1SodUJMazOEDs5JlmUHg0AtVW+L6/EyjHuDRfotg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T/IGlDQLSLZXodptqjPsCe0oLd2w5yn2DZDLWytelFLxee011GUtQir3kcxKUaCJt QDUCbnHpHixhfPdP82/TmVJdQ8xrjgDlJFM7vjfqvLl/3P7fLO4O4KrCwVTMBjS2Rm zAPfOcgM2km+8dzmSJaeD5SOmeJyNh/2SnkbnO3di5ESRFN++0WNbmT/9fsQvPuLY4 oT3PQ3dVuYA4aPCq2nN/tdbVe+/4WllbwBoTncgi8bwSjq95gWlLKoF9k9q5BZNZlk QFraeoe2QTtRDPVPCYTRtmhKwu2jgHzCNTVOVuwNmjgAcp3WqLqmY/i5Gpz4zIns97 Kb1ngR6GQ0XMA== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qr2Q6-003eHp-47; Thu, 12 Oct 2023 21:36:34 +0100 MIME-Version: 1.0 Date: Thu, 12 Oct 2023 21:36:33 +0100 From: Marc Zyngier To: eric.auger@redhat.com Cc: Miguel Luis , Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v3 3/3] arm64/kvm: Fine grain _EL2 system registers list that affect nested virtualization In-Reply-To: <7df53e6b-9141-de85-b7a3-b9eb092ef7b4@redhat.com> References: <20231011180103.91774-1-miguel.luis@oracle.com> <20231011180103.91774-4-miguel.luis@oracle.com> <7df53e6b-9141-de85-b7a3-b9eb092ef7b4@redhat.com> User-Agent: Roundcube Webmail/1.4.14 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, miguel.luis@oracle.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_133641_580470_1306128D X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-10-12 16:22, Eric Auger wrote: > Hi Miguel, > > On 10/11/23 20:01, Miguel Luis wrote: >> Implement a fine grained approach in the _EL2 sysreg ranges. >> >> Fixes: d0fc0a2519a6 ("KVM: arm64: nv: Add trap forwarding for >> HCR_EL2") >> Signed-off-by: Miguel Luis >> --- >> arch/arm64/kvm/emulate-nested.c | 88 >> ++++++++++++++++++++++++++++++--- >> 1 file changed, 82 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm64/kvm/emulate-nested.c >> b/arch/arm64/kvm/emulate-nested.c >> index 9ced1bf0c2b7..3af49e130ee6 100644 >> --- a/arch/arm64/kvm/emulate-nested.c >> +++ b/arch/arm64/kvm/emulate-nested.c >> @@ -648,15 +648,91 @@ static const struct encoding_to_trap_config >> encoding_to_cgt[] __initconst = { >> SR_TRAP(SYS_APGAKEYLO_EL1, CGT_HCR_APK), >> SR_TRAP(SYS_APGAKEYHI_EL1, CGT_HCR_APK), >> /* All _EL2 registers */ >> - SR_RANGE_TRAP(sys_reg(3, 4, 0, 0, 0), >> - sys_reg(3, 4, 3, 15, 7), CGT_HCR_NV), >> + SR_TRAP(SYS_VPIDR_EL2, CGT_HCR_NV), > I think you miss DBGVCR32_EL2 I don't think this register should be part of this list. We don't support AArch32 with NV, and the spec says that DBGVCR32_EL2 UNDEFs when EL1 doesn't support AArch32. So the change that needs to happen is to inject an UNDEF when trapping a DBGVCR32_EL2and not forward the trap to the guest. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel