All of lore.kernel.org
 help / color / mirror / Atom feed
From: "cron2 (Code Review)" <gerrit@...515...>
To: plaisthos <arne-openvpn@...1227...>
Cc: flichtenheld <frank@...2641...>,
	openvpn-devel <openvpn-devel@lists.sourceforge.net>
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature
Date: Sat, 13 Jan 2024 12:11:20 +0000	[thread overview]
Message-ID: <e6f966322b0b44e63ff298652c367840ef9237fc-EmailReviewComments-HTML@...2715...> (raw)
In-Reply-To: <gerrit.1701865618000.Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2@...2715...>

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: Implement the --tls-export-cert feature
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

Patchset:

PS11:
As much as it pains me, this needs to do another round - it now calls "unlink(NULL)" if the feature is not active.  GHA/ASAN on ubuntu 20 found this.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 11
Gerrit-Owner: plaisthos <arne-openvpn@...1227...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2641...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>
Gerrit-Attention: flichtenheld <frank@...2641...>
Gerrit-Comment-Date: Sat, 13 Jan 2024 12:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[-- Attachment #2: Type: text/html, Size: 2605 bytes --]

  parent reply	other threads:[~2024-01-13 12:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gerrit.1701865618000.Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2@...2715...>
2023-12-06 12:27 ` [Openvpn-devel] [M] Change in openvpn[master]: Implement the --export-peer-cert feature plaisthos (Code Review)
2023-12-06 12:57 ` cron2 (Code Review)
2023-12-06 14:04 ` [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature plaisthos (Code Review)
2023-12-06 14:04 ` plaisthos (Code Review)
2023-12-06 17:30 ` flichtenheld (Code Review)
2023-12-07 11:27 ` plaisthos (Code Review)
2023-12-07 17:49 ` plaisthos (Code Review)
2023-12-12 14:39 ` flichtenheld (Code Review)
2023-12-12 18:24 ` plaisthos (Code Review)
2023-12-12 18:24 ` plaisthos (Code Review)
2023-12-13 14:29 ` flichtenheld (Code Review)
2023-12-14 11:17 ` [Openvpn-devel] [PATCH v6] " Frank Lichtenheld
2023-12-18 17:42 ` [Openvpn-devel] [M] Change in openvpn[master]: " cron2 (Code Review)
2023-12-20 11:57 ` flichtenheld (Code Review)
2024-01-02 13:46 ` plaisthos (Code Review)
2024-01-02 16:44 ` plaisthos (Code Review)
2024-01-02 16:45 ` plaisthos (Code Review)
2024-01-02 16:52 ` plaisthos (Code Review)
2024-01-02 17:16 ` plaisthos (Code Review)
2024-01-06 15:31 ` cron2 (Code Review)
2024-01-12 16:56 ` plaisthos (Code Review)
2024-01-12 18:19 ` cron2 (Code Review)
2024-01-12 18:19 ` [Openvpn-devel] [PATCH v11] " Gert Doering
2024-01-13 12:11 ` cron2 (Code Review) [this message]
2024-01-15 12:46 ` [Openvpn-devel] [M] Change in openvpn[master]: " plaisthos (Code Review)
2024-01-16 10:15 ` cron2 (Code Review)
2024-01-16 10:15 ` [Openvpn-devel] [PATCH v12] " Gert Doering
2024-01-16 11:12   ` [Openvpn-devel] [PATCH applied] " Gert Doering
2024-01-16 11:13 ` [Openvpn-devel] [M] Change in openvpn[master]: " cron2 (Code Review)
2024-01-16 11:13 ` cron2 (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6f966322b0b44e63ff298652c367840ef9237fc-EmailReviewComments-HTML@...2715... \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.