From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF9CC433EF for ; Mon, 23 May 2022 12:36:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235515AbiEWMgc (ORCPT ); Mon, 23 May 2022 08:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235642AbiEWMeL (ORCPT ); Mon, 23 May 2022 08:34:11 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45CD42A39 for ; Mon, 23 May 2022 05:34:10 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id nr2-20020a17090b240200b001df2b1bfc40so17379014pjb.5 for ; Mon, 23 May 2022 05:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GCE2nGwlSzDm4FRAKR9XWUKV2cYGLHBtnDJjqTUCz3g=; b=AUD1k/5Il6KA9nnZTRKy51zxMg8hpIWppmF4I8Uq7kwfO4N0BNxkUkR8vSrWNW+0QT JDNSeq3l/+4fQqS/qGn9CwHw7c1mcAx1l5O+MQeH0utxCCJVT6snY8oB2qwhwHTfDW3i V1okNcXPCrDilUi5gWzX1lfwwy6xvmR9hKNw0aB66aPg+DCrTEAA1O0X2xPK4uVxXoUZ pBEHpZbcgUavV5sNyrmE1478ivZoCgLLT+h7+1EmIi2HSH9VbyeSuM1IrWjnFM8BL9z3 isx02vSybd+XlNVJp4Nt3WtRmkh7FXPA8V+he7D6O2lbNQV/uEyl3H+WNFZbbRBwxRHU Z3gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GCE2nGwlSzDm4FRAKR9XWUKV2cYGLHBtnDJjqTUCz3g=; b=bdozY5DcF1q4lW7yQm2Nfcz+FSzvIFP/HmjmqiTB+JxXz3WYK3Av97CrNBmhH0vCIp yRBcOde09HBu5BszX/R+ZK/rXxE7T0DG0bM1ZxyrwO99+89lbk3xqljRBxOyEz4SY+7p qtTx4uE049DbA2BIqRFMboELbaMHxBzwgGGUEldJ0OBSvl2gHTr73pVoRZ8JFMWlq41e EvVJogOFOBRP+sHKLIXZwQk8y2cnH0JRek4Mzoy8/bdJ/PuTZltujF1/7/KdKovVVHTu mfRLuysnHjWxAe18Kq51rMopVz/DMCOI9Qu+kT9AVz+CGz0lvOpB4CS9vE5EapQ3RcyQ j1WA== X-Gm-Message-State: AOAM532U3gTdAcWmx2XdOrQpTihN+s6vk6mU0rCJ7uRVISFUsoMwaiA1 SaSOMH2M2aPDupgVhc8UfZIfLj/mVAMUmg== X-Google-Smtp-Source: ABdhPJzgoOyGNawu3EG5PhFUkCLxs26tbNXp/x3LWQH9HJyu0iQ7D/qLRRHPfLvKpd0iKudcqH3otw== X-Received: by 2002:a17:90b:3b81:b0:1e0:3ebf:c6ae with SMTP id pc1-20020a17090b3b8100b001e03ebfc6aemr7486040pjb.186.1653309250207; Mon, 23 May 2022 05:34:10 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ms16-20020a17090b235000b001d5943e826asm7336604pjb.20.2022.05.23.05.34.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 05:34:09 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 06:34:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/4] bcache patches for Linux v5.19 (1st wave) Content-Language: en-US To: Coly Li Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org References: <20220522170736.6582-1-colyli@suse.de> <9c3fddec-1741-872f-1cdb-b44316e2ff64@suse.de> From: Jens Axboe In-Reply-To: <9c3fddec-1741-872f-1cdb-b44316e2ff64@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 5/23/22 12:26 AM, Coly Li wrote: > On 5/23/22 1:43 AM, Jens Axboe wrote: >> On 5/22/22 11:07 AM, Coly Li wrote: >>> Hi Jens, >>> >>> The bcache has 4 patches for Linux v5.19 merge window, all from me. >>> - The first 2 patches are code clean up and potential bug fixes for >>> multi- threaded btree nodes check (for cache device) and dirty sectors >>> counting (for backing device), although no report from mailing list for >>> them, it is good to have the fixes. >>> - The 3rd patch removes incremental dirty sectors counting because it >>> is conflicted with multithreaded dirty sectors counting and the latter >>> one is 10x times faster. >>> - The last patch fixes a journal no-space deadlock during cache device >>> registration, it always reserves one journal bucket and only uses it >>> in registration time, so the no-spance condition won't happen anymore. >>> >>> There are still 2 fixes are still under the long time I/O pressure >>> testing, once they are accomplished, I will submit to you in later >>> RC cycles. >>> >>> Please take them, and thanks in advance. >> It's late for sending in that stuff, now I have to do a round 2 or >> your patches would get zero time in linux-next. Please send patches >> a week in advance at least, not on the day of release... >> > Hi Jens, > > This time the situation was awkward, indeed I didn't expect I can > submit the fix in this merge window, but just around 1 week before I > found the difficult was from influence by other depending issues. > After fixed all of them and do I/O pressure testing for 24x2 hours, it > comes to such close day to the merge window. > > My confusion was, it was very close to the merge window so maybe I > should submit them in next merge window (5.20), but this series were > bug fixes which should go into mainline earlier. It seems neither > option was proper, so I chose the first one... > > Could you give me a hint, what is the proper way that I should do for > such situation? Then I will try to follow that and avoid adding more > workload to you. It would help if the submission came with an explanation of why they are being submitted so late, as I really do expect it to happen around -rc7 time. Sometimes it's just because people are a bit lazy getting changes submitted, and then do it at that last minute. That makes me a bit annoyed. And other times there are totally legitimate reasons for why they are being submitted late, like your explanation above. It really depends on the scope of the changes, too. Simple fixes are obviously fair game at any time. -- Jens Axboe