From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2262C636F9 for ; Tue, 6 Dec 2022 08:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234229AbiLFIgC (ORCPT ); Tue, 6 Dec 2022 03:36:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234299AbiLFIfe (ORCPT ); Tue, 6 Dec 2022 03:35:34 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A757A17A84; Tue, 6 Dec 2022 00:35:11 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1B97B24E277; Tue, 6 Dec 2022 16:35:09 +0800 (CST) Received: from EXMBX067.cuchost.com (172.16.6.67) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Dec 2022 16:35:09 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX067.cuchost.com (172.16.6.67) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Dec 2022 16:35:09 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Tue, 6 Dec 2022 16:35:09 +0800 From: JiaJie Ho To: Krzysztof Kozlowski , Herbert Xu , "David S . Miller" , "Rob Herring" , Krzysztof Kozlowski CC: "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Topic: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Index: AQHZBH/2P5dLP9b8iUC7OZp9LCFzsa5W7gcAgAHFddD//4unAIAIUqbQ Date: Tue, 6 Dec 2022 08:35:09 +0000 Message-ID: References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org> In-Reply-To: <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS3J6eXN6dG9mIEtvemxv d3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPg0KPiBTZW50OiBUaHVyc2RheSwg RGVjZW1iZXIgMSwgMjAyMiA1OjI3IFBNDQo+IFRvOiBKaWFKaWUgSG8gPGppYWppZS5ob0BzdGFy Zml2ZXRlY2guY29tPjsgSGVyYmVydCBYdQ0KPiA8aGVyYmVydEBnb25kb3IuYXBhbmEub3JnLmF1 PjsgRGF2aWQgUyAuIE1pbGxlciA8ZGF2ZW1AZGF2ZW1sb2Z0Lm5ldD47DQo+IFJvYiBIZXJyaW5n IDxyb2JoK2R0QGtlcm5lbC5vcmc+OyBLcnp5c3p0b2YgS296bG93c2tpDQo+IDxrcnp5c3p0b2Yu a296bG93c2tpK2R0QGxpbmFyby5vcmc+DQo+IENjOiBsaW51eC1jcnlwdG9Admdlci5rZXJuZWwu b3JnOyBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXgtDQo+IGtlcm5lbEB2Z2VyLmtl cm5lbC5vcmc7IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU3ViamVjdDogUmU6 IFtQQVRDSCA1LzZdIGR0LWJpbmRpbmdzOiBjcnlwdG86IEFkZCBiaW5kaW5ncyBmb3IgU3RhcmZp dmUgY3J5cHRvDQo+IGRyaXZlcg0KPiANCj4gT24gMDEvMTIvMjAyMiAxMDowMSwgSmlhSmllIEhv IHdyb3RlOg0KPiANCj4gPj4+ICsNCj4gPj4+ICsgIGVuYWJsZS1zaWRlLWNoYW5uZWwtbWl0aWdh dGlvbjoNCj4gPj4+ICsgICAgZGVzY3JpcHRpb246IEVuYWJsZSBzaWRlLWNoYW5uZWwtbWl0aWdh dGlvbiBmZWF0dXJlIGZvciBBRVMgbW9kdWxlLg0KPiA+Pj4gKyAgICAgICAgRW5hYmxpbmcgdGhp cyBmZWF0dXJlIHdpbGwgYWZmZWN0IHRoZSBzcGVlZCBwZXJmb3JtYW5jZSBvZg0KPiA+Pj4gKyAg ICAgICAgY3J5cHRvIGVuZ2luZS4NCj4gPj4+ICsgICAgdHlwZTogYm9vbGVhbg0KPiA+Pg0KPiA+ PiBXaHkgZXhhY3RseSB0aGlzIGlzIGEgaGFyZHdhcmUgKERUKSBwcm9wZXJ0eSwgbm90IHJ1bnRp bWU/DQo+ID4+DQo+ID4NCj4gPiBUaGlzIGlzIGEgaGFyZHdhcmUgc2V0dGluZyBwcm92aWRlZCBp biBTdGFyRml2ZSBjcnlwdG8gZW5naW5lIG9ubHkuDQo+ID4gVGhlIGNyeXB0byBBUEkgZG9lc24n dCBjb250cm9sIHRoaXMgc2V0dGluZyBkdXJpbmcgcnVudGltZSBhbmQgbGVhdmluZyB0aGlzDQo+ IGFsd2F5cyBvbiB3aWxsIGltcGFjdCBzcGVlZCBwZXJmb3JtYW5jZS4NCj4gPiBTbywgSSBhZGRl ZCB0aGlzIHByb3BlcnR5IHRvIGFsbG93IHVzZXIgdG8gY29udHJvbCB0aGlzIGluIGR0Yi4NCj4g DQo+IERldmljZXRyZWUgc2hvdWxkIG5vdCBkZXNjcmliZSBwb2xpY2llcywgc28gd2l0aG91dCBq dXN0aWZpY2F0aW9uIGl0IGRvZXMgbm90DQo+IGxvb2sgbGlrZSBoYXJkd2FyZSBwcm9wZXJ0eS4g RHJvcC4NCj4gDQpJJ2xsIHJlbW92ZSB0aGlzIGluIHYyIGFuZCBzZXQgdGhlIHZhbHVlIHVzaW5n IG1vZHVsZSBwYXJhbSBpbnN0ZWFkLg0KVGhhbmtzLg0KDQpCZXN0IHJlZ2FyZHMsDQpKaWEgSmll DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A7F4C3A5A7 for ; Tue, 6 Dec 2022 08:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rmIhTkgQ2jXTrAoHW52HISpWsCTYZOyozT08k9BSAro=; b=FVt2XJTwi0D2tJ NQjZGt8D8w6hXzx4tGbrB09ZK3Cx4oj/SM8lzJaWLfkFKKOfj0mIvWnO9tcoBe2nlUtRce+DsyzOh 7w8dUkm2Z7N4q/PVxihZQxZ36ok53EZYpe/hJEzGMPyr9ptqsbBDEHmMrCXrFn5n0jDbN5oyYijUv 7XsKSOQS1rZIdH1qQDP9cGBnSAQEd/D/i8egUklVcUwZmdcjedLOyFA3WTVcdyQfkXTszLjADzxcj SYYiSweQ821v6q6IPjALc/tNq/c5sXOc8Q2qrYYwvY2Yj/02cNHiNPk35fzxwsK9rqYQ3T9O7kT4C qBpmVRjA4wb/xJdml2jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2TQr-004wrL-Ut; Tue, 06 Dec 2022 08:36:05 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2TQA-004wAp-FJ for linux-riscv@lists.infradead.org; Tue, 06 Dec 2022 08:35:24 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1B97B24E277; Tue, 6 Dec 2022 16:35:09 +0800 (CST) Received: from EXMBX067.cuchost.com (172.16.6.67) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Dec 2022 16:35:09 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX067.cuchost.com (172.16.6.67) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Dec 2022 16:35:09 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Tue, 6 Dec 2022 16:35:09 +0800 From: JiaJie Ho To: Krzysztof Kozlowski , Herbert Xu , "David S . Miller" , "Rob Herring" , Krzysztof Kozlowski CC: "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Topic: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Index: AQHZBH/2P5dLP9b8iUC7OZp9LCFzsa5W7gcAgAHFddD//4unAIAIUqbQ Date: Tue, 6 Dec 2022 08:35:09 +0000 Message-ID: References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org> In-Reply-To: <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_003522_803062_0A7AB13E X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Thursday, December 1, 2022 5:27 PM > To: JiaJie Ho ; Herbert Xu > ; David S . Miller ; > Rob Herring ; Krzysztof Kozlowski > > Cc: linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-riscv@lists.infradead.org > Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto > driver > > On 01/12/2022 10:01, JiaJie Ho wrote: > > >>> + > >>> + enable-side-channel-mitigation: > >>> + description: Enable side-channel-mitigation feature for AES module. > >>> + Enabling this feature will affect the speed performance of > >>> + crypto engine. > >>> + type: boolean > >> > >> Why exactly this is a hardware (DT) property, not runtime? > >> > > > > This is a hardware setting provided in StarFive crypto engine only. > > The crypto API doesn't control this setting during runtime and leaving this > always on will impact speed performance. > > So, I added this property to allow user to control this in dtb. > > Devicetree should not describe policies, so without justification it does not > look like hardware property. Drop. > I'll remove this in v2 and set the value using module param instead. Thanks. Best regards, Jia Jie _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv