From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 0/6 v4] adv7511 EDID probing improvements Date: Thu, 19 Jan 2017 10:52:41 +0530 Message-ID: References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> <3859476.cEhDXg5Hko@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2EFC6E957 for ; Thu, 19 Jan 2017 05:22:48 +0000 (UTC) In-Reply-To: <3859476.cEhDXg5Hko@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , John Stultz Cc: Wolfram Sang , lkml , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAwMS8xOS8yMDE3IDA0OjM0IEFNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+IEhpIEpv aG4sCj4KPiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaGVzLgo+Cj4gT24gTW9uZGF5IDE2IEphbiAy MDE3IDE2OjUyOjQ2IEpvaG4gU3R1bHR6IHdyb3RlOgo+PiBXYW50ZWQgdG8gcmUtc2VuZCBvdXQg djQgIG9mIHRoaXMgcGF0Y2ggc2V0LCBpbnRlZ3JhdGluZyBzb21lCj4+IGNoYW5nZXMgc3VnZ2Vz dGVkIGJ5IExhdXJlbnQsIGZvciBjb25zaWRlcmF0aW9uIGZvciBtZXJnaW5nIGZvcgo+PiB2NC4x MQo+Pgo+PiBUaGUgZmlyc3QgdGhyZWUgcGF0Y2hlcyBhcmUgZml4dXBzIHRoYXQgYXJlIGhvcGVm dWxseSBzdHJhaWdodAo+PiBmb3J3YXJkLCBpbnRlZ3JhdGluZyBmZWVkYmFjayBJIGdvdCBmcm9t IExhdXJhbnQsIHdpdGggbWluaW1hbAo+PiBjaGFuZ2UgZnJvbSB0aGUgcHJldmlvdXMgdmVyc2lv bnMuCj4+Cj4+IFRoZSBsYXN0IHRocmVlIHBhdGNoZXMgdHJ5IHRvIGNsZWFuIHVwIGFuZCByZXdv cmsgdGhlIEVESUQKPj4gcHJvYmluZyBjb2RlLCB0byBhdm9pZCBpc3N1ZXMgc2VlbiBvbiBIaUtl eS4gSSd2ZSByZXdvcmtlZCB0aGVzZQo+PiBtb3JlIHNpZ25pZmljYW50bHkgc2luY2UgdjMgdG8g YWRkcmVzcyBmZWVkYmFjayBmcm9tIExhdXJlbnQuCj4+Cj4+IFRob3VnaHRzIGFuZCBmZWVkYmFj ayB3b3VsZCBiZSBhcHByZWNpYXRlZCEKPgo+IEZvciB0aGUgd2hvbGUgc2VyaWVzLAo+Cj4gVGVz dGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5j b20+CgpRdWV1ZWQgdG8gZHJtLW1pc2MtbmV4dC4gVXBkYXRlZCB0aGUgY29tbWl0IG1lc3NhZ2Vz IGZvciBwYXRjaGVzIDUKYW5kIDYgYXMgc3VnZ2VzdGVkIGJ5IExhdXJlbnQuCgpUaGFua3MsCkFy Y2hpdAoKPgo+PiBOZXcgaW4gdjQ6Cj4+ICogVHdlYWtlZCBjb25uZWN0b3Iuc3RhdHVzIGFzc2ln bm1lbnQgdG8gYXZvaWQgcmFjZSwgYXMKPj4gICBzdWdnZXN0ZWQgYnkgTGF1cmVudAo+PiAqIFJl d29ya2VkIHRoZSBfX2Fkdjc1MTFfcG93ZXJfb24gaGVscGVycyB0byBhdm9pZCBjYWxsaW5nCj4+ ICAgcmVnY2FjaGVfc3luYyBpbiB0aGUgRURJRCBwcm9iZSBwYXRoCj4+ICogQWRkZWQgbmV3IHBh dGNoIHRvIHNldCBFRElEX0kyQ19BRERSIHJlZ2lzdGVyIGJlZm9yZSBkb2luZwo+PiAgIEVESUQg cmVhZC4KPj4KPj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPj4gQ2M6IEFy Y2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4+IENjOiBXb2xmcmFtIFNhbmcg PHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJpbmcuY29tPgo+PiBDYzogTGFycy1QZXRlciBDbGF1 c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBp bmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4+Cj4+IEFyY2hpdCBUYW5lamEgKDEpOgo+PiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6 IEVuYWJsZSBIUEQgaW50ZXJydXB0cyB0byBzdXBwb3J0IGhvdHBsdWcgYW5kCj4+ICAgICBpbXBy b3ZlIG1vbml0b3IgZGV0ZWN0aW9uCj4+Cj4+IEpvaG4gU3R1bHR6ICg1KToKPj4gICBkcm0vYnJp ZGdlOiBhZHY3NTExOiBVc2Ugd29ya19zdHJ1Y3QgdG8gZGVmZXIgaG90cGx1ZyBoYW5kaW5nIHRv IG91dAo+PiAgICAgb2YgaXJxIGNvbnRleHQKPj4gICBkcm0vYnJpZGdlOiBhZHY3NTExOiBTd2l0 Y2ggdG8gdXNpbmcgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudCgpCj4+ICAgZHJtL2JyaWRn ZTogYWR2NzUxMTogUmV3b3JrIGFkdjc1MTFfcG93ZXJfb24vb2ZmKCkgc28gdGhleSBjYW4gYmUK Pj4gICAgIHJldXNlZCBpbnRlcm5hbGx5Cj4+ICAgZHJtL2JyaWRnZTogYWR2NzUxMTogUmV1c2Ug X19hZHY3NTExX3Bvd2VyX29uL29mZigpIHdoZW4gcHJvYmluZyBFRElECj4+ICAgZHJtL2JyaWRn ZTogYWR2NzUxMTogUmUtd3JpdGUgdGhlIGkyYyBhZGRyZXNzIGJlZm9yZSBFRElEIHByb2JpbmcK Pj4KPj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmggICAgIHwgIDIg Kwo+PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMgfCA2Nwo+ PiArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0 aW9ucygrKSwgMTgKPj4gZGVsZXRpb25zKC0pCj4KCi0tIApRdWFsY29tbSBJbm5vdmF0aW9uIENl bnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3Vu ZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbdASFYC (ORCPT ); Thu, 19 Jan 2017 00:24:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57162 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdASFYA (ORCPT ); Thu, 19 Jan 2017 00:24:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4DBA960819 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH 0/6 v4] adv7511 EDID probing improvements To: Laurent Pinchart , John Stultz References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> <3859476.cEhDXg5Hko@avalon> Cc: lkml , David Airlie , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: Date: Thu, 19 Jan 2017 10:52:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <3859476.cEhDXg5Hko@avalon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2017 04:34 AM, Laurent Pinchart wrote: > Hi John, > > Thank you for the patches. > > On Monday 16 Jan 2017 16:52:46 John Stultz wrote: >> Wanted to re-send out v4 of this patch set, integrating some >> changes suggested by Laurent, for consideration for merging for >> v4.11 >> >> The first three patches are fixups that are hopefully straight >> forward, integrating feedback I got from Laurant, with minimal >> change from the previous versions. >> >> The last three patches try to clean up and rework the EDID >> probing code, to avoid issues seen on HiKey. I've reworked these >> more significantly since v3 to address feedback from Laurent. >> >> Thoughts and feedback would be appreciated! > > For the whole series, > > Tested-by: Laurent Pinchart Queued to drm-misc-next. Updated the commit messages for patches 5 and 6 as suggested by Laurent. Thanks, Archit > >> New in v4: >> * Tweaked connector.status assignment to avoid race, as >> suggested by Laurent >> * Reworked the __adv7511_power_on helpers to avoid calling >> regcache_sync in the EDID probe path >> * Added new patch to set EDID_I2C_ADDR register before doing >> EDID read. >> >> Cc: David Airlie >> Cc: Archit Taneja >> Cc: Wolfram Sang >> Cc: Lars-Peter Clausen >> Cc: Laurent Pinchart >> Cc: dri-devel@lists.freedesktop.org >> >> Archit Taneja (1): >> drm/bridge: adv7511: Enable HPD interrupts to support hotplug and >> improve monitor detection >> >> John Stultz (5): >> drm/bridge: adv7511: Use work_struct to defer hotplug handing to out >> of irq context >> drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() >> drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be >> reused internally >> drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID >> drm/bridge: adv7511: Re-write the i2c address before EDID probing >> >> drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 + >> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67 >> ++++++++++++++++++++-------- 2 files changed, 51 insertions(+), 18 >> deletions(-) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project