From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FCE1C46467 for ; Thu, 19 Jan 2023 22:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Subject:References:Cc:To: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eIoYnoz9KJNYaMfzpr2H6Uh+Y1c7x5eLzUyiawN1wUU=; b=san4cF19USc9Ul gPeYzcFw8WU5pKKahtM96AfO5w+7fZcXL37/gB79ruUQh8lY7WCNpx3MyGL55HmlhKrAZ3kl9KYyM 4GtC7F7Pku8FYNx2bgugzdiVtGBBQ7dGzsF79BWFNlfMsIKmx3RyZolq66EU14J80Ps4xG/1AKldO Unw9gS15/hhOiXWXEyU1yaB2hrqDqapv1kWuX5oZCjdfWIpIh+jMNCFrge+QkEmm1da9j+Fih3M33 Kp585AmVRBTRPG6dWet/u8F5LzHJ802klwhPz29ZRXg5lHRRVXcv3+D9WUVTW4XsxrWNdbyiBBAI2 uOSL4dExuuN+aJKxMW7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIdcn-007V2P-5i; Thu, 19 Jan 2023 22:43:13 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIdca-007Uyl-QB; Thu, 19 Jan 2023 22:43:02 +0000 Received: by mail-ej1-x630.google.com with SMTP id ud5so9641650ejc.4; Thu, 19 Jan 2023 14:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=fgBrJZbIA/l4ZBuwloIrwqfNZDxDJ6pT5E0y/03G4LSnHeQyhmYY2Dn31ZQSuZNq7c 5xAbt6XeL21Tyxdia6IsElgzdkWGVu+OW3/TEgB3++PMxS95NMje7CDNJoMMeQ9sCBJN RbFu55SK7eGr8ldGitcj7LULi9nN6Yn5+uT3q0utpjcCT3+6eDtZn6D1u2KCukWLtdzr JP0ty3lusp4xI3TB656j84TrZReZt8YypJMxDGX+gcYFtJBhaMyrUrMz872fkdOLEmQE Hq9TblLX/a7VexOVuDhZ+Ma57LW4BxqnYpXTVvx4EywQHVDkvETPDCrvqb/TbyLtSdpB fkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=xv9dsCuBB8DgcfaeNwmWBE9YTRIXMtUFvQKkPzp5lwOKvM59iNjjPVu+z7S5GuEHpJ zNpgqKmxYixT1yPosf0JrJCuCIS12v71ty2gg+ocDAdvVjLpBQjVNPSwuikQT1cWosu+ T3czWklzl9JZxMstpuLuzNxqHYELi5v3R6LHDCFGaoTSWtC2urM7XADIABDyi8XMCgwt 9fmbOK6XhzPF1hGFzlOKly6dJ7YYHrZADZfEY76Jy//Khvt9cQLgTlsG1S4uAz3ViQeK +pBHoOjH458usGFybHwAWmrqiwKm9ie160y6O/YlmXfe/BBvC/hI80yfwCjkQuGpVzZD OPEA== X-Gm-Message-State: AFqh2kqap6RsFzhDG7A8VKgNQZkG3OqbgakbTcnprpNmGTrl/Hw0rZuW 8MjYnCmQ4suBXnyMYvS2lUs= X-Google-Smtp-Source: AMrXdXsmxFZd/rHacNHGgaNO0QgicI8Ygk33pTya8486hCbXBRvtbb9wFn//Xw+vipC4b2R7t75KSA== X-Received: by 2002:a17:906:6a27:b0:872:8c97:db27 with SMTP id qw39-20020a1709066a2700b008728c97db27mr14876851ejc.69.1674168176978; Thu, 19 Jan 2023 14:42:56 -0800 (PST) Received: from ?IPV6:2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1? (dynamic-2a01-0c23-c477-4300-3c6e-3915-fc5a-2ff1.c23.pool.telefonica.de. [2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1]) by smtp.googlemail.com with ESMTPSA id 9-20020a170906218900b0084cb4d37b8csm17043453eju.141.2023.01.19.14.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 14:42:56 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 23:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US From: Heiner Kallweit To: Neil Armstrong , Andrew Lunn , Jerome Brunet , Martin Blumenstingl Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kevin Hilman , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_144300_908014_433FC904 X-CRM114-Status: GOOD ( 31.03 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gMTUuMDEuMjAyMyAyMTozOCwgSGVpbmVyIEthbGx3ZWl0IHdyb3RlOgo+IE9uIDE1LjAxLjIw MjMgMTk6NDMsIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+PiBIaSBIZWluZXIsCj4+Cj4+IExlIDE1 LzAxLzIwMjMgw6AgMTg6MDksIEhlaW5lciBLYWxsd2VpdCBhIMOpY3JpdMKgOgo+Pj4gT24gMTUu MDEuMjAyMyAxNzo1NywgQW5kcmV3IEx1bm4gd3JvdGU6Cj4+Pj4gT24gU3VuLCBKYW4gMTUsIDIw MjMgYXQgMDQ6MTk6MzdQTSArMDEwMCwgSGVpbmVyIEthbGx3ZWl0IHdyb3RlOgo+Pj4+PiBPbiBt eSBTQzItYmFzZWQgc3lzdGVtIHRoZSBnZW5waHkgZHJpdmVyIHdhcyB1c2VkIGJlY2F1c2UgdGhl IFBIWQo+Pj4+PiBpZGVudGlmaWVzIGFzIDB4MDE4MDMzMDAuIEl0IHdvcmtzIG5vcm1hbCB3aXRo IHRoZSBtZXNvbiBnMTJhCj4+Pj4+IGRyaXZlciBhZnRlciB0aGlzIGNoYW5nZS4KPj4+Pj4gU3dp dGNoIHRvIFBIWV9JRF9NQVRDSF9NT0RFTCB0byBjb3ZlciB0aGUgZGlmZmVyZW50IHN1Yi12ZXJz aW9ucy4KPj4+Pgo+Pj4+IEhpIEhlaW5lcgo+Pj4+Cj4+Pj4gQXJlIHRoZXJlIGFueSBkYXRhc2hl ZXRzIGZvciB0aGVzZSBkZXZpY2VzPyBBbnl0aGluZyB3aGljaCBkb2N1bWVudHMKPj4+PiB0aGUg bG93ZXIgbmliYmxlIHJlYWxseSBpcyBhIHJldmlzaW9uPwo+Pj4+Cj4+Pj4gSSdtIGp1c3QgdHJ5 aW5nIHRvIGF2b2lkIGZ1dHVyZSBwcm9ibGVtcyB3aGVyZSB3ZSBmaW5kIGl0IGlzIGFjdHVhbGx5 Cj4+Pj4gYSBkaWZmZXJlbnQgUEhZLCBuZWVkcyBpdHMgb3duIE1BVENIX0VYQUNUIGVudHJ5LCBh bmQgdGhlbiB3ZSBmaW5kIHdlCj4+Pj4gYnJlYWsgZGV2aWNlcyB1c2luZyAweDAxODAzMzAyIHdo aWNoIHdlIGhhZCBubyBpZGVhIGV4aXN0cywgYnV0IGdvdAo+Pj4+IGNvdmVyZWQgYnkgdGhpcyBj aGFuZ2UuCj4+Pj4KPj4+IFRoZSBTQzIgcGxhdGZvcm0gaW5oZXJpdGVkIGEgbG90IGZyb20gRzEy QSwgdGhlcmVmb3JlIGl0J3MgcGxhdXNpYmxlCj4+PiB0aGF0IGl0J3MgdGhlIHNhbWUgUEhZLiBB bHNvIHRoZSB2ZW5kb3IgZHJpdmVyIGZvciBTQzIgZ2l2ZXMgYSBoaW50Cj4+PiBhcyBpdCBoYXMg dGhlIGZvbGxvd2luZyBjb21wYXRpYmxlIGZvciB0aGUgUEhZOgo+Pj4KPj4+IGNvbXBhdGlibGUg PSAiZXRoZXJuZXQtcGh5LWlkMDE4MC4zMzAxIiwgImV0aGVybmV0LXBoeS1pZWVlODAyLjMtYzIy IjsKPj4+Cj4+PiBCdXQgeW91J3JlIHJpZ2h0LCBJIGNhbid0IHNheSBmb3Igc3VyZSBhcyBJIGRv bid0IGhhdmUgdGhlIGRhdGFzaGVldHMuCj4+Cj4+IE9uIEcxMkEgKCYgR1hMKSwgdGhlIFBIWSBJ RCBpcyBzZXQgaW4gdGhlIE1ESU8gTVVYIHJlZ2lzdGVycywKPj4gcGxlYXNlIHNlZToKPj4gaHR0 cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL25ldC9t ZGlvL21kaW8tbXV4LW1lc29uLWcxMmEuYyNMMzYKPj4KPj4gU28geW91IHNob3VsZCBlaXRoZXIg YWRkIHN1cHBvcnQgZm9yIHRoZSBQSFkgbXV4IGluIFNDMiBvciBjaGVjawo+PiB3aGF0IGlzIGlu IHRoZSBFVEhfUEhZX0NOVEwwIHJlZ2lzdGVyLgo+Pgo+IFRoYW5rcyBmb3IgdGhlIGhpbnQuIEkg anVzdCBjaGVja2VkIGFuZCByZWFkaW5nIGJhY2sgRVRIX1BIWV9DTlRMMCBhdCB0aGUKPiBlbmQg b2YgZzEyYV9lbmFibGVfaW50ZXJuYWxfbWRpbygpIGdpdmVzIG1lIHRoZSBleHBlY3RlZCByZXN1 bHQgb2YgMHgzMzAxMDE4MC4KPiBCdXQgc3RpbGwgdGhlIFBIWSByZXBvcnRzIDMzMDAuCj4gRXZl biBpZiBJIHdyaXRlIHNvbWUgb3RoZXIgcmFuZG9tIHZhbHVlIHRvIEVUSF9QSFlfQ05UTDAsIEkg Z2V0IDAxODAvMzMwMAo+IGFzIFBIWSBJRC4KPiAKPiBGb3IgdS1ib290IEkgZm91bmQgdGhlIGZv bGxvd2luZzoKPiAKPiBodHRwczovL2dpdGh1Yi5jb20va2hhZGFzL3UtYm9vdC9ibG9iL2toYWRh cy12aW00LXItNjRiaXQvZHJpdmVycy9uZXQvcGh5L2FtbG9naWMuYwo+IAo+IHN0YXRpYyBzdHJ1 Y3QgcGh5X2RyaXZlciBhbWxvZ2ljX2ludGVybmFsX2RyaXZlciA9IHsKPiAJLm5hbWUgPSAiTWVz b24gR1hMIEludGVybmFsIFBIWSIsCj4gCS51aWQgPSAweDAxODAzMzAwLAo+IAkubWFzayA9IDB4 ZmZmZmZmZjAsCj4gCS5mZWF0dXJlcyA9IFBIWV9CQVNJQ19GRUFUVVJFUywKPiAJLmNvbmZpZyA9 ICZtZXNvbl9waHlfY29uZmlnLAo+IAkuc3RhcnR1cCA9ICZtZXNvbl9hbWxfc3RhcnR1cCwKPiAJ LnNodXRkb3duID0gJmdlbnBoeV9zaHV0ZG93biwKPiB9Owo+IAo+IFNvIGl0J3MgdGhlIHNhbWUg UEhZIElEIEknbSBzZWVpbmcgaW4gTGludXguCj4gCj4gTXkgYmVzdCBndWVzcyBpcyB0aGF0IHRo ZSBmb2xsb3dpbmcgaXMgdGhlIGNhc2U6Cj4gCj4gVGhlIFBIWSBjb21wYXRpYmxlIHN0cmluZyBp biBEVCBpcyB0aGUgZm9sbG93aW5nIGluIGFsbCBjYXNlczoKPiBjb21wYXRpYmxlID0gImV0aGVy bmV0LXBoeS1pZDAxODAuMzMwMSIsICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiI7Cj4gCj4g VGhlcmVmb3JlIGlkIDAxODAvMzMwMSBpcyB1c2VkIGV2ZW4gaWYgdGhlIFBIWSByZXBvcnRzIHNv bWV0aGluZyBlbHNlLgo+IE1lYW5zIGl0IGRvZXNuJ3QgbWF0dGVyIHdoaWNoIHZhbHVlIHlvdSB3 cml0ZSB0byBFVEhfUEhZX0NOVEwwLgo+IAo+IEkgcmVkdWNlZCB0aGUgY29tcGF0aWJsZSBzdHJp bmcgdG8gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiIKPiBhbmQgdGhp cyByZXN1bHRlZCBpbiB0aGUgYWN0dWFsIFBIWSBJRCBiZWluZyB1c2VkLgo+IFlvdSBjb3VsZCBj aGFuZ2UgdGhlIGNvbXBhdGlibGUgaW4gZHRzIHRoZSBzYW1lIHdheSBmb3IgYW55IGcxMmEgc3lz dGVtCj4gYW5kIEkgYXNzdW1lIHlvdSB3b3VsZCBnZXQgMDE4MC8zMzAwIHRvby4KPiAKPiBSZW1h aW5pbmcgcXVlc3Rpb24gaXMgd2h5IHRoZSB2YWx1ZSBpbiBFVEhfUEhZX0NOVEwwIGlzIGlnbm9y ZWQuCj4gCgpJIHRoaW5rIEkgZm91bmQgd2hhdCdzIGdvaW5nIG9uLiBUaGUgUEhZIElEIHdyaXR0 ZW4gdG8gU29DIHJlZ2lzdGVyCkVUSF9QSFlfQ05UTDAgaXNuJ3QgZWZmZWN0aXZlIGltbWVkaWF0 ZWx5LiBJdCB0YWtlcyBhIFBIWSBzb2Z0IHJlc2V0IGJlZm9yZQppdCByZXBvcnRzIHRoZSBuZXcg UEhZIElELiBXb3VsZCBiZSBnb29kIHRvIGhhdmUgYSBjb21tZW50IGluIHRoZQpnMTJhIG1kaW8g bXV4IGNvZGUgbWVudGlvbmluZyB0aGlzIGNvbnN0cmFpbnQuCgpJIHNlZSBubyBlYXN5IHdheSB0 byB0cmlnZ2VyIGEgc29mdCByZXNldCBlYXJseSBlbm91Z2guIFRoZXJlZm9yZSBpdCdzIGluZGVl ZAp0aGUgc2ltcGxlc3Qgb3B0aW9uIHRvIHNwZWNpZnkgdGhlIG5ldyBQSFkgSUQgaW4gdGhlIGNv bXBhdGlibGUuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59A77C46467 for ; Thu, 19 Jan 2023 22:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Subject:References:Cc:To: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=okIfZXKBzMWL9+qpunoNZw4Eua4glzAYDPmQjsCynLc=; b=jt90gVNHCw2w3l Y3guESKt8yeN9oQUEJWY1nK+c4YEdFrNdEljK+r4w2j8st2ILvYfcgczDX1yM7NIKwzi8kVPpMvLn TihpnykZkXH3QeQNNW8NOXXsrQJVUFY3krEcTkQIpxE3AN6jTjWGw2VfBZ/hBHZK6euF/I9Biik7F 6a874i6pv5MAHr01M/4WvSKZNnEfMjQVcNuDAAY3Jp3q50T6BaBbjYbkW8tZ7/7RIV8i6aoGBmmDZ IJyicomCpzHfHlWdBWBid79bkIHvXna9m0LcOuL2fCYM7tAjhxl1hs7NlnVAOic5DAnj+mZM8PHR9 +8xB4o8e5QLIXZcYS6JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIdcf-007V0j-AB; Thu, 19 Jan 2023 22:43:05 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIdca-007Uyl-QB; Thu, 19 Jan 2023 22:43:02 +0000 Received: by mail-ej1-x630.google.com with SMTP id ud5so9641650ejc.4; Thu, 19 Jan 2023 14:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=fgBrJZbIA/l4ZBuwloIrwqfNZDxDJ6pT5E0y/03G4LSnHeQyhmYY2Dn31ZQSuZNq7c 5xAbt6XeL21Tyxdia6IsElgzdkWGVu+OW3/TEgB3++PMxS95NMje7CDNJoMMeQ9sCBJN RbFu55SK7eGr8ldGitcj7LULi9nN6Yn5+uT3q0utpjcCT3+6eDtZn6D1u2KCukWLtdzr JP0ty3lusp4xI3TB656j84TrZReZt8YypJMxDGX+gcYFtJBhaMyrUrMz872fkdOLEmQE Hq9TblLX/a7VexOVuDhZ+Ma57LW4BxqnYpXTVvx4EywQHVDkvETPDCrvqb/TbyLtSdpB fkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=xv9dsCuBB8DgcfaeNwmWBE9YTRIXMtUFvQKkPzp5lwOKvM59iNjjPVu+z7S5GuEHpJ zNpgqKmxYixT1yPosf0JrJCuCIS12v71ty2gg+ocDAdvVjLpBQjVNPSwuikQT1cWosu+ T3czWklzl9JZxMstpuLuzNxqHYELi5v3R6LHDCFGaoTSWtC2urM7XADIABDyi8XMCgwt 9fmbOK6XhzPF1hGFzlOKly6dJ7YYHrZADZfEY76Jy//Khvt9cQLgTlsG1S4uAz3ViQeK +pBHoOjH458usGFybHwAWmrqiwKm9ie160y6O/YlmXfe/BBvC/hI80yfwCjkQuGpVzZD OPEA== X-Gm-Message-State: AFqh2kqap6RsFzhDG7A8VKgNQZkG3OqbgakbTcnprpNmGTrl/Hw0rZuW 8MjYnCmQ4suBXnyMYvS2lUs= X-Google-Smtp-Source: AMrXdXsmxFZd/rHacNHGgaNO0QgicI8Ygk33pTya8486hCbXBRvtbb9wFn//Xw+vipC4b2R7t75KSA== X-Received: by 2002:a17:906:6a27:b0:872:8c97:db27 with SMTP id qw39-20020a1709066a2700b008728c97db27mr14876851ejc.69.1674168176978; Thu, 19 Jan 2023 14:42:56 -0800 (PST) Received: from ?IPV6:2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1? (dynamic-2a01-0c23-c477-4300-3c6e-3915-fc5a-2ff1.c23.pool.telefonica.de. [2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1]) by smtp.googlemail.com with ESMTPSA id 9-20020a170906218900b0084cb4d37b8csm17043453eju.141.2023.01.19.14.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 14:42:56 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 23:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US From: Heiner Kallweit To: Neil Armstrong , Andrew Lunn , Jerome Brunet , Martin Blumenstingl Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kevin Hilman , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_144300_908014_433FC904 X-CRM114-Status: GOOD ( 31.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTUuMDEuMjAyMyAyMTozOCwgSGVpbmVyIEthbGx3ZWl0IHdyb3RlOgo+IE9uIDE1LjAxLjIw MjMgMTk6NDMsIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+PiBIaSBIZWluZXIsCj4+Cj4+IExlIDE1 LzAxLzIwMjMgw6AgMTg6MDksIEhlaW5lciBLYWxsd2VpdCBhIMOpY3JpdMKgOgo+Pj4gT24gMTUu MDEuMjAyMyAxNzo1NywgQW5kcmV3IEx1bm4gd3JvdGU6Cj4+Pj4gT24gU3VuLCBKYW4gMTUsIDIw MjMgYXQgMDQ6MTk6MzdQTSArMDEwMCwgSGVpbmVyIEthbGx3ZWl0IHdyb3RlOgo+Pj4+PiBPbiBt eSBTQzItYmFzZWQgc3lzdGVtIHRoZSBnZW5waHkgZHJpdmVyIHdhcyB1c2VkIGJlY2F1c2UgdGhl IFBIWQo+Pj4+PiBpZGVudGlmaWVzIGFzIDB4MDE4MDMzMDAuIEl0IHdvcmtzIG5vcm1hbCB3aXRo IHRoZSBtZXNvbiBnMTJhCj4+Pj4+IGRyaXZlciBhZnRlciB0aGlzIGNoYW5nZS4KPj4+Pj4gU3dp dGNoIHRvIFBIWV9JRF9NQVRDSF9NT0RFTCB0byBjb3ZlciB0aGUgZGlmZmVyZW50IHN1Yi12ZXJz aW9ucy4KPj4+Pgo+Pj4+IEhpIEhlaW5lcgo+Pj4+Cj4+Pj4gQXJlIHRoZXJlIGFueSBkYXRhc2hl ZXRzIGZvciB0aGVzZSBkZXZpY2VzPyBBbnl0aGluZyB3aGljaCBkb2N1bWVudHMKPj4+PiB0aGUg bG93ZXIgbmliYmxlIHJlYWxseSBpcyBhIHJldmlzaW9uPwo+Pj4+Cj4+Pj4gSSdtIGp1c3QgdHJ5 aW5nIHRvIGF2b2lkIGZ1dHVyZSBwcm9ibGVtcyB3aGVyZSB3ZSBmaW5kIGl0IGlzIGFjdHVhbGx5 Cj4+Pj4gYSBkaWZmZXJlbnQgUEhZLCBuZWVkcyBpdHMgb3duIE1BVENIX0VYQUNUIGVudHJ5LCBh bmQgdGhlbiB3ZSBmaW5kIHdlCj4+Pj4gYnJlYWsgZGV2aWNlcyB1c2luZyAweDAxODAzMzAyIHdo aWNoIHdlIGhhZCBubyBpZGVhIGV4aXN0cywgYnV0IGdvdAo+Pj4+IGNvdmVyZWQgYnkgdGhpcyBj aGFuZ2UuCj4+Pj4KPj4+IFRoZSBTQzIgcGxhdGZvcm0gaW5oZXJpdGVkIGEgbG90IGZyb20gRzEy QSwgdGhlcmVmb3JlIGl0J3MgcGxhdXNpYmxlCj4+PiB0aGF0IGl0J3MgdGhlIHNhbWUgUEhZLiBB bHNvIHRoZSB2ZW5kb3IgZHJpdmVyIGZvciBTQzIgZ2l2ZXMgYSBoaW50Cj4+PiBhcyBpdCBoYXMg dGhlIGZvbGxvd2luZyBjb21wYXRpYmxlIGZvciB0aGUgUEhZOgo+Pj4KPj4+IGNvbXBhdGlibGUg PSAiZXRoZXJuZXQtcGh5LWlkMDE4MC4zMzAxIiwgImV0aGVybmV0LXBoeS1pZWVlODAyLjMtYzIy IjsKPj4+Cj4+PiBCdXQgeW91J3JlIHJpZ2h0LCBJIGNhbid0IHNheSBmb3Igc3VyZSBhcyBJIGRv bid0IGhhdmUgdGhlIGRhdGFzaGVldHMuCj4+Cj4+IE9uIEcxMkEgKCYgR1hMKSwgdGhlIFBIWSBJ RCBpcyBzZXQgaW4gdGhlIE1ESU8gTVVYIHJlZ2lzdGVycywKPj4gcGxlYXNlIHNlZToKPj4gaHR0 cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL25ldC9t ZGlvL21kaW8tbXV4LW1lc29uLWcxMmEuYyNMMzYKPj4KPj4gU28geW91IHNob3VsZCBlaXRoZXIg YWRkIHN1cHBvcnQgZm9yIHRoZSBQSFkgbXV4IGluIFNDMiBvciBjaGVjawo+PiB3aGF0IGlzIGlu IHRoZSBFVEhfUEhZX0NOVEwwIHJlZ2lzdGVyLgo+Pgo+IFRoYW5rcyBmb3IgdGhlIGhpbnQuIEkg anVzdCBjaGVja2VkIGFuZCByZWFkaW5nIGJhY2sgRVRIX1BIWV9DTlRMMCBhdCB0aGUKPiBlbmQg b2YgZzEyYV9lbmFibGVfaW50ZXJuYWxfbWRpbygpIGdpdmVzIG1lIHRoZSBleHBlY3RlZCByZXN1 bHQgb2YgMHgzMzAxMDE4MC4KPiBCdXQgc3RpbGwgdGhlIFBIWSByZXBvcnRzIDMzMDAuCj4gRXZl biBpZiBJIHdyaXRlIHNvbWUgb3RoZXIgcmFuZG9tIHZhbHVlIHRvIEVUSF9QSFlfQ05UTDAsIEkg Z2V0IDAxODAvMzMwMAo+IGFzIFBIWSBJRC4KPiAKPiBGb3IgdS1ib290IEkgZm91bmQgdGhlIGZv bGxvd2luZzoKPiAKPiBodHRwczovL2dpdGh1Yi5jb20va2hhZGFzL3UtYm9vdC9ibG9iL2toYWRh cy12aW00LXItNjRiaXQvZHJpdmVycy9uZXQvcGh5L2FtbG9naWMuYwo+IAo+IHN0YXRpYyBzdHJ1 Y3QgcGh5X2RyaXZlciBhbWxvZ2ljX2ludGVybmFsX2RyaXZlciA9IHsKPiAJLm5hbWUgPSAiTWVz b24gR1hMIEludGVybmFsIFBIWSIsCj4gCS51aWQgPSAweDAxODAzMzAwLAo+IAkubWFzayA9IDB4 ZmZmZmZmZjAsCj4gCS5mZWF0dXJlcyA9IFBIWV9CQVNJQ19GRUFUVVJFUywKPiAJLmNvbmZpZyA9 ICZtZXNvbl9waHlfY29uZmlnLAo+IAkuc3RhcnR1cCA9ICZtZXNvbl9hbWxfc3RhcnR1cCwKPiAJ LnNodXRkb3duID0gJmdlbnBoeV9zaHV0ZG93biwKPiB9Owo+IAo+IFNvIGl0J3MgdGhlIHNhbWUg UEhZIElEIEknbSBzZWVpbmcgaW4gTGludXguCj4gCj4gTXkgYmVzdCBndWVzcyBpcyB0aGF0IHRo ZSBmb2xsb3dpbmcgaXMgdGhlIGNhc2U6Cj4gCj4gVGhlIFBIWSBjb21wYXRpYmxlIHN0cmluZyBp biBEVCBpcyB0aGUgZm9sbG93aW5nIGluIGFsbCBjYXNlczoKPiBjb21wYXRpYmxlID0gImV0aGVy bmV0LXBoeS1pZDAxODAuMzMwMSIsICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiI7Cj4gCj4g VGhlcmVmb3JlIGlkIDAxODAvMzMwMSBpcyB1c2VkIGV2ZW4gaWYgdGhlIFBIWSByZXBvcnRzIHNv bWV0aGluZyBlbHNlLgo+IE1lYW5zIGl0IGRvZXNuJ3QgbWF0dGVyIHdoaWNoIHZhbHVlIHlvdSB3 cml0ZSB0byBFVEhfUEhZX0NOVEwwLgo+IAo+IEkgcmVkdWNlZCB0aGUgY29tcGF0aWJsZSBzdHJp bmcgdG8gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiIKPiBhbmQgdGhp cyByZXN1bHRlZCBpbiB0aGUgYWN0dWFsIFBIWSBJRCBiZWluZyB1c2VkLgo+IFlvdSBjb3VsZCBj aGFuZ2UgdGhlIGNvbXBhdGlibGUgaW4gZHRzIHRoZSBzYW1lIHdheSBmb3IgYW55IGcxMmEgc3lz dGVtCj4gYW5kIEkgYXNzdW1lIHlvdSB3b3VsZCBnZXQgMDE4MC8zMzAwIHRvby4KPiAKPiBSZW1h aW5pbmcgcXVlc3Rpb24gaXMgd2h5IHRoZSB2YWx1ZSBpbiBFVEhfUEhZX0NOVEwwIGlzIGlnbm9y ZWQuCj4gCgpJIHRoaW5rIEkgZm91bmQgd2hhdCdzIGdvaW5nIG9uLiBUaGUgUEhZIElEIHdyaXR0 ZW4gdG8gU29DIHJlZ2lzdGVyCkVUSF9QSFlfQ05UTDAgaXNuJ3QgZWZmZWN0aXZlIGltbWVkaWF0 ZWx5LiBJdCB0YWtlcyBhIFBIWSBzb2Z0IHJlc2V0IGJlZm9yZQppdCByZXBvcnRzIHRoZSBuZXcg UEhZIElELiBXb3VsZCBiZSBnb29kIHRvIGhhdmUgYSBjb21tZW50IGluIHRoZQpnMTJhIG1kaW8g bXV4IGNvZGUgbWVudGlvbmluZyB0aGlzIGNvbnN0cmFpbnQuCgpJIHNlZSBubyBlYXN5IHdheSB0 byB0cmlnZ2VyIGEgc29mdCByZXNldCBlYXJseSBlbm91Z2guIFRoZXJlZm9yZSBpdCdzIGluZGVl ZAp0aGUgc2ltcGxlc3Qgb3B0aW9uIHRvIHNwZWNpZnkgdGhlIG5ldyBQSFkgSUQgaW4gdGhlIGNv bXBhdGlibGUuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6A0C6379F for ; Thu, 19 Jan 2023 22:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbjASW6j (ORCPT ); Thu, 19 Jan 2023 17:58:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230318AbjASW5i (ORCPT ); Thu, 19 Jan 2023 17:57:38 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2C248A09 for ; Thu, 19 Jan 2023 14:42:58 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id mp20so9586173ejc.7 for ; Thu, 19 Jan 2023 14:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=fgBrJZbIA/l4ZBuwloIrwqfNZDxDJ6pT5E0y/03G4LSnHeQyhmYY2Dn31ZQSuZNq7c 5xAbt6XeL21Tyxdia6IsElgzdkWGVu+OW3/TEgB3++PMxS95NMje7CDNJoMMeQ9sCBJN RbFu55SK7eGr8ldGitcj7LULi9nN6Yn5+uT3q0utpjcCT3+6eDtZn6D1u2KCukWLtdzr JP0ty3lusp4xI3TB656j84TrZReZt8YypJMxDGX+gcYFtJBhaMyrUrMz872fkdOLEmQE Hq9TblLX/a7VexOVuDhZ+Ma57LW4BxqnYpXTVvx4EywQHVDkvETPDCrvqb/TbyLtSdpB fkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wp1oH3VUeR8ctDbrH8Su2X852AptYELpIhyYkwz3XhU=; b=yoKJ7RFFRxawF2ybZUhI9gvMj0jVsDVl38LTk1evyWkLPmRIth48n/KhHYUmHDuVRb f4fyDQAkb5snqL77Bz9JV4loOB4xRCP5CaN/PPAYkFMbpIyfPBWbRqI6yo7dMAaGM28f p7DFf61uPiUG7HF469BMNMST+5wh1DFNd60NBvAHKzZZDfdP8lP5Ak2H85fedPBfkuAm RDMX/A87zQ/GJAxgj8BSXGlE6VJILhI+Zv82wviq2BjbGaiVSYTfcN3tltpKwCQRBfun sQ9FtUvgDoARrNS25RFUsMyqqEF5MeoMKoKiBGS0glc1Kw8s+lZhFkKZzKSKw68NWbnK k5aA== X-Gm-Message-State: AFqh2koYe7+8nadT8FM3Sts2+xHwRaLSxVY/0FCtkp3rD/9UVAYTFHZz hJ+K/7KEhvLyDt0L16bFEwE= X-Google-Smtp-Source: AMrXdXsmxFZd/rHacNHGgaNO0QgicI8Ygk33pTya8486hCbXBRvtbb9wFn//Xw+vipC4b2R7t75KSA== X-Received: by 2002:a17:906:6a27:b0:872:8c97:db27 with SMTP id qw39-20020a1709066a2700b008728c97db27mr14876851ejc.69.1674168176978; Thu, 19 Jan 2023 14:42:56 -0800 (PST) Received: from ?IPV6:2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1? (dynamic-2a01-0c23-c477-4300-3c6e-3915-fc5a-2ff1.c23.pool.telefonica.de. [2a01:c23:c477:4300:3c6e:3915:fc5a:2ff1]) by smtp.googlemail.com with ESMTPSA id 9-20020a170906218900b0084cb4d37b8csm17043453eju.141.2023.01.19.14.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 14:42:56 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 23:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US From: Heiner Kallweit To: Neil Armstrong , Andrew Lunn , Jerome Brunet , Martin Blumenstingl Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kevin Hilman , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 15.01.2023 21:38, Heiner Kallweit wrote: > On 15.01.2023 19:43, Neil Armstrong wrote: >> Hi Heiner, >> >> Le 15/01/2023 à 18:09, Heiner Kallweit a écrit : >>> On 15.01.2023 17:57, Andrew Lunn wrote: >>>> On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote: >>>>> On my SC2-based system the genphy driver was used because the PHY >>>>> identifies as 0x01803300. It works normal with the meson g12a >>>>> driver after this change. >>>>> Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions. >>>> >>>> Hi Heiner >>>> >>>> Are there any datasheets for these devices? Anything which documents >>>> the lower nibble really is a revision? >>>> >>>> I'm just trying to avoid future problems where we find it is actually >>>> a different PHY, needs its own MATCH_EXACT entry, and then we find we >>>> break devices using 0x01803302 which we had no idea exists, but got >>>> covered by this change. >>>> >>> The SC2 platform inherited a lot from G12A, therefore it's plausible >>> that it's the same PHY. Also the vendor driver for SC2 gives a hint >>> as it has the following compatible for the PHY: >>> >>> compatible = "ethernet-phy-id0180.3301", "ethernet-phy-ieee802.3-c22"; >>> >>> But you're right, I can't say for sure as I don't have the datasheets. >> >> On G12A (& GXL), the PHY ID is set in the MDIO MUX registers, >> please see: >> https://elixir.bootlin.com/linux/latest/source/drivers/net/mdio/mdio-mux-meson-g12a.c#L36 >> >> So you should either add support for the PHY mux in SC2 or check >> what is in the ETH_PHY_CNTL0 register. >> > Thanks for the hint. I just checked and reading back ETH_PHY_CNTL0 at the > end of g12a_enable_internal_mdio() gives me the expected result of 0x33010180. > But still the PHY reports 3300. > Even if I write some other random value to ETH_PHY_CNTL0, I get 0180/3300 > as PHY ID. > > For u-boot I found the following: > > https://github.com/khadas/u-boot/blob/khadas-vim4-r-64bit/drivers/net/phy/amlogic.c > > static struct phy_driver amlogic_internal_driver = { > .name = "Meson GXL Internal PHY", > .uid = 0x01803300, > .mask = 0xfffffff0, > .features = PHY_BASIC_FEATURES, > .config = &meson_phy_config, > .startup = &meson_aml_startup, > .shutdown = &genphy_shutdown, > }; > > So it's the same PHY ID I'm seeing in Linux. > > My best guess is that the following is the case: > > The PHY compatible string in DT is the following in all cases: > compatible = "ethernet-phy-id0180.3301", "ethernet-phy-ieee802.3-c22"; > > Therefore id 0180/3301 is used even if the PHY reports something else. > Means it doesn't matter which value you write to ETH_PHY_CNTL0. > > I reduced the compatible string to compatible = "ethernet-phy-ieee802.3-c22" > and this resulted in the actual PHY ID being used. > You could change the compatible in dts the same way for any g12a system > and I assume you would get 0180/3300 too. > > Remaining question is why the value in ETH_PHY_CNTL0 is ignored. > I think I found what's going on. The PHY ID written to SoC register ETH_PHY_CNTL0 isn't effective immediately. It takes a PHY soft reset before it reports the new PHY ID. Would be good to have a comment in the g12a mdio mux code mentioning this constraint. I see no easy way to trigger a soft reset early enough. Therefore it's indeed the simplest option to specify the new PHY ID in the compatible.