From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC1BC07E95 for ; Tue, 13 Jul 2021 15:30:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 296AA61175 for ; Tue, 13 Jul 2021 15:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 296AA61175 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6BDA01692; Tue, 13 Jul 2021 17:29:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6BDA01692 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626190225; bh=gOuRZDOYmljkDFmtMTw25gvRbfMAOMwp1yboCXsmffI=; h=Subject:To:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K5GVBmpjUy5lYX5ot96jVDWS6Z0/mkJLkZOGD6KcDXu+3up4Qcc4cHanWmVSNIyy6 qGVvfvUOmHcUEAnzP9AYVgon8aFObGkltKTosKjRF8bDRmLs6ZQ9Fvy0cyG/FOs5un 4zolpKOjIbSjSwpyGIdKnxFfGnJgjHz9jowWRWgw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 99328F800ED; Tue, 13 Jul 2021 17:28:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 39F59F80430; Tue, 13 Jul 2021 17:28:46 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 344A0F800ED for ; Tue, 13 Jul 2021 17:28:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 344A0F800ED X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="209999106" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="209999106" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 08:23:28 -0700 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="493853545" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.237.180.79]) ([10.237.180.79]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 08:23:27 -0700 Subject: Re: [PATCH 15/51] ALSA: ens137x: Allocate resources with device-managed APIs To: Takashi Iwai , alsa-devel@alsa-project.org References: <20210713142857.19654-1-tiwai@suse.de> <20210713142857.19654-16-tiwai@suse.de> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: Date: Tue, 13 Jul 2021 17:23:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713142857.19654-16-tiwai@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/13/2021 4:28 PM, Takashi Iwai wrote: > This patch converts the resource management in PCI esn137x drivers > with devres as a clean up. Each manual resource management is > converted with the corresponding devres helper, the devres helper is > used for the DMA buffer page allocations, and the card object release > is managed now via card->private_free instead of a lowlevel > snd_device. > > This should give no user-visible functional changes. > > Signed-off-by: Takashi Iwai > --- > sound/pci/ens1370.c | 115 +++++++++++--------------------------------- > 1 file changed, 27 insertions(+), 88 deletions(-) > > diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c > index 728b69dad21b..2651f0c64c06 100644 > --- a/sound/pci/ens1370.c > +++ b/sound/pci/ens1370.c > @@ -414,7 +414,7 @@ struct ensoniq { > unsigned int spdif_stream; > > #ifdef CHIP1370 > - struct snd_dma_buffer dma_bug; > + struct snd_dma_buffer *dma_bug; You seem to touch all uses of this variable and it seems like it has a typo (dma_bug -> dms_buf), not sure if it can be corrected in this patch or separate one.