From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83AA37160; Wed, 8 Nov 2023 21:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="32beSgpe"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kjlV4oVb" X-Greylist: delayed 585 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 08 Nov 2023 13:17:25 PST Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2443E213F; Wed, 8 Nov 2023 13:17:25 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 15DEC5808D9; Wed, 8 Nov 2023 16:07:40 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477660; x=1699484860; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=32beSgpe4JW/41MI9lwE9Ijo4clBZDCZcdz5W29GlXfmeBdloGs Pj6zClFpI3rBEASL5bt2BJ0z9kSHXoRmNM9S3ZUV9IpU6H2SlzHeojjwyK38ubdm rc5I6AbHQO428z+GTudTpXj84wN1iHyD5B4xrh7Xg9+/lOsXO8mWGmiOw0oEtT95 59tIeWQXJ0PMlmbTe9oPGJNjvuF2Q00g7Aup3KvWuYCehPghEdVuK62ANt1RCDNX P59SJAJQv8a5rR+mmaJ00cjQiQKIVXVSq/NkJ5Ceh2lpGohzfDFoxucwi0IF29D/ 556O8j5asu9BGmdizp+cE+MTUaFBWLNaDZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477660; x=1699484860; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=kjlV4oVb2NP4EXVJD0KYm4LTALqMkDnrU92/a5IM2DxqbQWjsi+ IwdXxoSa3WEs4VZrlHH4JbCKkIL0G8Pwij1126xSe7hG/IMqOBcu3RQxvqgsEHsb pcFM0Ua1NE3OwtwEsNMc4jlmhSYjBeK+x0Ed/W7Rlf03UIZVqr2B+d0ryicP7Tub QSkOlA0efMsPA3XcbslixipIgl/+8P6M15YEgB0c0t6f8ouEUKSI2KL0MYB9RUr3 hoiEAHdJCFrsG/Y/a3llxHIutnrnDvRz3cIbj7RF5co+2MINYEdgACq/D/uqzlpo r0L8iW3NWB7AxkztwyKFHjpLOPBdYiLEhJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, "Masahiro Yamada" , linux-kbuild@vger.kernel.org, "Matt Turner" , "Vineet Gupta" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , guoren , "Peter Zijlstra" , "Ard Biesheuvel" , "Huacai Chen" , "Greg Ungerer" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Geoff Levand" , "Palmer Dabbelt" , "Heiko Carstens" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andy Lutomirski" , "Thomas Gleixner" , "Ingo Molnar" , x86@kernel.org, "Helge Deller" , "Sudip Mukherjee" , "Greg Kroah-Hartman" , "Timur Tabi" , "Kent Overstreet" , "David Woodhouse" , "Naveen N. Rao" , "Anil S Keshavamurthy" , "Kees Cook" , "Vincenzo Frascino" , "Juri Lelli" , "Vincent Guittot" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" , "Alexander Viro" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Netdev , linux-parisc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "linux-bcachefs@vger.kernel.org" , linux-mtd@lists.infradead.org Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01=E2=80=AFPM Arnd Bergmann = wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that = is >> enabled: >> >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype f= or 'trap_init' [-Wmissing-prototypes] >> >> Include the right header to avoid this. >> >> Signed-off-by: Arnd Bergmann > > Thanks for your patch! > >> arch/alpha/kernel/traps.c | 1 + >> arch/csky/include/asm/traps.h | 2 -- >> arch/csky/kernel/traps.c | 1 + >> arch/m68k/coldfire/vectors.c | 3 +-- >> arch/m68k/coldfire/vectors.h | 3 --- > > Ah, so this is where the m68k changes listed in the cover letter are > hiding ;-) > >> arch/microblaze/kernel/traps.c | 1 + >> arch/sparc/kernel/traps_32.c | 1 + >> arch/sparc/kernel/traps_64.c | 1 + >> arch/x86/include/asm/traps.h | 1 - >> arch/x86/kernel/traps.c | 1 + >> 10 files changed, 7 insertions(+), 8 deletions(-) >> delete mode 100644 arch/m68k/coldfire/vectors.h > > Obviously the non-microblaze changes should be spun off in separate > patches. I messed up one of my rebases here and accidentally sent the wrong changelog text. My intention was to have the combined patch but with this text: arch: include linux/cpu.h for trap_init() prototype =20 some architectures run into a -Wmissing-prototypes warning for trap_init() =20 arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype = for 'trap_init' [-Wmissing-prototypes] =20 Include the right header to avoid this consistently, removing the extra declarations on m68k and x86 that were added as local workarounds already. =20 Signed-off-by: Arnd Bergmann I made the same mistake with the "arch: add do_page_fault prototypes" patch that was missing an explanation. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42CE9C4332F for ; Wed, 8 Nov 2023 21:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ZYz4W8JVI3vewgoFJcWy/GL+GSEuzLn4YHm2Vzahkc=; b=yA5wx++N/S04XB iW2GWuW64YrJm2Bbr7YBEldRsDrRSVC7nzMAbLGAeCjYM/BqoqxnT5lRkjKyxdFpH7wOc024j7aId twHzSdkSne0rtY8Dpl75/HoqueULo1fWXVF0/l5uXMJfdLkIPim4Dr0QvOcVlQjCBI5+Ayywg4DJ7 XARwRyFDf6/5CZfbqQpvdRE2TVuK8fpfbLHXZlA24WGcNuIemSSJtTc94SmdppAzoSAvKpkCa+U8Y Y95XIQ24+20TqYLRqz66lDeomDll8Gw8zS4HB6+/BzwI3TLlM2Uek7xcXw/GP9GfWRGCTBiweTT3k Cg/aNYucdWMFnXkYfnJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmG-004kZk-3D; Wed, 08 Nov 2023 21:07:57 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmC-004kXU-1X; Wed, 08 Nov 2023 21:07:54 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A16D580918; Wed, 8 Nov 2023 16:07:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=FzEkiJbbsOcjeyoGRwxvz+27m/0EEN52kEtbmSfnSLxjsunhTiL NfUpLQ2lMaNQM96rJSWMhX1vu2lvWTmYQ+94rPQoTRikLBiEjVkhx122mvhBFjKQ U5TGFlasJtrQz1D7CH1hVXq/4CUXHEmC0SXgOgbsxsmqVBXPjJ6IiWR1L/VYLFZD XaGxAnAinQklWeTyoPeeAGtYUUQIZX8H/zBze0un/GO9mbGPspFKceZcmPF+unL4 kNNYqyz4Nnv3vLyDQfTWJAwW2so0MUevk7DJxqisp5Xl7R8/m+axDeNitBypskfX D8Rsn3kpcQJ2fu6hUerp+k7/Bpi8xmjAE2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=LmqNAy3jRW8lY5IcykLYM+OvjkcYQjDv2Cd5j1qdrakTjXXA/j+ /E3SAMCFGeXJAd+vBXJDuwGp38C0j3EBw7K0I7TFk+KdegquYjjlo+2qe+Ss6fEx vTFJPMC1jaxZ1RiQPNLyTH4/PtfJEIBJRBDr+VVRztDGI1MBoVaVcWj5nK9n57lT IBiw5NhM15aVUl9nTNk4GEH/jjyPtDc5nRFt1GtJMHbfoOK2CNQf2Dsq4mugP1kK dALzlNsXk+kultkDq6XTINxe/wKYr9lcblw8RuAMeZQf5KYd1CJy2yk9Lj+caD2x oxDrnMalA2nkjbwEcTlCPYvCvjr0Nrwhw/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, "Masahiro Yamada" , linux-kbuild@vger.kernel.org, "Matt Turner" , "Vineet Gupta" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , guoren , "Peter Zijlstra" , "Ard Biesheuvel" , "Huacai Chen" , "Greg Ungerer" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Geoff Levand" , "Palmer Dabbelt" , "Heiko Carstens" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andy Lutomirski" , "Thomas Gleixner" , "Ingo Molnar" , x86@kernel.org, "Helge Deller" , "Sudip Mukherjee" , "Greg Kroah-Hartman" , "Timur Tabi" , "Kent Overstreet" , "David Woodhouse" , "Naveen N. Rao" , "Anil S Keshavamurthy" , "Kees Cook" , "Vincenzo Frascino" , "Juri Lelli" , "Vincent Guittot" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" , "Alexander Viro" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Netdev , linux-parisc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "linux-bcachefs@vger.kernel.org" , linux-mtd@lists.infradead.org Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_130752_583464_7B95B6C7 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgOCwgMjAyMywgYXQgMjE6NDIsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToK Pgo+IE9uIFdlZCwgTm92IDgsIDIwMjMgYXQgMjowMeKAr1BNIEFybmQgQmVyZ21hbm4gPGFybmRA a2VybmVsLm9yZz4gd3JvdGU6Cj4+IEZyb206IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+ Cj4+Cj4+IE1pY3JvYmxhemUgcnVucyBpbnRvIGEgc2luZ2xlIC1XbWlzc2luZy1wcm90b3R5cGVz IHdhcm5pbmcgd2hlbiB0aGF0IGlzCj4+IGVuYWJsZWQ6Cj4+Cj4+IGFyY2gvbWljcm9ibGF6ZS9r ZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0 cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90eXBlc10KPj4KPj4gSW5jbHVkZSB0aGUgcmlnaHQg aGVhZGVyIHRvIGF2b2lkIHRoaXMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVyZ21hbm4g PGFybmRAYXJuZGIuZGU+Cj4KPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4KPj4gIGFyY2gvYWxw aGEva2VybmVsL3RyYXBzLmMgICAgICB8IDEgKwo+PiAgYXJjaC9jc2t5L2luY2x1ZGUvYXNtL3Ry YXBzLmggIHwgMiAtLQo+PiAgYXJjaC9jc2t5L2tlcm5lbC90cmFwcy5jICAgICAgIHwgMSArCj4+ ICBhcmNoL202OGsvY29sZGZpcmUvdmVjdG9ycy5jICAgfCAzICstLQo+PiAgYXJjaC9tNjhrL2Nv bGRmaXJlL3ZlY3RvcnMuaCAgIHwgMyAtLS0KPgo+IEFoLCBzbyB0aGlzIGlzIHdoZXJlIHRoZSBt NjhrIGNoYW5nZXMgbGlzdGVkIGluIHRoZSBjb3ZlciBsZXR0ZXIgYXJlCj4gaGlkaW5nIDstKQo+ Cj4+ICBhcmNoL21pY3JvYmxhemUva2VybmVsL3RyYXBzLmMgfCAxICsKPj4gIGFyY2gvc3BhcmMv a2VybmVsL3RyYXBzXzMyLmMgICB8IDEgKwo+PiAgYXJjaC9zcGFyYy9rZXJuZWwvdHJhcHNfNjQu YyAgIHwgMSArCj4+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS90cmFwcy5oICAgfCAxIC0KPj4gIGFy Y2gveDg2L2tlcm5lbC90cmFwcy5jICAgICAgICB8IDEgKwo+PiAgMTAgZmlsZXMgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+PiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGFy Y2gvbTY4ay9jb2xkZmlyZS92ZWN0b3JzLmgKPgo+IE9idmlvdXNseSB0aGUgbm9uLW1pY3JvYmxh emUgY2hhbmdlcyBzaG91bGQgYmUgc3B1biBvZmYgaW4gc2VwYXJhdGUKPiBwYXRjaGVzLgoKSSBt ZXNzZWQgdXAgb25lIG9mIG15IHJlYmFzZXMgaGVyZSBhbmQgYWNjaWRlbnRhbGx5IHNlbnQKdGhl IHdyb25nIGNoYW5nZWxvZyB0ZXh0LiBNeSBpbnRlbnRpb24gd2FzIHRvIGhhdmUgdGhlCmNvbWJp bmVkIHBhdGNoIGJ1dCB3aXRoIHRoaXMgdGV4dDoKCiAgICBhcmNoOiBpbmNsdWRlIGxpbnV4L2Nw dS5oIGZvciB0cmFwX2luaXQoKSBwcm90b3R5cGUKICAgIAogICAgc29tZSBhcmNoaXRlY3R1cmVz IHJ1biBpbnRvIGEgLVdtaXNzaW5nLXByb3RvdHlwZXMgd2FybmluZwogICAgZm9yIHRyYXBfaW5p dCgpCiAgICAKICAgIGFyY2gvbWljcm9ibGF6ZS9rZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5n OiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90 eXBlc10KICAgIAogICAgSW5jbHVkZSB0aGUgcmlnaHQgaGVhZGVyIHRvIGF2b2lkIHRoaXMgY29u c2lzdGVudGx5LCByZW1vdmluZwogICAgdGhlIGV4dHJhIGRlY2xhcmF0aW9ucyBvbiBtNjhrIGFu ZCB4ODYgdGhhdCB3ZXJlIGFkZGVkIGFzIGxvY2FsCiAgICB3b3JrYXJvdW5kcyBhbHJlYWR5Lgog ICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKCkkg bWFkZSB0aGUgc2FtZSBtaXN0YWtlIHdpdGggdGhlICJhcmNoOiBhZGQgZG9fcGFnZV9mYXVsdCBw cm90b3R5cGVzIgpwYXRjaCB0aGF0IHdhcyBtaXNzaW5nIGFuIGV4cGxhbmF0aW9uLgoKICAgICAg QXJuZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3C32C4167D for ; Wed, 8 Nov 2023 21:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bpJI6jBCHNMNlBvwR8CsRZuLO4y1nlFcdiASGCKm+BY=; b=3Gf2zdjyK87J2d xCkmP6tVsRTrrwn6fB37SfznG/YhYZ8fhx0UiaBI4bRsmMo8CHN7YHoXfjVh1+X3vwbbbepovp56d AS6xrwU3+qKk13KAk+YSm8ukVmftqEal1ZfWVP0aN/kO9/wyve0XeYTJ68AgALYgjPlAUlsuz4Px0 AUWeXJ6XmifzFLcc9iLtCOmP7kLjOoyyNsaqngGN1fLIvmc5M/ixlgAqgm4SL15teir6jdxbNGgOw GZpYscfWjC539vmOiBphML/jKpTIt6fZstUbmvnHrwVVlXOIMV/VZ4qd4LZzFLRSTVxUW0B0SrpgK rlbVuPsNYjI0vhlQgUag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmH-004kaL-1u; Wed, 08 Nov 2023 21:07:57 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmC-004kXU-1X; Wed, 08 Nov 2023 21:07:54 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A16D580918; Wed, 8 Nov 2023 16:07:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=FzEkiJbbsOcjeyoGRwxvz+27m/0EEN52kEtbmSfnSLxjsunhTiL NfUpLQ2lMaNQM96rJSWMhX1vu2lvWTmYQ+94rPQoTRikLBiEjVkhx122mvhBFjKQ U5TGFlasJtrQz1D7CH1hVXq/4CUXHEmC0SXgOgbsxsmqVBXPjJ6IiWR1L/VYLFZD XaGxAnAinQklWeTyoPeeAGtYUUQIZX8H/zBze0un/GO9mbGPspFKceZcmPF+unL4 kNNYqyz4Nnv3vLyDQfTWJAwW2so0MUevk7DJxqisp5Xl7R8/m+axDeNitBypskfX D8Rsn3kpcQJ2fu6hUerp+k7/Bpi8xmjAE2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=LmqNAy3jRW8lY5IcykLYM+OvjkcYQjDv2Cd5j1qdrakTjXXA/j+ /E3SAMCFGeXJAd+vBXJDuwGp38C0j3EBw7K0I7TFk+KdegquYjjlo+2qe+Ss6fEx vTFJPMC1jaxZ1RiQPNLyTH4/PtfJEIBJRBDr+VVRztDGI1MBoVaVcWj5nK9n57lT IBiw5NhM15aVUl9nTNk4GEH/jjyPtDc5nRFt1GtJMHbfoOK2CNQf2Dsq4mugP1kK dALzlNsXk+kultkDq6XTINxe/wKYr9lcblw8RuAMeZQf5KYd1CJy2yk9Lj+caD2x oxDrnMalA2nkjbwEcTlCPYvCvjr0Nrwhw/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, "Masahiro Yamada" , linux-kbuild@vger.kernel.org, "Matt Turner" , "Vineet Gupta" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , guoren , "Peter Zijlstra" , "Ard Biesheuvel" , "Huacai Chen" , "Greg Ungerer" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Geoff Levand" , "Palmer Dabbelt" , "Heiko Carstens" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andy Lutomirski" , "Thomas Gleixner" , "Ingo Molnar" , x86@kernel.org, "Helge Deller" , "Sudip Mukherjee" , "Greg Kroah-Hartman" , "Timur Tabi" , "Kent Overstreet" , "David Woodhouse" , "Naveen N. Rao" , "Anil S Keshavamurthy" , "Kees Cook" , "Vincenzo Frascino" , "Juri Lelli" , "Vincent Guittot" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" , "Alexander Viro" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Netdev , linux-parisc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "linux-bcachefs@vger.kernel.org" , linux-mtd@lists.infradead.org Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_130752_583464_7B95B6C7 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgOCwgMjAyMywgYXQgMjE6NDIsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToK Pgo+IE9uIFdlZCwgTm92IDgsIDIwMjMgYXQgMjowMeKAr1BNIEFybmQgQmVyZ21hbm4gPGFybmRA a2VybmVsLm9yZz4gd3JvdGU6Cj4+IEZyb206IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+ Cj4+Cj4+IE1pY3JvYmxhemUgcnVucyBpbnRvIGEgc2luZ2xlIC1XbWlzc2luZy1wcm90b3R5cGVz IHdhcm5pbmcgd2hlbiB0aGF0IGlzCj4+IGVuYWJsZWQ6Cj4+Cj4+IGFyY2gvbWljcm9ibGF6ZS9r ZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0 cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90eXBlc10KPj4KPj4gSW5jbHVkZSB0aGUgcmlnaHQg aGVhZGVyIHRvIGF2b2lkIHRoaXMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVyZ21hbm4g PGFybmRAYXJuZGIuZGU+Cj4KPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4KPj4gIGFyY2gvYWxw aGEva2VybmVsL3RyYXBzLmMgICAgICB8IDEgKwo+PiAgYXJjaC9jc2t5L2luY2x1ZGUvYXNtL3Ry YXBzLmggIHwgMiAtLQo+PiAgYXJjaC9jc2t5L2tlcm5lbC90cmFwcy5jICAgICAgIHwgMSArCj4+ ICBhcmNoL202OGsvY29sZGZpcmUvdmVjdG9ycy5jICAgfCAzICstLQo+PiAgYXJjaC9tNjhrL2Nv bGRmaXJlL3ZlY3RvcnMuaCAgIHwgMyAtLS0KPgo+IEFoLCBzbyB0aGlzIGlzIHdoZXJlIHRoZSBt NjhrIGNoYW5nZXMgbGlzdGVkIGluIHRoZSBjb3ZlciBsZXR0ZXIgYXJlCj4gaGlkaW5nIDstKQo+ Cj4+ICBhcmNoL21pY3JvYmxhemUva2VybmVsL3RyYXBzLmMgfCAxICsKPj4gIGFyY2gvc3BhcmMv a2VybmVsL3RyYXBzXzMyLmMgICB8IDEgKwo+PiAgYXJjaC9zcGFyYy9rZXJuZWwvdHJhcHNfNjQu YyAgIHwgMSArCj4+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS90cmFwcy5oICAgfCAxIC0KPj4gIGFy Y2gveDg2L2tlcm5lbC90cmFwcy5jICAgICAgICB8IDEgKwo+PiAgMTAgZmlsZXMgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+PiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGFy Y2gvbTY4ay9jb2xkZmlyZS92ZWN0b3JzLmgKPgo+IE9idmlvdXNseSB0aGUgbm9uLW1pY3JvYmxh emUgY2hhbmdlcyBzaG91bGQgYmUgc3B1biBvZmYgaW4gc2VwYXJhdGUKPiBwYXRjaGVzLgoKSSBt ZXNzZWQgdXAgb25lIG9mIG15IHJlYmFzZXMgaGVyZSBhbmQgYWNjaWRlbnRhbGx5IHNlbnQKdGhl IHdyb25nIGNoYW5nZWxvZyB0ZXh0LiBNeSBpbnRlbnRpb24gd2FzIHRvIGhhdmUgdGhlCmNvbWJp bmVkIHBhdGNoIGJ1dCB3aXRoIHRoaXMgdGV4dDoKCiAgICBhcmNoOiBpbmNsdWRlIGxpbnV4L2Nw dS5oIGZvciB0cmFwX2luaXQoKSBwcm90b3R5cGUKICAgIAogICAgc29tZSBhcmNoaXRlY3R1cmVz IHJ1biBpbnRvIGEgLVdtaXNzaW5nLXByb3RvdHlwZXMgd2FybmluZwogICAgZm9yIHRyYXBfaW5p dCgpCiAgICAKICAgIGFyY2gvbWljcm9ibGF6ZS9rZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5n OiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90 eXBlc10KICAgIAogICAgSW5jbHVkZSB0aGUgcmlnaHQgaGVhZGVyIHRvIGF2b2lkIHRoaXMgY29u c2lzdGVudGx5LCByZW1vdmluZwogICAgdGhlIGV4dHJhIGRlY2xhcmF0aW9ucyBvbiBtNjhrIGFu ZCB4ODYgdGhhdCB3ZXJlIGFkZGVkIGFzIGxvY2FsCiAgICB3b3JrYXJvdW5kcyBhbHJlYWR5Lgog ICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKCkkg bWFkZSB0aGUgc2FtZSBtaXN0YWtlIHdpdGggdGhlICJhcmNoOiBhZGQgZG9fcGFnZV9mYXVsdCBw cm90b3R5cGVzIgpwYXRjaCB0aGF0IHdhcyBtaXNzaW5nIGFuIGV4cGxhbmF0aW9uLgoKICAgICAg QXJuZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86564C4332F for ; Wed, 8 Nov 2023 21:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1ucposfwEkiqfPtU4YD3jN5/PuizSBeV8sSmV7gZM3Y=; b=wQDfygvxszImEz BDOK/R2dFqjhQGeKJNVurbaprg/QUHijBH2zsdGyxN2PMR6NNJkxtfT1yUtMwu9r9CMvCDxC7Kafx 5lKDxlmA2CYsJbzm0vGMFuui+XLVioc6wDK4Very7g+yRL5m2Jud6qNs4IdvRnQPGx21PZw5mNiA8 H7wlzaFTpGYlRDipnsPs0FWrOf7OHtAYr4+wLHeDm66iEYw7M93MlhHyGBsQZeNjZb+vjztdyxS3y j5H892CcpTRtxFTbDkTD2di63XhYQ0mcse9whTpraUnZ3fweObY/X8uMFarcgRxTi0XaQXTGLXFVm QjqBpob3db9LRb+AB3cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmI-004kaj-0e; Wed, 08 Nov 2023 21:07:58 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0pmC-004kXU-1X; Wed, 08 Nov 2023 21:07:54 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A16D580918; Wed, 8 Nov 2023 16:07:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=FzEkiJbbsOcjeyoGRwxvz+27m/0EEN52kEtbmSfnSLxjsunhTiL NfUpLQ2lMaNQM96rJSWMhX1vu2lvWTmYQ+94rPQoTRikLBiEjVkhx122mvhBFjKQ U5TGFlasJtrQz1D7CH1hVXq/4CUXHEmC0SXgOgbsxsmqVBXPjJ6IiWR1L/VYLFZD XaGxAnAinQklWeTyoPeeAGtYUUQIZX8H/zBze0un/GO9mbGPspFKceZcmPF+unL4 kNNYqyz4Nnv3vLyDQfTWJAwW2so0MUevk7DJxqisp5Xl7R8/m+axDeNitBypskfX D8Rsn3kpcQJ2fu6hUerp+k7/Bpi8xmjAE2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=LmqNAy3jRW8lY5IcykLYM+OvjkcYQjDv2Cd5j1qdrakTjXXA/j+ /E3SAMCFGeXJAd+vBXJDuwGp38C0j3EBw7K0I7TFk+KdegquYjjlo+2qe+Ss6fEx vTFJPMC1jaxZ1RiQPNLyTH4/PtfJEIBJRBDr+VVRztDGI1MBoVaVcWj5nK9n57lT IBiw5NhM15aVUl9nTNk4GEH/jjyPtDc5nRFt1GtJMHbfoOK2CNQf2Dsq4mugP1kK dALzlNsXk+kultkDq6XTINxe/wKYr9lcblw8RuAMeZQf5KYd1CJy2yk9Lj+caD2x oxDrnMalA2nkjbwEcTlCPYvCvjr0Nrwhw/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, "Masahiro Yamada" , linux-kbuild@vger.kernel.org, "Matt Turner" , "Vineet Gupta" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , guoren , "Peter Zijlstra" , "Ard Biesheuvel" , "Huacai Chen" , "Greg Ungerer" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Geoff Levand" , "Palmer Dabbelt" , "Heiko Carstens" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andy Lutomirski" , "Thomas Gleixner" , "Ingo Molnar" , x86@kernel.org, "Helge Deller" , "Sudip Mukherjee" , "Greg Kroah-Hartman" , "Timur Tabi" , "Kent Overstreet" , "David Woodhouse" , "Naveen N. Rao" , "Anil S Keshavamurthy" , "Kees Cook" , "Vincenzo Frascino" , "Juri Lelli" , "Vincent Guittot" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" , "Alexander Viro" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Netdev , linux-parisc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "linux-bcachefs@vger.kernel.org" , linux-mtd@lists.infradead.org Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_130752_583464_7B95B6C7 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgOCwgMjAyMywgYXQgMjE6NDIsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToK Pgo+IE9uIFdlZCwgTm92IDgsIDIwMjMgYXQgMjowMeKAr1BNIEFybmQgQmVyZ21hbm4gPGFybmRA a2VybmVsLm9yZz4gd3JvdGU6Cj4+IEZyb206IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+ Cj4+Cj4+IE1pY3JvYmxhemUgcnVucyBpbnRvIGEgc2luZ2xlIC1XbWlzc2luZy1wcm90b3R5cGVz IHdhcm5pbmcgd2hlbiB0aGF0IGlzCj4+IGVuYWJsZWQ6Cj4+Cj4+IGFyY2gvbWljcm9ibGF6ZS9r ZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0 cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90eXBlc10KPj4KPj4gSW5jbHVkZSB0aGUgcmlnaHQg aGVhZGVyIHRvIGF2b2lkIHRoaXMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVyZ21hbm4g PGFybmRAYXJuZGIuZGU+Cj4KPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4KPj4gIGFyY2gvYWxw aGEva2VybmVsL3RyYXBzLmMgICAgICB8IDEgKwo+PiAgYXJjaC9jc2t5L2luY2x1ZGUvYXNtL3Ry YXBzLmggIHwgMiAtLQo+PiAgYXJjaC9jc2t5L2tlcm5lbC90cmFwcy5jICAgICAgIHwgMSArCj4+ ICBhcmNoL202OGsvY29sZGZpcmUvdmVjdG9ycy5jICAgfCAzICstLQo+PiAgYXJjaC9tNjhrL2Nv bGRmaXJlL3ZlY3RvcnMuaCAgIHwgMyAtLS0KPgo+IEFoLCBzbyB0aGlzIGlzIHdoZXJlIHRoZSBt NjhrIGNoYW5nZXMgbGlzdGVkIGluIHRoZSBjb3ZlciBsZXR0ZXIgYXJlCj4gaGlkaW5nIDstKQo+ Cj4+ICBhcmNoL21pY3JvYmxhemUva2VybmVsL3RyYXBzLmMgfCAxICsKPj4gIGFyY2gvc3BhcmMv a2VybmVsL3RyYXBzXzMyLmMgICB8IDEgKwo+PiAgYXJjaC9zcGFyYy9rZXJuZWwvdHJhcHNfNjQu YyAgIHwgMSArCj4+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS90cmFwcy5oICAgfCAxIC0KPj4gIGFy Y2gveDg2L2tlcm5lbC90cmFwcy5jICAgICAgICB8IDEgKwo+PiAgMTAgZmlsZXMgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+PiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGFy Y2gvbTY4ay9jb2xkZmlyZS92ZWN0b3JzLmgKPgo+IE9idmlvdXNseSB0aGUgbm9uLW1pY3JvYmxh emUgY2hhbmdlcyBzaG91bGQgYmUgc3B1biBvZmYgaW4gc2VwYXJhdGUKPiBwYXRjaGVzLgoKSSBt ZXNzZWQgdXAgb25lIG9mIG15IHJlYmFzZXMgaGVyZSBhbmQgYWNjaWRlbnRhbGx5IHNlbnQKdGhl IHdyb25nIGNoYW5nZWxvZyB0ZXh0LiBNeSBpbnRlbnRpb24gd2FzIHRvIGhhdmUgdGhlCmNvbWJp bmVkIHBhdGNoIGJ1dCB3aXRoIHRoaXMgdGV4dDoKCiAgICBhcmNoOiBpbmNsdWRlIGxpbnV4L2Nw dS5oIGZvciB0cmFwX2luaXQoKSBwcm90b3R5cGUKICAgIAogICAgc29tZSBhcmNoaXRlY3R1cmVz IHJ1biBpbnRvIGEgLVdtaXNzaW5nLXByb3RvdHlwZXMgd2FybmluZwogICAgZm9yIHRyYXBfaW5p dCgpCiAgICAKICAgIGFyY2gvbWljcm9ibGF6ZS9rZXJuZWwvdHJhcHMuYzoyMTo2OiB3YXJuaW5n OiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0cmFwX2luaXQnIFstV21pc3NpbmctcHJvdG90 eXBlc10KICAgIAogICAgSW5jbHVkZSB0aGUgcmlnaHQgaGVhZGVyIHRvIGF2b2lkIHRoaXMgY29u c2lzdGVudGx5LCByZW1vdmluZwogICAgdGhlIGV4dHJhIGRlY2xhcmF0aW9ucyBvbiBtNjhrIGFu ZCB4ODYgdGhhdCB3ZXJlIGFkZGVkIGFzIGxvY2FsCiAgICB3b3JrYXJvdW5kcyBhbHJlYWR5Lgog ICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKCkkg bWFkZSB0aGUgc2FtZSBtaXN0YWtlIHdpdGggdGhlICJhcmNoOiBhZGQgZG9fcGFnZV9mYXVsdCBw cm90b3R5cGVzIgpwYXRjaCB0aGF0IHdhcyBtaXNzaW5nIGFuIGV4cGxhbmF0aW9uLgoKICAgICAg QXJuZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBz LWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF368C4167D for ; Wed, 8 Nov 2023 22:05:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm3 header.b=32beSgpe; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=kjlV4oVb; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SQfKH2S04z3w8X for ; Thu, 9 Nov 2023 09:05:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm3 header.b=32beSgpe; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=kjlV4oVb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=66.111.4.230; helo=new4-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=lists.ozlabs.org) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SQd2m1lFtz2yGF for ; Thu, 9 Nov 2023 08:07:43 +1100 (AEDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 15DEC5808D9; Wed, 8 Nov 2023 16:07:40 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477660; x=1699484860; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=32beSgpe4JW/41MI9lwE9Ijo4clBZDCZcdz5W29GlXfmeBdloGs Pj6zClFpI3rBEASL5bt2BJ0z9kSHXoRmNM9S3ZUV9IpU6H2SlzHeojjwyK38ubdm rc5I6AbHQO428z+GTudTpXj84wN1iHyD5B4xrh7Xg9+/lOsXO8mWGmiOw0oEtT95 59tIeWQXJ0PMlmbTe9oPGJNjvuF2Q00g7Aup3KvWuYCehPghEdVuK62ANt1RCDNX P59SJAJQv8a5rR+mmaJ00cjQiQKIVXVSq/NkJ5Ceh2lpGohzfDFoxucwi0IF29D/ 556O8j5asu9BGmdizp+cE+MTUaFBWLNaDZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477660; x=1699484860; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=kjlV4oVb2NP4EXVJD0KYm4LTALqMkDnrU92/a5IM2DxqbQWjsi+ IwdXxoSa3WEs4VZrlHH4JbCKkIL0G8Pwij1126xSe7hG/IMqOBcu3RQxvqgsEHsb pcFM0Ua1NE3OwtwEsNMc4jlmhSYjBeK+x0Ed/W7Rlf03UIZVqr2B+d0ryicP7Tub QSkOlA0efMsPA3XcbslixipIgl/+8P6M15YEgB0c0t6f8ouEUKSI2KL0MYB9RUr3 hoiEAHdJCFrsG/Y/a3llxHIutnrnDvRz3cIbj7RF5co+2MINYEdgACq/D/uqzlpo r0L8iW3NWB7AxkztwyKFHjpLOPBdYiLEhJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 09 Nov 2023 08:41:16 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , linux-fbdev@vger.kernel.org, x86@kernel.org, loongarch@lists.linux.dev, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Netdev , guoren , Anil S Keshavamurthy , Helge Deller , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Vincenzo Frascino , Will Deacon , Ard Biesheuvel , Nicolas Schier , linux-s390@vger.kernel.org, Vincent Guittot , Masahiro Yamada , Huacai Chen , Russell King , Greg Ungerer , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , V ineet Gupta , "Naveen N. Rao" , Matt Turner , linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, Kees Cook , linux-kbuild@vger.kernel.org, Heiko Carstens , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Nathan Chancellor , linux-m68k@lists.linux-m68k.org, "linux-csky@vger.kernel.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Michal Simek , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Over street , Nick Desaulniers , linux-kernel@vger.kernel.org, Sudip Mukherjee , Dinh Nguyen , linux-usb@vger.kernel.org, Palmer Dabbelt , Masami Hiramatsu , linux-alpha@vger.kernel.org, linux-mtd@lists.infradead.org, Andrew Morton , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01=E2=80=AFPM Arnd Bergmann = wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that = is >> enabled: >> >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype f= or 'trap_init' [-Wmissing-prototypes] >> >> Include the right header to avoid this. >> >> Signed-off-by: Arnd Bergmann > > Thanks for your patch! > >> arch/alpha/kernel/traps.c | 1 + >> arch/csky/include/asm/traps.h | 2 -- >> arch/csky/kernel/traps.c | 1 + >> arch/m68k/coldfire/vectors.c | 3 +-- >> arch/m68k/coldfire/vectors.h | 3 --- > > Ah, so this is where the m68k changes listed in the cover letter are > hiding ;-) > >> arch/microblaze/kernel/traps.c | 1 + >> arch/sparc/kernel/traps_32.c | 1 + >> arch/sparc/kernel/traps_64.c | 1 + >> arch/x86/include/asm/traps.h | 1 - >> arch/x86/kernel/traps.c | 1 + >> 10 files changed, 7 insertions(+), 8 deletions(-) >> delete mode 100644 arch/m68k/coldfire/vectors.h > > Obviously the non-microblaze changes should be spun off in separate > patches. I messed up one of my rebases here and accidentally sent the wrong changelog text. My intention was to have the combined patch but with this text: arch: include linux/cpu.h for trap_init() prototype =20 some architectures run into a -Wmissing-prototypes warning for trap_init() =20 arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype = for 'trap_init' [-Wmissing-prototypes] =20 Include the right header to avoid this consistently, removing the extra declarations on m68k and x86 that were added as local workarounds already. =20 Signed-off-by: Arnd Bergmann I made the same mistake with the "arch: add do_page_fault prototypes" patch that was missing an explanation. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A47E4C4167B for ; Wed, 8 Nov 2023 21:07:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFDEB10E85B; Wed, 8 Nov 2023 21:07:46 +0000 (UTC) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 250D610E85B for ; Wed, 8 Nov 2023 21:07:43 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A16D580918; Wed, 8 Nov 2023 16:07:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=FzEkiJbbsOcjeyoGRwxvz+27m/0EEN52kEtbmSfnSLxjsunhTiL NfUpLQ2lMaNQM96rJSWMhX1vu2lvWTmYQ+94rPQoTRikLBiEjVkhx122mvhBFjKQ U5TGFlasJtrQz1D7CH1hVXq/4CUXHEmC0SXgOgbsxsmqVBXPjJ6IiWR1L/VYLFZD XaGxAnAinQklWeTyoPeeAGtYUUQIZX8H/zBze0un/GO9mbGPspFKceZcmPF+unL4 kNNYqyz4Nnv3vLyDQfTWJAwW2so0MUevk7DJxqisp5Xl7R8/m+axDeNitBypskfX D8Rsn3kpcQJ2fu6hUerp+k7/Bpi8xmjAE2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=LmqNAy3jRW8lY5IcykLYM+OvjkcYQjDv2Cd5j1qdrakTjXXA/j+ /E3SAMCFGeXJAd+vBXJDuwGp38C0j3EBw7K0I7TFk+KdegquYjjlo+2qe+Ss6fEx vTFJPMC1jaxZ1RiQPNLyTH4/PtfJEIBJRBDr+VVRztDGI1MBoVaVcWj5nK9n57lT IBiw5NhM15aVUl9nTNk4GEH/jjyPtDc5nRFt1GtJMHbfoOK2CNQf2Dsq4mugP1kK dALzlNsXk+kultkDq6XTINxe/wKYr9lcblw8RuAMeZQf5KYd1CJy2yk9Lj+caD2x oxDrnMalA2nkjbwEcTlCPYvCvjr0Nrwhw/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , linux-fbdev@vger.kernel.org, x86@kernel.org, loongarch@lists.linux.dev, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Netdev , guoren , Anil S Keshavamurthy , Helge Deller , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Vincenzo Frascino , Will Deacon , Ard Biesheuvel , Nicolas Schier , linux-s390@vger.kernel.org, Vincent Guittot , Michael Ellerman , Masahiro Yamada , Huacai Chen , Russell King , Christophe Leroy , Greg Ungerer , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, Kees Cook , linux-kbuild@vger.kernel.org, Heiko Carstens , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Nathan Chancellor , linux-m68k@lists.linux-m68k.org, "linux-csky@vger.kernel.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Michal Simek , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , linux-kernel@vger.kernel.org, Sudip Mukherjee , Dinh Nguyen , linux-usb@vger.kernel.org, Palmer Dabbelt , Masami Hiramatsu , linux-alpha@vger.kernel.org, linux-mtd@lists.infradead.org, Andrew Morton , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01=E2=80=AFPM Arnd Bergmann = wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that = is >> enabled: >> >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype f= or 'trap_init' [-Wmissing-prototypes] >> >> Include the right header to avoid this. >> >> Signed-off-by: Arnd Bergmann > > Thanks for your patch! > >> arch/alpha/kernel/traps.c | 1 + >> arch/csky/include/asm/traps.h | 2 -- >> arch/csky/kernel/traps.c | 1 + >> arch/m68k/coldfire/vectors.c | 3 +-- >> arch/m68k/coldfire/vectors.h | 3 --- > > Ah, so this is where the m68k changes listed in the cover letter are > hiding ;-) > >> arch/microblaze/kernel/traps.c | 1 + >> arch/sparc/kernel/traps_32.c | 1 + >> arch/sparc/kernel/traps_64.c | 1 + >> arch/x86/include/asm/traps.h | 1 - >> arch/x86/kernel/traps.c | 1 + >> 10 files changed, 7 insertions(+), 8 deletions(-) >> delete mode 100644 arch/m68k/coldfire/vectors.h > > Obviously the non-microblaze changes should be spun off in separate > patches. I messed up one of my rebases here and accidentally sent the wrong changelog text. My intention was to have the combined patch but with this text: arch: include linux/cpu.h for trap_init() prototype =20 some architectures run into a -Wmissing-prototypes warning for trap_init() =20 arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype = for 'trap_init' [-Wmissing-prototypes] =20 Include the right header to avoid this consistently, removing the extra declarations on m68k and x86 that were added as local workarounds already. =20 Signed-off-by: Arnd Bergmann I made the same mistake with the "arch: add do_page_fault prototypes" patch that was missing an explanation. Arnd