From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C31B9C77B7F for ; Thu, 11 May 2023 08:03:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8AD0C846B5; Thu, 11 May 2023 10:03:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kcN6QqOF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 39FE984763; Thu, 11 May 2023 10:03:33 +0200 (CEST) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E9D0484679 for ; Thu, 11 May 2023 10:03:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9661047f8b8so1099051466b.0 for ; Thu, 11 May 2023 01:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683792210; x=1686384210; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xmQXOmKrAC5Sa1k0TDwtHg2bG03jrU6n9CqzWc8DGLs=; b=kcN6QqOFmiDyK/Ux2kTlEdMhnTY6AfGlkJxit06966iHIt3xudEHlZkLGYLioI5tAf 6Elp1mbn28q7HhW7UQlUHgqa0whCQsuU/oh7E0tT7krRBvig8ik5/aOMnsf1YJU6c2Wl NkdM5/RrXyRj9gkLy63iSOvxx9PmyKWpVgnF7uLeP3y46z/nASx2UIcF5ypEkv07mIf3 YYgBIYLLraNxSeznCE0hyWuuR4Uy4O64zFTSigDbZhmonr4Lllh/f1OYW9NUdP0Ry6Bq SF4O+E7e7MV9R9vdOIo+JN0dLE6ZXxuA7ukfntiy+zzIJrAnCLRPpFBI+AJDQJui7UGb Dp7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683792210; x=1686384210; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xmQXOmKrAC5Sa1k0TDwtHg2bG03jrU6n9CqzWc8DGLs=; b=dvAnDz3+haUsX0mwXbAEgLYCQHhQVRAdFPuK5+dVVXHlEtsmQtneeZftkm1v11+psa fNXr97o1ckMhBWZ/pDrvDAmxKCCeEwQegSOO8fl790ryXvulxtm1ZPu6+HnZ6gcw1uyZ 9aF58N489KKT3YcNwWJHgXTTehnlTL7QSjfcbFaHzDjP6SqhiL1ubzxKSjKv3/jp/MW0 Y6qWcGe+EYWK6nsG7Aoz8TV/5FavUAznHkYw+dL7AW1/fqzu+IChY8Cfj5YJvZjlura9 MhV8sRlwLclChnmc1sLPr84BTN2kFa+ztRQFDL+4AwSaNYgF0HqPCnjtOJ3OqR3Eng7f TSrA== X-Gm-Message-State: AC+VfDwASeNzPHr53KZoJtrvugJBnoPUU+FKbjj8WI7a0kQ6hNNW1S27 kjnW8jbKEAKkSRteCBLV5no= X-Google-Smtp-Source: ACHHUZ5m/YqNW2VmQc1aN/Ja6KBJRY0TpvABnsTMFr/xNGwaWf0qht3IS+xDjhIxb/4NIlCKU0DQwA== X-Received: by 2002:a17:907:a424:b0:96a:246b:c65d with SMTP id sg36-20020a170907a42400b0096a246bc65dmr5381690ejc.12.1683792210104; Thu, 11 May 2023 01:03:30 -0700 (PDT) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id my14-20020a1709065a4e00b0096643397aeesm3650149ejc.184.2023.05.11.01.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 01:03:29 -0700 (PDT) Message-ID: Date: Thu, 11 May 2023 10:03:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v10] core: fdtaddr: use map_sysmem() as cast for the return (part 2) To: Kever Yang , sjg@chromium.org Cc: philipp.tomsich@vrull.eu, u-boot@lists.denx.de References: <11826a88-6d4a-20a1-0651-b7e2fe79cbe5@rock-chips.com> Content-Language: en-US From: Johan Jonker In-Reply-To: <11826a88-6d4a-20a1-0651-b7e2fe79cbe5@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/11/23 09:12, Kever Yang wrote: > Hi Johan, > >     The patch v9 has merged, it will be better to send a new patch if more change needed, Merging logic with 2 maintainers... This is a separate new patch for Simon. He applied that (part 1) first, then the nfc serie was merged. And now I must fix the lines that Simon removed to be complete..... See comment: https://lore.kernel.org/u-boot/11826a88-6d4a-20a1-0651-b7e2fe79cbe5@rock-chips.com/T/#mf603b1a5cdaa6612ff71674d76d4f7ff49c21a2a Comment by Simon: I had to drop the second hunk here since it conflicted and it looks like it was already done upstream. Please take a look and send a follow-up patch if needed. Please have a look. Johan > > but not a v10 patch. > > > Thanks, > > - Kever > > On 2023/5/11 05:48, Johan Jonker wrote: >> For the devfdt_get_addr_size_index_ptr() function use >> map_sysmem() function as cast for the return for use in >> sandbox. >> >> Signed-off-by: Johan Jonker >> --- >>   drivers/core/fdtaddr.c | 5 ++++- >>   1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/core/fdtaddr.c b/drivers/core/fdtaddr.c >> index 3b59b70c..546db675 100644 >> --- a/drivers/core/fdtaddr.c >> +++ b/drivers/core/fdtaddr.c >> @@ -131,7 +131,10 @@ void *devfdt_get_addr_size_index_ptr(const struct udevice *dev, int index, >>   { >>       fdt_addr_t addr = devfdt_get_addr_size_index(dev, index, size); >> >> -    return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)(uintptr_t)addr; >> +    if (addr == FDT_ADDR_T_NONE) >> +        return NULL; >> + >> +    return map_sysmem(addr, 0); >>   } >> >>   fdt_addr_t devfdt_get_addr_name(const struct udevice *dev, const char *name) >> -- >> 2.20.1 >>