Re: [Intel-gfx] [PATCH] drm/i915/dgfx: Disable d3cold Correctly

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Luca Coelho <luca@coelho.fi>
> Sent: Monday, June 6, 2022 7:53 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dgfx: Disable d3cold Correctly
> 
> On Mon, 2022-06-06 at 17:56 +0530, Anshuman Gupta wrote:
> > Currently i915 disables d3cold for i915 pci dev.
> > This blocks D3 for i915 gfx pci upstream bridge (VSP).
> > Let's disable d3cold at gfx root port to make sure that
> > i915 gfx VSP can transition to D3 to save some power.
> 
> (nit) It's better to use imperative in the commit message, so "Disable d3cold at
> gfx root port..." would be easier to read.
Thanks for comment, i will fix this,
> 
> Also, from the code, it's clear that you're disabling d3cold in the root now,
> instead of in the pdev itself.  But you don't explain why you moved the
> enabling/disabling to hw_probe and remove_hw from the actual PM calls...
We don't need to disable/enable root port d3cold multiple times in PM suspend handlers, doing this
in probe should be suffice.

Regards,
Anshuman Gupta.
> 
> --
> Cheers,
> Luca.