Re: [PATCH nf 0/5] netfilter: ipset fixes and rhastable prep work

[Jozsef Kadlecsik <kadlec@netfilter.org>]

Hi Florian,

On Thu, 30 Jul 2026, Florian Westphal wrote:

> https://sashiko.dev/#/patchset/20260730183853.21868-1-fw%40strlen.de
> 
> 'This is a pre-existing issue, but does asynchronous element destruction 
> in list_set_flush() race with this synchronous zeroing of set->ext_size, 
> causing an integer underflow?
> 
> If a user flushes a list:set ipset, list_set_flush() forces the counter to 0
> here. The elements are queued for asynchronous deletion via call_rcu() inside
> list_set_del().'
> 
> I will have another look at this to see if thats correct, in any case
> this should be handled in a different change.

I should have left out the call to atomic64_set(&set->ext_size, 0) in 
list_set_flush() and let the list_set_del() calls adjust the ext_size 
value. What do you thing, would it solve the issue?

Best regards,
Jozsef
-- 
E-mail : kadlec@netfilter.org, kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
Address: Wigner Research Centre for Physics
         H-1525 Budapest 114, POB. 49, Hungary