Re: [PATCH v2 1/3] drm/xe/guc: Compress GuC log and CTB dump with zstd

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

On 2026-05-28 1:51 p.m., Julia Filipchuk wrote:
> Minor comment for consideration. Changes to printing, stream compression look good.
> 
> Should replace 'pr_err' with 'xe_gt_err' as we use elsewhere. With this change.
Will fix it in next rev.>
> Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
Thanks for take time review it. I got offline review comments to have an 
kconfig to control this feature, new rev is on the way.

> 
> On 5/11/2026 12:49 PM, Zhanjun Dong wrote:
>> Replace the raw ascii85 dumps of GuC log snapshots with a
>> zstd-compressed ascii85 stream and reuse the same helper for CTB
>> snapshot output.
>>
>> Use zstd streaming with default level-3 parameters and an estimated
>> source size of 0 so the compression workspace stays bounded even for
>> multi-megabyte logs.
> 
> ...
> 
>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>> index 4d7dcaff2b91..a6fbd7233c09 100644
>> --- a/drivers/gpu/drm/xe/Kconfig
>> +++ b/drivers/gpu/drm/xe/Kconfig
>> @@ -33,6 +33,8 @@ config DRM_XE
>>   	select ACPI_WMI if X86 && ACPI
>>   	select SYNC_FILE
>>   	select CRC32
>> +	select ZSTD_COMPRESS
>> +	select ZSTD_DECOMPRESS
> 
> Decompress is not needed since we only intend to use compression. Possible that
> both are needed in kconfig.
> 
There are 2 zstd error related functions requires ZSTD_DECOMPRESS, maybe 
I can only output error code rather than error string to avoid select 
ZSTD_DECOMPRESS.

Regards,
Zhanjun Dong