All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Kees Cook <kees@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Kees Cook <keescook@chromium.org>,
	mhiramat@kernel.org, akpm@linux-foundation.org,
	masahiroy@kernel.org, paulmck@kernel.org, hannes@cmpxchg.org,
	ojeda@kernel.org, thunder.leizhen@huawei.com,
	christophe.leroy@csgroup.eu, vbabka@suse.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/Kconfig: extend -Wno-array-bounds to gcc 13
Date: Tue, 7 Mar 2023 05:28:53 -0800	[thread overview]
Message-ID: <e7eef530-16b8-0a5d-273d-98aa3f673e61@redhat.com> (raw)
In-Reply-To: <CANiq72kKmVzQYU7aOy4k0GsrgV=jfi_fLk2TvtWVGV_sXc8e2w@mail.gmail.com>


On 3/7/23 3:42 AM, Miguel Ojeda wrote:
> On Tue, Mar 7, 2023 at 2:07 AM Tom Rix <trix@redhat.com> wrote:
>> The build with fail generally with gcc 13.
>>
>> The warnings could be cleaned without having an error, but I looked at
>> multiple errors, none of them were real.
>>
>> imo this is a broken compiler option.
> I am not sure I understand -- my reading of Kees' message is that he
> would prefer to get the warning (rather than the kernel) fixed before
> GCC 13 releases.

yes, that would be ideal.

But anyone using gcc 13 in the meanwhile will have a broken build

and any other aspect of testing the kernel with gcc 13 would have

to be deferred to after the fix, if it happens.

>
> Are you asking to have the option disabled until GCC 13 releases and
> reevaluate then? How many warnings are you getting? Are those actual
> errors or `-Werror`?

With W=1, there are 40 error:'s, sorry I do not have the default logs at 
hand.

I looked about 10 of them over the weekend, they we all bogus.

So gcc needs to be fixed first, just disabling with -Wnoerror will

give folks bad problems that do not need fixing.


I am asking that we at least temporarily disable this option so

the build break is fixed.

Tom

>
> Cheers,
> Miguel
>


  reply	other threads:[~2023-03-07 13:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 22:09 [PATCH] init/Kconfig: extend -Wno-array-bounds to gcc 13 Tom Rix
2023-03-06 22:20 ` Nick Desaulniers
2023-03-06 23:02   ` Kees Cook
2023-03-07  1:07     ` Tom Rix
2023-03-07 11:42       ` Miguel Ojeda
2023-03-07 13:28         ` Tom Rix [this message]
2024-06-17 21:02 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7eef530-16b8-0a5d-273d-98aa3f673e61@redhat.com \
    --to=trix@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hannes@cmpxchg.org \
    --cc=kees@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.