All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: "Dr. David Alan Gilbert" <linux@treblig.org>,
	Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, kees@kernel.org
Subject: Re: Dead code by symbols
Date: Thu, 19 Sep 2024 10:13:26 +0200	[thread overview]
Message-ID: <e81d1f66-4ca7-4792-b505-581874c4c155@redhat.com> (raw)
In-Reply-To: <ZuqxpBRVSYIk1Hkm@gallifrey>

On 18.09.24 12:55, Dr. David Alan Gilbert wrote:
> * Christoph Hellwig (hch@infradead.org) wrote:
>> On Tue, Sep 17, 2024 at 01:39:35PM +0200, David Hildenbrand wrote:
>>>> Now, it does take some more guesswork, for example an unused function
>>>> which was added a couple of years back, might be something that's
>>>> there for consistency,
>>>
>>> I know people will find reasons to do something like that, but we really
>>> *shouldn't* be maintaining / dragging along dead code that nobody might ever
>>> use.
>>
>> There never is any reason to keep dead code around.
> 
> Yeh I mostly agree; and indeed I'll be sending many many patches to remove
> the bucket loads of dead code I find; but as I say, there's a really
> big variation from the dead-for-20 years, to relatively new, to
> functions that seem to make sense next to the file they're part of.
> So I'll get to those later, I'll get rid of the very dead ones first.

Makes sense to me. Thanks for doing that work, Dave!

-- 
Cheers,

David / dhildenb


      reply	other threads:[~2024-09-19  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 12:33 Dead code by symbols Dr. David Alan Gilbert
2024-09-17 11:39 ` David Hildenbrand
2024-09-17 12:15   ` Dr. David Alan Gilbert
2024-09-18  6:16   ` Christoph Hellwig
2024-09-18 10:55     ` Dr. David Alan Gilbert
2024-09-19  8:13       ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e81d1f66-4ca7-4792-b505-581874c4c155@redhat.com \
    --to=david@redhat.com \
    --cc=hch@infradead.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.