All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/boot: Remove unused sprintf()
Date: Fri, 31 Jul 2026 09:17:13 +0200	[thread overview]
Message-ID: <e85f28fb-47e2-424d-a527-786d4626e7fa@kernel.org> (raw)
In-Reply-To: <20260724172200.208722-2-thorsten.blum@linux.dev>



Le 24/07/2026 à 19:21, Thorsten Blum a écrit :
> There have been no sprintf() callers in the boot wrapper since commit
> e275e023aa69 ("powerpc/44x: Warp patches for the new NDFC driver").
> 
> Remove the function definition and declaration.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   arch/powerpc/boot/stdio.c | 11 -----------
>   arch/powerpc/boot/stdio.h |  3 ---
>   2 files changed, 14 deletions(-)
> 
> diff --git a/arch/powerpc/boot/stdio.c b/arch/powerpc/boot/stdio.c
> index 31eece29f56d..b12aa2c0b8e7 100644
> --- a/arch/powerpc/boot/stdio.c
> +++ b/arch/powerpc/boot/stdio.c
> @@ -326,17 +326,6 @@ int vsprintf(char *buf, const char *fmt, va_list args)
>   	return str-buf;
>   }
>   
> -int sprintf(char * buf, const char *fmt, ...)
> -{
> -	va_list args;
> -	int i;
> -
> -	va_start(args, fmt);
> -	i=vsprintf(buf,fmt,args);
> -	va_end(args);
> -	return i;
> -}
> -
>   static char sprint_buf[1024];
>   
>   int
> diff --git a/arch/powerpc/boot/stdio.h b/arch/powerpc/boot/stdio.h
> index 884d5959a9ae..d5a7a0f54453 100644
> --- a/arch/powerpc/boot/stdio.h
> +++ b/arch/powerpc/boot/stdio.h
> @@ -12,9 +12,6 @@ extern int printf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
>   
>   #define fprintf(fmt, args...)	printf(args)
>   
> -extern int sprintf(char *buf, const char *fmt, ...)
> -	__attribute__((format(printf, 2, 3)));
> -
>   extern int vsprintf(char *buf, const char *fmt, va_list args);
>   
>   #endif				/* _PPC_BOOT_STDIO_H_ */



      reply	other threads:[~2026-07-31  7:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 17:21 [PATCH] powerpc/boot: Remove unused sprintf() Thorsten Blum
2026-07-31  7:17 ` Christophe Leroy (CS GROUP) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e85f28fb-47e2-424d-a527-786d4626e7fa@kernel.org \
    --to=chleroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.