From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 29/32] drm/i915: Apply an execution_mask to the virtual_engine Date: Wed, 17 Apr 2019 13:35:29 +0100 Message-ID: References: <20190417075657.19456-1-chris@chris-wilson.co.uk> <20190417075657.19456-29-chris@chris-wilson.co.uk> <155550224960.2264.8613764785349543343@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A38D6E03E for ; Wed, 17 Apr 2019 12:35:31 +0000 (UTC) In-Reply-To: <155550224960.2264.8613764785349543343@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA0LzIwMTkgMTI6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA0LTE3IDEyOjQzOjQ5KQo+Pgo+PiBPbiAxNy8wNC8yMDE5IDA4OjU2 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBBbGxvdyB0aGUgdXNlciB0byBkaXJlY3Qgd2hpY2gg cGh5c2ljYWwgZW5naW5lcyBvZiB0aGUgdmlydHVhbCBlbmdpbmUKPj4+IHRoZXkgd2lzaCB0byBl eGVjdXRlIG9uZSwgYXMgc29tZXRpbWVzIGl0IGlzIG5lY2Vzc2FyeSB0byBvdmVycmlkZSB0aGUK Pj4+IGxvYWQgYmFsYW5jaW5nIGFsZ29yaXRobS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IC0tLQo+Pj4gICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMgICAgfCAgNTggKysrKysrKysrKysKPj4+ICAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X2xyYy5jIHwgMTMxICsrKysrKysrKysr KysrKysrKysrKysrKysKPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5j ICAgIHwgICAxICsKPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5oICAg IHwgICAzICsKPj4+ICAgIDQgZmlsZXMgY2hhbmdlZCwgMTkzIGluc2VydGlvbnMoKykKPj4+Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+Pj4gaW5kZXggZDZlZmQ2YWE2N2NiLi41 NjBhMThiYjRjYmIgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRl bF9scmMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPj4+ IEBAIC01NTIsNiArNTUyLDE4IEBAIGV4ZWNsaXN0c19jb250ZXh0X3NjaGVkdWxlX291dChzdHJ1 Y3QgaTkxNV9yZXF1ZXN0ICpycSwgdW5zaWduZWQgbG9uZyBzdGF0dXMpCj4+PiAgICAgICAgaW50 ZWxfZW5naW5lX2NvbnRleHRfb3V0KHJxLT5lbmdpbmUpOwo+Pj4gICAgICAgIGV4ZWNsaXN0c19j b250ZXh0X3N0YXR1c19jaGFuZ2UocnEsIHN0YXR1cyk7Cj4+PiAgICAgICAgdHJhY2VfaTkxNV9y ZXF1ZXN0X291dChycSk7Cj4+PiArCj4+PiArICAgICAvKgo+Pj4gKyAgICAgICogSWYgdGhpcyBp cyBwYXJ0IG9mIGEgdmlydHVhbCBlbmdpbmUsIGl0cyBuZXh0IHJlcXVlc3QgbWF5IGhhdmUKPj4+ ICsgICAgICAqIGJlZW4gYmxvY2tlZCB3YWl0aW5nIGZvciBhY2Nlc3MgdG8gdGhlIGFjdGl2ZSBj b250ZXh0LiBXZSBoYXZlCj4+PiArICAgICAgKiB0byBraWNrIGFsbCB0aGUgc2libGluZ3MgYWdh aW4gaW4gY2FzZSB3ZSBuZWVkIHRvIHN3aXRjaCAoZS5nLgo+Pj4gKyAgICAgICogdGhlIG5leHQg cmVxdWVzdCBpcyBub3QgcnVubmFibGUgb24gdGhpcyBlbmdpbmUpLiBIb3BlZnVsbHksCj4+PiAr ICAgICAgKiB3ZSB3aWxsIGFscmVhZHkgaGF2ZSBzdWJtaXR0ZWQgdGhlIG5leHQgcmVxdWVzdCBi ZWZvcmUgdGhlCj4+PiArICAgICAgKiB0YXNrbGV0IHJ1bnMgYW5kIGRvIG5vdCBuZWVkIHRvIHJl YnVpbGQgZWFjaCB2aXJ0dWFsIHRyZWUKPj4+ICsgICAgICAqIGFuZCBraWNrIGV2ZXJ5b25lIGFn YWluLgo+Pj4gKyAgICAgICovCj4+PiArICAgICBpZiAocnEtPmVuZ2luZSAhPSBycS0+aHdfY29u dGV4dC0+ZW5naW5lKQo+Pj4gKyAgICAgICAgICAgICB0YXNrbGV0X3NjaGVkdWxlKCZycS0+aHdf Y29udGV4dC0+ZW5naW5lLT5leGVjbGlzdHMudGFza2xldCk7Cj4+Cj4+IElzIHRoaXMgbmVlZGVk IG9ubHkgZm9yIG5vbi1kZWZhdWx0IGV4ZWN1dGlvbl9tYXNrPyBJZiBzbyBpdCB3b3VsZCBiZQo+ PiBnb29kIHRvIGxpbWl0IGl0IHRvIGF2b2lkIHRhc2tsZXQgc3Rvcm0gd2l0aCBwbGFpbiB2ZW5n Lgo+IAo+IFRoZSBpc3N1ZSBpcyBub3QganVzdCB3aXRoIHRoaXMgcnEgYnV0IHRoZSBuZXh0IG9u ZS4gSWYgdGhhdCBoYXMgYQo+IHJlc3RyaWN0ZWQgbWFzayB0aGF0IHByZXZlbnRzIGl0IHJ1bm5p bmcgb24gdGhpcyBlbmdpbmUsIHdlIG1heSBoYXZlCj4gbWlzc2VkIHRoZSBvcHBvcnR1bml0eSB0 byBxdWV1ZSBpdCAoYW5kIHNvIG5ldmVyIHJ1biBpdCB1bmRlciBqdXN0IHRoZQo+IHJpZ2h0IGNp cmN1bXN0YW5jZXMpLgo+IAo+IFNvbWV0aGluZyBsaWtlCj4gCXRvX3ZpcnR1YWxfZW5naW5lKHJx LT5od19jb250ZXh0LT5lbmdpbmUpLT5yZXF1ZXN0LT5leGVjdXRpb25fbWFzayAmIH5ycS0+ZXhl Y3V0aW9uX21hc2sKPiAKPiBUaGUgc3Rvcm0gaXNuJ3QgcXVpdGUgc28gYmFkLCBpdCdzIG9ubHkg b24gY29udGV4dC1vdXQsIGFuZCB3ZSBvZnRlbiBkbwo+IHN1Y2NlZWQgaW4ga2VlcGluZyBpdCBi dXN5LiBJIHdhcyBqdXN0IHRyeWluZyB0byBhdm9pZCBwdWxsaW5nIGluIHZlIGhlcmUuCgpXaGF0 IGRvIHlvdSBtZWFuIGJ5IHRoZSAicHVsbGluZyBpbiB2ZSIgYml0PyBBdm9pZGluZyB1c2luZyAK dG9fdmlydHVhbF9lbmdpbmUgbGlrZSBpbiB0aGUgbGluZSB5b3Ugd3JvdGUgYWJvdmU/Cgo+IAo+ Pj4gICAgc3RhdGljIHU2NCBleGVjbGlzdHNfdXBkYXRlX2NvbnRleHQoc3RydWN0IGk5MTVfcmVx dWVzdCAqcnEpCj4+PiBAQCAtNzc5LDYgKzc5MSw5IEBAIHN0YXRpYyBib29sIHZpcnR1YWxfbWF0 Y2hlcyhjb25zdCBzdHJ1Y3QgdmlydHVhbF9lbmdpbmUgKnZlLAo+Pj4gICAgewo+Pj4gICAgICAg IGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmFjdGl2ZTsKPj4+ICAgIAo+Pj4gKyAgICAg aWYgKCEocnEtPmV4ZWN1dGlvbl9tYXNrICYgZW5naW5lLT5tYXNrKSkgLyogV2UgcGVla2VkIHRv byBzb29uISAqLwo+Pj4gKyAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+PiArCj4+PiAgICAg ICAgLyoKPj4+ICAgICAgICAgKiBXZSB0cmFjayB3aGVuIHRoZSBIVyBoYXMgY29tcGxldGVkIHNh dmluZyB0aGUgY29udGV4dCBpbWFnZQo+Pj4gICAgICAgICAqIChpLmUuIHdoZW4gd2UgaGF2ZSBz ZWVuIHRoZSBmaW5hbCBDUyBldmVudCBzd2l0Y2hpbmcgb3V0IG9mCj4+PiBAQCAtMzEzOSwxMiAr MzE1NCw0NCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGludGVsX2NvbnRleHRfb3BzIHZpcnR1YWxf Y29udGV4dF9vcHMgPSB7Cj4+PiAgICAgICAgLmRlc3Ryb3kgPSB2aXJ0dWFsX2NvbnRleHRfZGVz dHJveSwKPj4+ICAgIH07Cj4+PiAgICAKPj4+ICtzdGF0aWMgaW50ZWxfZW5naW5lX21hc2tfdCB2 aXJ0dWFsX3N1Ym1pc3Npb25fbWFzayhzdHJ1Y3QgdmlydHVhbF9lbmdpbmUgKnZlKQo+Pj4gK3sK Pj4+ICsgICAgIHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxOwo+Pj4gKyAgICAgaW50ZWxfZW5naW5l X21hc2tfdCBtYXNrOwo+Pgo+PiBpbnRlbF9lbmdpbmVfbWFza190IHRocm91Z2hvdXQgaXMgdGhl IHdyb25nIHR5cGUgZm9yIHRoaXMsIGV2ZW4gaWYgd2UKPj4gZGlzYWxsb3dlZCBkdXBsaWNhdGUg c2libGluZ3MsIGFuZCBldmVuIG1vcmUgc28gaWYgd2UgZG9uJ3QuCj4gCj4gV2h5PyBJdCdzIGEg bWFzayBvZiBlbmdpbmUtPm1hc2sgKGFuZCBoYXMgdG8gYmUgb2YgdGhlIHBoeXNpY2FsIGlkIHRv Cj4gYWxsb3cgaXQgdG8gYmUgcG9zaXRpb24gaW52YXJpYW50IGluIHNpYmxpbmdzW10pLgo+ICAg Cj4+IEVpdGhlciB3YXkgaXQgc2VlbXMgbGlrZSB0aGUgNjQgc2libGluZyBsaW1pdCBuZWVkcyB0 byBiZSBiYWNrLiBPciBtYXliZQo+PiBvbmx5IGluIHRoZSBib25kaW5nIGNhc2U/Cj4gCj4gPwoK TXkgYmFkLiBJIG1pc3Rha2VubHkgdGhvdWdodCBleGVjdXRpb25fbWFzayByZWxhdGVzIHRvIHBv c2l0aW9uIG9mIAplbmdpbmVzIGluIHRoZSBzaWJsaW5ncyBhcnJheS4KCj4+Cj4+PiArCj4+PiAr ICAgICBycSA9IFJFQURfT05DRSh2ZS0+cmVxdWVzdCk7Cj4+PiArICAgICBpZiAoIXJxKQo+Pj4g KyAgICAgICAgICAgICByZXR1cm4gMDsKPj4+ICsKPj4+ICsgICAgIC8qIFRoZSBycSBpcyByZWFk eSBmb3Igc3VibWlzc2lvbjsgcnEtPmV4ZWN1dGlvbl9tYXNrIGlzIG5vdyBzdGFibGUuICovCj4+ PiArICAgICBtYXNrID0gcnEtPmV4ZWN1dGlvbl9tYXNrOwo+Pj4gKyAgICAgaWYgKHVubGlrZWx5 KCFtYXNrKSkgewo+Pj4gKyAgICAgICAgICAgICAvKiBJbnZhbGlkIHNlbGVjdGlvbiwgc3VibWl0 IHRvIGEgcmFuZG9tIGVuZ2luZSBpbiBlcnJvciAqLwo+Pj4gKyAgICAgICAgICAgICBpOTE1X3Jl cXVlc3Rfc2tpcChycSwgLUVOT0RFVik7Cj4+Cj4+IFdoZW4gY2FuIHRoaXMgaGFwcGVuPyBJdCBs b29rcyBsaWtlIGlmIGl0IGNhbiBoYXBwZW4gd2Ugc2hvdWxkIHJlamVjdCBpdAo+PiBlYXJsaWVy LiBPciBpZiBpdCBjYW4ndCB0aGVuIGp1c3QgYXNzZXJ0Lgo+IAo+IE1hbnkgc3VibWl0IGZlbmNl cyBjYW4gZW5kIHVwIHdpdGggYW4gaW50ZXJlc2VjdGlvbiBvZiAwLiBUaGlzIGlzIHRoZQo+IGNv bnZlbmllbnQgcG9pbnQgdG8gZG8gdGhlIHJlamVjdGlvbiwgYXMgd2l0aCBhbnkgb3RoZXIgYXN5 bmNocm9ub3VzCj4gZXJyb3IuCgpXaGljaCBvbmVzIGFyZSBtYW55PyBXaHkgd291bGQgd2UgaGF2 ZSB1QVBJIHdoaWNoIGFsbG93cyBzZXR0aW5nIAppbXBvc3NpYmxlIHRoaW5ncyB3aGVyZSBhbGwg cmVxdWVzdHMgd2lsbCBmYWlsIHdpdGggLUVOT0RFVj8KCj4gCj4+PiArICAgICAgICAgICAgIG1h c2sgPSB2ZS0+c2libGluZ3NbMF0tPm1hc2s7Cj4+PiArICAgICB9Cj4+PiArCj4+PiArICAgICBH RU1fVFJBQ0UoIiVzOiBycT0lbGx4OiVsbGQsIG1hc2s9JXgsIHByaW89JWRcbiIsCj4+PiArICAg ICAgICAgICAgICAgdmUtPmJhc2UubmFtZSwKPj4+ICsgICAgICAgICAgICAgICBycS0+ZmVuY2Uu Y29udGV4dCwgcnEtPmZlbmNlLnNlcW5vLAo+Pj4gKyAgICAgICAgICAgICAgIG1hc2ssIHZlLT5i YXNlLmV4ZWNsaXN0cy5xdWV1ZV9wcmlvcml0eV9oaW50KTsKPj4+ICsKPj4+ICsgICAgIHJldHVy biBtYXNrOwo+Pj4gK30KPj4+ICsKPj4+ICAgIHN0YXRpYyB2b2lkIHZpcnR1YWxfc3VibWlzc2lv bl90YXNrbGV0KHVuc2lnbmVkIGxvbmcgZGF0YSkKPj4+ICAgIHsKPj4+ICAgICAgICBzdHJ1Y3Qg dmlydHVhbF9lbmdpbmUgKiBjb25zdCB2ZSA9IChzdHJ1Y3QgdmlydHVhbF9lbmdpbmUgKilkYXRh Owo+Pj4gICAgICAgIGNvbnN0IGludCBwcmlvID0gdmUtPmJhc2UuZXhlY2xpc3RzLnF1ZXVlX3By aW9yaXR5X2hpbnQ7Cj4+PiArICAgICBpbnRlbF9lbmdpbmVfbWFza190IG1hc2s7Cj4+PiAgICAg ICAgdW5zaWduZWQgaW50IG47Cj4+PiAgICAKPj4+ICsgICAgIHJjdV9yZWFkX2xvY2soKTsKPj4+ ICsgICAgIG1hc2sgPSB2aXJ0dWFsX3N1Ym1pc3Npb25fbWFzayh2ZSk7Cj4+PiArICAgICByY3Vf cmVhZF91bmxvY2soKTsKPj4KPj4gV2hhdCBpcyB0aGUgUkNVIGZvcj8KPiAKPiBBY2Nlc3Npbmcg dmUtPnJlcXVlc3QuIFRoZXJlJ3Mgbm90aGluZyBzdG9wcGluZyBhbm90aGVyIGVuZ2luZSBmcm9t Cj4gc3BvdHRpbmcgdGhlIHZlLT5yZXF1ZXN0IHN0aWxsIGluIGl0cyB0cmVlLCBzdWJtaXR0aW5n IGl0IGFuZCBpdCBiZWluZwo+IHJldGlyZWQgYWxsIGR1cmluZyB0aGUgcmVhZCBoZXJlLgoKQUZB SVUgdGhlcmUgY2FuIG9ubHkgYmUgb25lIGluc3RhbmNlIG9mIHZpcnR1YWxfc3VibWlzc2lvbl90 YXNrbGV0IHBlciAKVkUgYXQgYSB0aW1lIGFuZCB0aGUgY29kZSBhYm92ZSBpcyBiZWZvcmUgdGhl IHJlcXVlc3QgaXMgaW5zZXJ0ZWQgaW50byAKcGh5c2ljYWwgZW5naW5lIHRyZWVzLiBTbyBJIGRv bid0IGdldCBpdC4KCkhtLi4gYnV0IGdvaW5nIGJhY2sgdG8gdGhlIHZlbmcgcGF0Y2gsIHRoZXJl IGlzIGEgCkdFTV9CVUdfT04odmUtPnJlcXVlc3QpIGluIHZpcnR1YWxfc3VibWl0X3JlcXVlc3Qu IFdoeSBjb3VsZG4ndCB0aGlzIGJlIApjYWxsZWQgbXVsdGlwbGUgdGltZXMgaW4gcGFyYWxsZWwg Zm9yIGRpZmZlcmVudCByZXF1ZXN0cz8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4