Re: [PATCH] tests/xe_pmu: Fix frequency stashing issue

["Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

Hi,

On 28-04-2025 11:06, Anirban, Sk wrote:
>
>
> On 25-04-2025 23:36, sk.anirban@intel.com wrote:
>> From: Sk Anirban <sk.anirban@intel.com>
>>
>> Resolved the frequency stashing problem by accurately
>> dereferencing the pointers, ensuring the minimum and
>> maximum frequencies are correctly restored.
>>
>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
>> ---
>>   tests/intel/xe_pmu.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
>> index 589c7cbde..094dc0c6c 100644
>> --- a/tests/intel/xe_pmu.c
>> +++ b/tests/intel/xe_pmu.c
>> @@ -527,8 +527,8 @@ static void stash_gt_freq(int fd, uint32_t 
>> **stash_min, uint32_t **stash_max)
>>       igt_skip_on(*stash_min == NULL || *stash_max == NULL);
>>         xe_for_each_gt(fd, gt) {
>> -        *stash_min[gt] = xe_gt_get_freq(fd, gt, "min");
>> -        *stash_max[gt] = xe_gt_get_freq(fd, gt, "max");
>> +        (*stash_min)[gt] = xe_gt_get_freq(fd, gt, "min");
>> +        (*stash_max)[gt] = xe_gt_get_freq(fd, gt, "max");
>>       }
>>   }
>
It looks good to me.

Reviewed-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>


[-- Attachment #2: Type: text/html, Size: 3234 bytes --]