From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Sarthak Sharma <sarthak.sharma@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/6] selftests/mm: make file helpers return errors
Date: Mon, 24 Aug 2026 14:29:37 +0200 [thread overview]
Message-ID: <e87ac26a-9712-4f6f-b144-b604b2aa643b@kernel.org> (raw)
In-Reply-To: <e4f8031e-20ea-46d1-914d-005595243f31@sirena.org.uk>
On 8/24/26 14:27, Mark Brown wrote:
> On Mon, Aug 24, 2026 at 02:17:03PM +0200, David Hildenbrand (Arm) wrote:
>> On 8/13/26 20:12, Sarthak Sharma wrote:
>
>>> + if (buf[0] < '0' || buf[0] > '9')
>>> + return -EINVAL;
>
>> This is to reject any negative or hexadecimal numbers I assume?
>
> That won't reject hexidecimal - 0xNNNN matches the above.
Ugh, yes (and stuff starting without 0x would not be detected consistently).
--
Cheers,
David
next prev parent reply other threads:[~2026-08-24 12:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 18:12 [PATCH v7 0/6] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
2026-08-13 18:12 ` [PATCH v7 1/6] selftests/mm: make file helpers return errors Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 12:17 ` David Hildenbrand (Arm)
2026-08-24 12:27 ` Mark Brown
2026-08-24 12:29 ` David Hildenbrand (Arm) [this message]
2026-08-25 8:40 ` Sarthak Sharma
2026-08-25 9:05 ` Usama Anjum
2026-08-25 9:12 ` David Hildenbrand (Arm)
2026-08-13 18:12 ` [PATCH v7 2/6] tools/lib/mm: add shared file helpers Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 12:27 ` David Hildenbrand (Arm)
2026-08-13 18:12 ` [PATCH v7 3/6] tools/lib/mm: move hugepage_settings out of selftests Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 12:32 ` David Hildenbrand (Arm)
2026-08-13 18:12 ` [PATCH v7 4/6] tools/mm: move gup_test from selftests/mm to tools/mm Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 12:33 ` David Hildenbrand (Arm)
2026-08-13 18:12 ` [PATCH v7 5/6] tools/mm: make gup_bench a benchmark only tool Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 12:37 ` David Hildenbrand (Arm)
2026-08-25 8:43 ` Sarthak Sharma
2026-08-13 18:12 ` [PATCH v7 6/6] selftests/mm: add a GUP selftest Sarthak Sharma
2026-08-24 7:59 ` Mike Rapoport
2026-08-24 10:11 ` Sarthak Sharma
2026-08-25 9:26 ` David Hildenbrand (Arm)
2026-08-25 11:09 ` Sarthak Sharma
2026-08-25 11:12 ` David Hildenbrand (Arm)
2026-08-24 4:12 ` [PATCH v7 0/6] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
2026-08-25 10:43 ` Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e87ac26a-9712-4f6f-b144-b604b2aa643b@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.