From: Atharv Dubey <atharvd440@gmail.com>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Crypto : qat: Replace scnprintf with sysfs_emit function
Date: Sat, 21 Mar 2026 10:14:08 +0530 [thread overview]
Message-ID: <e89054b1-5549-4fe6-be0b-a55cc5b185ed@gmail.com> (raw)
In-Reply-To: <ab232/oVbFU/+7Pd@gcabiddu-mobl.ger.corp.intel.com>
Sure, I will send a v2 of the patch.
Regards,
Atharv
On 3/21/26 02:40, Giovanni Cabiddu wrote:
> Thanks.
>
> Can you re-submit with the headline below?
>
> crypto: qat - replace scnprintf() with sysfs_emit()
>
> On Fri, Mar 20, 2026 at 11:49:28PM +0530, Atharv Dubey wrote:
>> Replace 3 sysfs functions in the Intel Qat Driver
>> to use sysfs_emit() instead of scnprintf.
> nit. scnprintf().
>> - erros_correctable_show(): Replace scnprint() with sysfs_emit()
>> - errors_nonfatal_show(): Replace scnprint() with sysfs_emit()
>> - errors_fatal_show(): Replace scnprint() with sysfs_emit()
>>
>> This change is in accordance with Documentation/filesystems/sysfs.rst,
>> which recommends using sysfs_emit/sysfs_emit_at in all sysfs show()
>> callbacks for buffer safety, clarity, and consistency.
>>
>> Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
>> ---
>> drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
> Apart from the commit message, it looks fine.
>
> Thanks,
>
prev parent reply other threads:[~2026-03-21 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 18:19 [PATCH] Crypto : qat: Replace scnprintf with sysfs_emit function Atharv Dubey
2026-03-20 21:10 ` Giovanni Cabiddu
2026-03-21 4:44 ` Atharv Dubey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e89054b1-5549-4fe6-be0b-a55cc5b185ed@gmail.com \
--to=atharvd440@gmail.com \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.