Re: [PATCH v2 5/7] mfd: qcom-pm8008: Add PM8010 support

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/19/26 7:00 AM, Jishnu Prakash wrote:
> Hi Konrad,
> 
> On 10/15/2026 5:34 PM, Konrad Dybcio wrote:
>> On 10/14/26 12:32 PM, Jishnu Prakash wrote:
>>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>
>>> PM8010 is effectively the next generation of PM8008. The device is
>>> generally designed to serve the exact same function - power camera
>>> sensors and the associated supporting hardware.
>>
>> [...]
>>
>>> +	pmic_type = (unsigned long)of_device_get_match_data(dev);
>>
>> I don't understand why you changed my match_data_struct approach
>> here just to reconstruct the same data
>>
> 
> I was asked to do this by Lee here: https://lore.kernel.org/all/20260922093327.GA2308615@google.com/
> and also by sashiko: https://lore.kernel.org/all/20260918165137.302631F000FF@smtp.kernel.org/.
> 
> Using an enum ID with switch() statement, instead of more complex
> match_data structs, seems to be a convention to follow in MFD drivers.
> For example, I could see the same being done in probes of
> drivers/mfd/rohm-bd71828.c and drivers/mfd/max77620.c.

Okay, if the maintainer said so, let's roll with it

Konrad