From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC/PATCH] consistently try VISUAL, EDITOR and vi in this order.
Date: Mon, 03 Jul 2006 11:24:02 +0200 [thread overview]
Message-ID: <e8anmn$ufp$1@sea.gmane.org> (raw)
In-Reply-To: 7vmzbrv1yc.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> git grep -e VISUAL -e EDITOR revealed this inconsistency. All
> other commands seem to check VISUAL and then EDITOR as they should.
>
> + my $editor = $ENV{VISUAL} || $ENV{EDITOR} || 'vi';
> system($editor, $compose_filename);
Shouldn't we check if we are in visual (non CLI-only) environment,
like X-Window, MS Windows or MacOS X, before trying to use VISUAL?
How other parts solve it? </me checks> Ah, we use VISUAL unconditionally,
at least in scripts...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
prev parent reply other threads:[~2006-07-03 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 2:47 [RFC/PATCH] consistently try VISUAL, EDITOR and vi in this order Junio C Hamano
2006-07-03 9:24 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e8anmn$ufp$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.