From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531053E51FD for ; Fri, 22 May 2026 11:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450047; cv=none; b=dVsBm4sBISjOEG6wlwEU7t0yr41sPLdvvmk59L8pksd5gmi/pHMm9d6gwhsjKfhIlhnnheeIwiHWpturgXyQcOt4jhCpmZMm3vpYPkD8GMzHuC475hcSL2Us2waBpemtgz65w6IUiyz0RD0TRpwWas3D7mMHEVQMZi/xd7ii1Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450047; c=relaxed/simple; bh=Q+PX6X71JwQZhEfwNl495EuFgMt3XjlAbKMGlCt6uHg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YMBdUr8T3N123aIplZZ9rmhkZT4j7fGya4V1z7zQyJQAURYuLxFe1kSCHSq8ImUeIo+KSFh82fN2hayh3MQujSApbo+4BNQf0OfoibvQc+c72w4hmEFcpccy/LXyed9pZMfZ5MjmQmIaiVPZncaTH7InWfCV/0HEboJ89maBbr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RTOwpQUF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fZUgHf21; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RTOwpQUF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fZUgHf21" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M6lqrB1298254 for ; Fri, 22 May 2026 11:40:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PJrMUhAsFW3Hba+YJzivVZsaFeu6ubFMMTZwlHTTbPI=; b=RTOwpQUFvLJtWgln wYnrgQrGbrCE9RWF88iqdN1OHIKdP8KZIZN7zyTIgTPDOIygBdReHSPpUX+CV0zs Tel7Z9VEGAlAxx0Ay/eRwmkFd6VAppMHPJNBb2GAdgjNn/fQYjUXd6QoQdE89KgF MY60xrXoC7Q8mDG4w7Po2w2WpXPrVeSaOsDYIQHKlpC44FnGBZ4AfALNNlT0rP9f OEsrE1ncQ87aG/UO+aD0AXRP5/6/mtuYHPwB57eQYpgl77bJDvoN+9j2KaDGsI2F 5wlOkH24BnuFCv8DxJiTcnl0Zn0rAixxusv7MzIihYA5l7goriAP6eDltHICF+6H p61s7g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eaah0arma-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 11:40:45 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516d1d282deso2496411cf.0 for ; Fri, 22 May 2026 04:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779450044; x=1780054844; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PJrMUhAsFW3Hba+YJzivVZsaFeu6ubFMMTZwlHTTbPI=; b=fZUgHf21PDybtn8Id8IKWaeQFS5GaXXvo3v38xN2hE5+Zad7auxfFPXqV1JRkdbbkY bd3E2IlH6qAF1y3DEI7WzNIKXpi4Az0D1B4FS+pA4vzkNndjl+/HB1jBHxKX2bihcZYJ nE120Gef3De/ENLzGYqSm9Cko6eSMuIcw43HJnHU/N9mePYXp6tZl4+m1GxoA76yIbJh zCV8K3UmB8/DPPLI4ScxZB6sQrIWirpJptBU4Jaw6cV1PStyu+xOwC3Num0c9aNg8Ozf cCJJefiRNQqORnKgBsXL3eAIYQra0SMoGYjEtbGsXLnlbxQa2UQp/OgDMGhhtAFvlAyE dkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779450044; x=1780054844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PJrMUhAsFW3Hba+YJzivVZsaFeu6ubFMMTZwlHTTbPI=; b=AxkUVmm0KIrer1Zr1H8rqrD7qgs9kA4EeRXjviVYWaHJf2vR+4oLB7RKt5wSI4t8C+ y/UJ3UgFrLpgyQiCsYNMUtEQl/C2I5c4nNHG5vaOQuh4vyTBj3zo1PI3tThunIDAXNgS TkM/xdo6OA6CmWkHEyoIusy0W7eVJZCX4lZpjd0D3Fy8VU2e8DNWbtgahLXdXtTp1GO3 B0PfTvKscBsSypkc9JDHvWCZGiPvNDg3I300mQLpjf2EaoMYqQhp7Dil9cgqBl/I4IWJ wcgcGdKbjiKHtFwFfmEufzjCPUAFtEBC4BOOe5iKZ1HDRWJKskT9Va6jpzODfMp8Ht32 sU5Q== X-Forwarded-Encrypted: i=1; AFNElJ9mERVL4mk9YLEvq/dtcW9nJUkxPQ6Pbj4VRbQSDc4GQOLbzOvcsRyFlUTeNnaWt1jY1jL45f/ftOJWSi4=@vger.kernel.org X-Gm-Message-State: AOJu0YyH78VGx4lSoM6RKHPdM3LmxyhfGT/NtILxlbdGGAeAkb/q4FLS kuCLvzYuVGOyKQlTbj/LxCnh42jjgfhLD/Vvhww2UoLXValdS9i8AmuO2wn6mt5u7CTmAbvaj8G SMa8MD1ZmgT10GjqpsFPtG09+/xTRnaN2DleyRNl5r3XqnYYGcw6FHWufSeNDJrm0RY8= X-Gm-Gg: Acq92OFx5BJRhoNX0Jc97NPiI6D9V7jPBY2lkNXvRRm8Ip24N99AAarUyPemnyCV67N 9MZAI8gXzUdY4zkIsgKLYEQ/AKZa3/qeXkgBt21k6iLuGnf3+wTx3Pr/rx+HGtEDw2R7OJ3pCcM bjt0/IVDE+Gj7Rb0Nhxds3DMqsT8cuRSRGE6x+dokVhd4ruLvnRQQwuzzwwNuktFX0f1xGURENA xvwzl0eu8i6+6UotKFl0t8vLvFYOwgDmIQD50vWR1qeQMjg7Sy4C4cUhAixggCddhIHZ3v9mIYS KPxwZDqW42SyvaC7becN7PzDfWpZUXEDbEFLpq9ZanNEx3QSCFGKkGMVXCXElcOsmxKVaDPAq7L EMClcq6OIks1Zw2mq0XCVzH+2nyWSKEORxAKfDmRf/z5yJQ== X-Received: by 2002:ac8:5acf:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-516d4433f1emr30597071cf.2.1779450040083; Fri, 22 May 2026 04:40:40 -0700 (PDT) X-Received: by 2002:ac8:5acf:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-516d4433f1emr30596801cf.2.1779450039590; Fri, 22 May 2026 04:40:39 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5ece294sm44994866b.35.2026.05.22.04.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 04:40:38 -0700 (PDT) Message-ID: Date: Fri, 22 May 2026 13:40:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/10] drm/msm/dp: Add sink_count to debug logs To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-8-0c8450737d64@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260314-hpd-refactor-v5-8-0c8450737d64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDExNiBTYWx0ZWRfX7V3leJQft1eg 3bScmXUWzIwz6jwprrPNK39l15JkH67jRRmn0KssPH6W1qcA9R0FJc+m0NGrzc3X7crSTgjwtTs XrbLhZsiekxHpqcvemU/5aYD12aKFG5cnC65ImI1UhZg3sVG4jiethFSnqpYyh5WZvbMKy6UGG+ RpIx+lz2PWeFiP+vznrRvH+/oMGBgInMJal+WGLMDjWIClca88pNcR+UrpIlzVgU0zTytP80C0R YL/Be5ulknaoS2SzpNVuT9JOVxCbiC34izctQl0Q8ODu+KlIviY6OY7JZDcKN09cIqGMfSQK4ZQ GAMcsiI/hx+CPv5J7s8L9E8Ud0QsokwfH0VFMkuprfPfYDHAPP0yeWPto+hxXLSDqCegkbllVwf KvUx3xuxoLRA39d6Irb5XXi32XTzO8iELq55tXY0O6FVN9u0TZ406QJpwlRHgSm6u/W+BJiHrL5 YW8w9Pdh1vBb0X0EOyQ== X-Proofpoint-GUID: aHtyRc526KLydjjzg9bhZY6280G5uujq X-Authority-Analysis: v=2.4 cv=LNdWhpW9 c=1 sm=1 tr=0 ts=6a1040bd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=Vx9tJy4mw0iOory6Zd8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: aHtyRc526KLydjjzg9bhZY6280G5uujq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220116 On 3/14/26 2:09 AM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > Add sink count to the debug logs for [un]plug and HPD IRQ handling. > > Signed-off-by: Jessica Zhang > [DB: dropped link_ready handling] > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 30 ++++++++++++++++++------------ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index d61a8ddd30a8..b4deeea0ec59 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -388,8 +388,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp) > int ret; > struct platform_device *pdev = dp->msm_dp_display.pdev; > > - drm_dbg_dp(dp->drm_dev, "Before, type=%d\n", > - dp->msm_dp_display.connector_type); > + drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d\n", dp->link->sink_count is an u8 (perhaps over-eagerly? 'int' seems to be fine for "amount of things") and the struct gets padded anyway as of right now Konrad