All of lore.kernel.org
 help / color / mirror / Atom feed
From: subashab@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org
Subject: Re: UML kernel panic on initialization
Date: Tue, 13 Jul 2021 14:16:46 -0600	[thread overview]
Message-ID: <e8b9a7f3683933c472f2e5ba22e9433d@codeaurora.org> (raw)
In-Reply-To: <8c377addaa42a7dd3bbe047e1f744a51103e6ff2.camel@sipsolutions.net>

> Oh, and it looks like 84b2789d6115 actually got some bits that 
> shouldn't
> have been there!
> 
> Assuming it does *not* work with just the first three patches reverted,
> does it work again if you revert the first three patches, and only this
> bit of the fourth?
> 
> --- a/arch/um/kernel/skas/clone.c
> +++ b/arch/um/kernel/skas/clone.c
> @@ -24,29 +24,26 @@
>  void __attribute__ ((__section__ (".__syscall_stub")))
>  stub_clone_handler(void)
>  {
> -       struct stub_data *data = (struct stub_data *) STUB_DATA;
> +       int stack;
> +       struct stub_data *data = (void *) ((unsigned long)&stack &
> ~(UM_KERN_PAGE_SIZE - 1));
>         long err;
> 
> 
> 
> I think we probably have some miscompilation again with this thing - I
> saw a bunch of similar issues with our syscall stubs at some point, and
> I'm not sure we got it all right already.
> 
> johannes

Initialization is successful if only this bit of 
84b2789d61156db0224724806b20110c0d34b07c
is reverted.


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  parent reply	other threads:[~2021-07-13 20:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 21:00 UML kernel panic on initialization subashab
2021-07-11 20:27 ` YiFei Zhu
2021-07-12 18:19   ` subashab
2021-07-13  4:04     ` YiFei Zhu
2021-07-13 13:50       ` Anton Ivanov
2021-07-13 14:03         ` Richard Weinberger
2021-07-13 18:02           ` subashab
2021-07-13 18:32             ` Johannes Berg
2021-07-13 18:54               ` subashab
2021-07-13 19:17                 ` Johannes Berg
2021-07-13 20:00                   ` subashab
2021-07-13 20:52                     ` YiFei Zhu
2021-07-13 22:14                       ` Richard Weinberger
2021-07-13 17:47         ` subashab
2021-07-13 19:22 ` Johannes Berg
2021-07-13 19:26   ` Johannes Berg
2021-07-13 19:28     ` Johannes Berg
2021-07-13 20:40       ` subashab
2021-07-13 20:41         ` Johannes Berg
2021-07-13 20:16     ` subashab [this message]
2021-07-13 20:07   ` subashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8b9a7f3683933c472f2e5ba22e9433d@codeaurora.org \
    --to=subashab@codeaurora.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=jdike@addtoit.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.