Re: [PATCH for-next] RDMA/efa: Support QP with unsolicited write w/ imm. receive

["Margolin, Michael" <mrgolin@amazon.com>]

Hey Gal,

Thanks I'll fix that.


Michael

On 5/6/2024 2:19 PM, Gal Pressman wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> Hi Michael,
>
> On 06/05/2024 13:48, Michael Margolin wrote:
>> @@ -663,7 +666,9 @@ struct efa_admin_feature_device_attr_desc {
>>         *    polling is supported
>>         * 3 : rdma_write - If set, RDMA Write is supported
>>         *    on TX queues
>> -      * 31:4 : reserved - MBZ
>> +      * 4 : unsolicited_write_recv - If set, unsolicited
>> +      *    write with imm. receive is supported
>> +      * 32:5 : reserved - MBZ
> Nit: 31:5.
>
>>         */
>>        u32 device_caps;
>>
>>   struct efa_ibv_create_qp {
>>        __u32 comp_mask;
>>        __u32 rq_ring_size; /* bytes */
>>        __u32 sq_ring_size; /* bytes */
>>        __u32 driver_qp_type;
>> +     __u16 flags;
>> +     __u8 reserved_90[6];
> Don't you need to verify this reserved is cleared somewhere?
>
>>   };