From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4112F1F959 for ; Wed, 19 Jun 2024 14:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806881; cv=none; b=JEIQFXcnRTibI3h05Dsr/efbI9dFE9KkaGvnLiibLMVOTGyuWIzolKn46idzzchUBzeTVspIgAO05mQyxag90uUKVT8XqjplXXOvGyigeD6jgnbXugr1AX5CZNKCV8Yna0B/T4jAv77wxf8nARSCEUFeD8yF0jC/vvLsl4kiq9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806881; c=relaxed/simple; bh=uH4XR4wLXeFFWwFyzqN4liYHhcQFiK7R5SRMOkCV9Yw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=f8Lr9E95ZOvWSspU8aU1zMoWfpmQPpnG9ZTAv06tL3aZQX+b/8A++uDMiEU9JLgewjNE3K+Vw1zkubHNojM0/3Yn2IBLjZ7ozlftUrbq4llU2I34u/4UN5famnD5HozJkggQBIpgLkm9ju/Idej39CoAknTQWMpVd54NSvRceaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=gN3m071S; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="gN3m071S" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-6e9a52a302dso332779a12.1 for ; Wed, 19 Jun 2024 07:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718806879; x=1719411679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=gN3m071SEtTl0OhquuEkIBzk+6An7z/TX2fEqSricgNWbByryugD5CB8h0u+FHwAGY QKbTdNi1JPAZEqPIe9tigW8BP8kweKQUS0L8IXja00/z+WqHW8ANBouOSBqqrS46mLB8 K22Q54/TLckKjn1PKxVrxH9x6n0jGs0TTApR9TDRp1kqPPPgmIywNnjOqZnuF0ahwGvr pnmbm/xtUeIQjYtpIwCZDcq3/PrNErg96816mmdo80e94xqeZuHy4PJIwlpX3UfpD1Gp lsHRzt0amLCOASe8+GW8iBS8m5PSyv/Hnft2tzaI3Gi9khyEjHeGu8Y1ozCbvEgcMijV /nEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718806879; x=1719411679; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=PW56nCvtYBlO/d53To+qdalFK0BYefVA7SLO18/AIP1p2tVFKHNry3d9ExYvXB7QKo n2EjYhaCK+sCFcYwa31bxYjMw0DDKGia3ZCbzz9mUXAq1uWKoGkLESzJjI6cHmdJDJ0Z Eo/MMX7tWE6BfG6DZPiRXiBT3C4gG2KTw1R714tVpjliuggKTcRlA3B78O7DB9MUCk2M xM/IIWrrTQIZD7WvNyrCEH7Zah/lDaQw5qFBsSYsCvl1qAKqZrZ+S/nFk20ZSTJ6f78W sH2nh1Fm3fMfn1a95bUtEdwHiLtdb7vssRPj6w+e98YNlbivQ2v+hrxs6uqVo0JmTi4r fhBQ== X-Forwarded-Encrypted: i=1; AJvYcCX8Tux6vrHSE3GM29v5cAW01fgEAHgpVzplpF04jAHgR/O5ZD/mB9YxLcCrv+LSX31TkxjGuUO5eYfzzunyY9Mk6POarya/Cc09Zw== X-Gm-Message-State: AOJu0Yz7euaNUPC6VL0n1q1NpH9xr+F2jlUIVCEF3729hsZF+++b6RO2 Vg6v5up62xLXCIWBQTHqfYdpzZpOznlWzgL6+Ce0611IQEOiQGHPZdeov6nHFNg= X-Google-Smtp-Source: AGHT+IGlNYahWungPdY/VG0D2i+/kOzAqG/9vIEbq77BhnEO6pEhdeI5ihGxkaZBKQBmSE54SEc3pA== X-Received: by 2002:a05:6a21:33a5:b0:1b8:622a:cf7c with SMTP id adf61e73a8af0-1bcbb727134mr2697727637.3.1718806878609; Wed, 19 Jun 2024 07:21:18 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b110sm10739431b3a.153.2024.06.19.07.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 07:21:17 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig Cc: Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9658BC27C53 for ; Wed, 19 Jun 2024 14:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w6loS4Y5zI2F19F1UokGmhyfKBQeqomR9hiE9VOMdbY=; b=amAanVs047C9Oa x5f+oupDTpl/0oszD+tSI3Z9IMHBAjKBUjoHmRZqAfOsMrix2BcmGHJKS9iqwV6ypThiNFV+5AOSX Yy9msfb8QvL8287cVVEuBEwRfLEnDEsQsNGXhAss//Wwz3f7KBZmnJXFIde0FtFQ5szNUkt1CYvN5 kvEdeBgNh4yAXIwxUOFXVUbjfXAdCqlNn7KvOUPXW9Tk2aNysDpspe91HAyoLzMk0IRT+Q3MhUM4A MrWUP2PW8gI0AfhwExZSvAc1ziRuQzRMZixbvwzl3kRHc58hfv535+pLALOBxzKG4IV/43gHNPw+/ tr4cGkyE9JrlJJ3WVxGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJwBi-00000001UiN-2e95; Wed, 19 Jun 2024 14:21:27 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJwBb-00000001Ud8-2s6C for linux-mtd@lists.infradead.org; Wed, 19 Jun 2024 14:21:23 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-6c386a3ac43so406236a12.0 for ; Wed, 19 Jun 2024 07:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718806879; x=1719411679; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=fHCgF0uhO0nuyZqlRpelUr61VBjxZeFBghsqWgKhlDVVMs+UVVexUSBKvR/bwYnNaa nQAg7yUSEN5KMyPr7VNWeiLV1fcMsp8ybe46RfZQIeJ9ho1qSxiu1Dd95H4BWUiDK2Xw ujwJ/kqkS2sT0+9uCWIWuX+CLpStuQTswEwbKkWKBHchKg3jD0MwM+8KTuPOMVFvSoJ8 /PTP9DiKBffeouR00305aC34047ynfsn1SacdwQM0E/sm2xpmzKntxttj8D2QzyVUldW CSxagGXV4PyATsSznZymvCCFLSnzaT9Eagn5NYReu/WhqRgjXauozi3w2zg18TkopjDe fMOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718806879; x=1719411679; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=dEJhm/hIZeoPZW/pGNyTX5EYKBq5i5B8A/vuC0naU4JsNTAz2BOV5QfDWVgz8qyMtb o4rTk1kvnCdzUO5Hb3bKBbucD8XpfAOs6lAcnzlBePoXuvKV+s62l4/H34CW3KtyesU4 qrtgjZm6OSh6mYD+hESTWUETnFaOyqybGKVGdIo9DbBAEvVYEkCXIWhVxwRbFhELSViQ KjJsHzVDmnN7VNkpLTfYeVqvyTrdB8Gxh64rOM5hYQMWreqnODSBDsr9vBk1CMwH5uJ7 /yjGqKeVAo3LQoPR0WzNJdSr6XTVrsZcoKpRRlpwdI7C32LFVxjglvoop8piWULSacQh rleA== X-Forwarded-Encrypted: i=1; AJvYcCUZ+iellRXtEuFpbARurgQjnOeEKLJ/Duz5eeMwQvyFKQFquXK0vFKN1VjXXtSEKGsgEc4DcodHeLxq1w8xGKXGB08cJm5ygBuRqwZ0vQ== X-Gm-Message-State: AOJu0Yz9JvNHGv24yhlr+eOQ/BC191OLXYVNuMF6gZY5FEHtpIwrbGDq IogIELiOkXIphiognM9HpYF5uZtAlwybAzZSeqOMuGCSm8K/5efjayftUNqcQMY= X-Google-Smtp-Source: AGHT+IGlNYahWungPdY/VG0D2i+/kOzAqG/9vIEbq77BhnEO6pEhdeI5ihGxkaZBKQBmSE54SEc3pA== X-Received: by 2002:a05:6a21:33a5:b0:1b8:622a:cf7c with SMTP id adf61e73a8af0-1bcbb727134mr2697727637.3.1718806878609; Wed, 19 Jun 2024 07:21:18 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b110sm10739431b3a.153.2024.06.19.07.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 07:21:17 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig Cc: Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_072121_025805_91BDCE1D X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF1EFC27C53 for ; Wed, 19 Jun 2024 14:22:03 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=hGIpHsWR; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W45RF4Hjzz3cY1 for ; Thu, 20 Jun 2024 00:22:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=hGIpHsWR; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.dk (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=axboe@kernel.dk; receiver=lists.ozlabs.org) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W45QS5phdz30Ts for ; Thu, 20 Jun 2024 00:21:20 +1000 (AEST) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-7119502613bso87120a12.2 for ; Wed, 19 Jun 2024 07:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718806878; x=1719411678; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=hGIpHsWRCmGNWyBSZohUdKqz5PSg2TSQSE+d4IU7ftu9UwGdoAqNglUjD0IRYjKk+M etnKkEcyfd8zZVxMmo90rHVoWrSddGbJzoa9qMNQ+ELXYPwQKK5OR9oViMFUGvm9c8Qi Lwg8lzFAjRgmqame7fhpNba+TbdWUllx4WDvWo00a5A3ooyBL2Vd/1aAR4vnBGObbNFt EsyCZnsjeVUqkHITDNvagPB1YRMy1f4NK1RyVGeEE5itQ8MZ5c9bNB0rhyzS/RgiQpzM 2RyoqIO+XsRzn3oNETpPa80uRQj4qMS6SN60Fh+z6JZ04L36ZoHJzvdrQE4hFrSSa3ll t7eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718806878; x=1719411678; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=WS4RjVO6DN1pYehaDaPN8N0JbKdxtqPqiJRdJVNfb/d3JrS6O8Dsr57I/c3fp2fXTo VQOIc+b+/vuDJH0RxPdUI2+MoFt9Euh7twP3cXG1llpqmhM6Q9Iv9m4qT8liQLWb3ExB EZs3xkZDvHVghZAJV1V0quOKZQ6feIIP+cD0HiV5/vZke53PtUByYE0sQQqhFkPToddx +dq/GKpnX+QP5ye5xMfqvV4K1nFPJm1dhteHluxTsuxSz7/LbfMWnnHJZCirjUCAbBK3 mhywuKfJ8m69RyAwXkKGdQpgOi+uYPpJEkZ2E6UDH/hdBhnyz3Y/FpZr/1l5wlxjBp/b cqZw== X-Forwarded-Encrypted: i=1; AJvYcCXj/blECCgMeB6g2uVUy49FY2p0H5b3AmNO61g+9OmQf/+y23lN1tCJ1JTTPNB5G8jm+WRpAHb3E6COSK4Ss7pDm5LA56LVhKlYH9aJ7Q== X-Gm-Message-State: AOJu0Yx3MfYsr8lDnAlk+ZHogK71pqcgUZcH/1GpTHdneIWKId7PZnjH LwyJtCBdd8q3AtnQkNzzAFjQchGM1Q5BrrMm81DDLbvYRoj1YkSpFdZhHTGEFmk= X-Google-Smtp-Source: AGHT+IGlNYahWungPdY/VG0D2i+/kOzAqG/9vIEbq77BhnEO6pEhdeI5ihGxkaZBKQBmSE54SEc3pA== X-Received: by 2002:a05:6a21:33a5:b0:1b8:622a:cf7c with SMTP id adf61e73a8af0-1bcbb727134mr2697727637.3.1718806878609; Wed, 19 Jun 2024 07:21:18 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b110sm10739431b3a.153.2024.06.19.07.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 07:21:17 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, Ming Lei , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id A75164202C2 for ; Wed, 19 Jun 2024 16:21:19 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7119502613bso87125a12.2 for ; Wed, 19 Jun 2024 07:21:19 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 MIME-Version: 1.0 Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, Ming Lei , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe