Re: [PATCH v5 2/3] dts: constrain DPDK source argument

[Luca Vizzarro <Luca.Vizzarro@arm.com>]

On 30/05/2024 16:41, Juraj Linkeš wrote:
>> -                           [DTS_CFG_FILE] The configuration file that describes the test cases, SUTs and targets.
>> -                           (default: conf.yaml)
>> +                           [DTS_CFG_FILE] The configuration file that describes the test cases, SUTs and targets. (default:
>> +                           /home/lucviz01/dpdk/dts/conf.yaml)
> 
> The path has changed.

whoops! nice catch.

>> +def _parse_tarball_path(file_path: str) -> Path:
>> +    """Validate whether `file_path` is valid and return a Path object."""
>> +    path = Path(file_path)
>> +    if not path.exists() or not path.is_file():
>> +        raise argparse.ArgumentTypeError("The file path provided is not a valid file")
>> +    return path
>> +
>> +
>> +def _parse_revision_id(rev_id: str) -> str:
>> +    """Validate revision ID and retrieve corresponding commit ID."""
>> +    try:
>> +        return get_commit_id(rev_id)
>> +    except ConfigurationError:
>> +        raise argparse.ArgumentTypeError("The Git revision ID supplied is invalid or ambiguous")
> 
> I made the comment about ordering in the other patch with these
> functions in mind, so let's not forget these.

Yes, this are actually in the wrong place. Will move.