All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"conor@kernel.org" <conor@kernel.org>
Cc: "Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"robh@kernel.org" <robh@kernel.org>,
	wsd_upstream <wsd_upstream@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-devicetree@vger.kernel.org"
	<linux-devicetree@vger.kernel.org>,
	"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>
Subject: Re: [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding
Date: Wed, 1 Jul 2026 06:36:22 +0000	[thread overview]
Message-ID: <e8fb727e51fa6231decee7d520d339533b705f73.camel@mediatek.com> (raw)
In-Reply-To: <20260626-rewrap-sediment-ad9449abd837@spud>

On Fri, 2026-06-26 at 16:53 +0100, Conor Dooley wrote:
> 
> It isn't going to exist, since we will chuck a fit at the underscore!
> 

Hi Conor,

Thanks for the review.
I apologize for the mistake in using this bad examples.
I will remove it in the next version.

> > 
> > > +        reg = <0x16840000 0x1000>;
> > > +        #address-cells = <1>;
> > > +        #size-cells = <1>;
> > > +
> > > +        ufs0cfgao_rst: reset-controller {
> > > +            compatible = "mediatek,syscon-reset";
> > 
> > It looks to me like this is just two registers inside ufs0cfg_ao,
> > not a
> > separate device. Why don't you just add #reset-cells to the parent
> > node?
> 
> I concur, seems like it should be in the parent.
> pw-bot: changes-requested
> 
> 

This is for flexibility in MediaTek SoCs, as described in the
previous email.

Thanks
Peter

  reply	other threads:[~2026-07-01  6:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26  7:46 [PATCH v1 0/2] reset: mediatek: add syscon-based reset controller peter.wang
2026-06-26  7:46 ` [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding peter.wang
2026-06-26  7:53   ` sashiko-bot
2026-06-26  8:33   ` Philipp Zabel
2026-06-26 15:53     ` Conor Dooley
2026-07-01  6:36       ` Peter Wang (王信友) [this message]
2026-07-01  6:35     ` Peter Wang (王信友)
2026-07-01 16:57       ` Conor Dooley
2026-07-02  8:52         ` Peter Wang (王信友)
2026-07-02 18:44           ` Conor Dooley
2026-07-02  8:55         ` AngeloGioacchino Del Regno
2026-07-02  9:39           ` Peter Wang (王信友)
2026-07-03  9:21       ` Philipp Zabel
2026-07-06 12:53         ` Peter Wang (王信友)
2026-06-26  7:46 ` [PATCH v1 2/2] reset: mediatek: add syscon-based reset controller driver peter.wang
2026-06-26  8:00   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8fb727e51fa6231decee7d520d339533b705f73.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=Alice.Chao@mediatek.com \
    --cc=Chun-hung.Wu@mediatek.com \
    --cc=Ed.Tsai@mediatek.com \
    --cc=Naomi.Chu@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.