From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] do not use locale specific strftime when preparing 2822 date
Date: Fri, 07 Jul 2006 21:53:11 +0200 [thread overview]
Message-ID: <e8me2l$8ur$1@sea.gmane.org> (raw)
In-Reply-To: 7vveq9w736.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> It looks like it is _almost_ correct. It should be
>> Date: Fri, 07 Jul 2006 20:57:55 +0200
>> instead of
>> Date: Fri, 7 Jul 2006 20:57:55 +0200
>>
>> It is "day = ([FWS] 1*2DIGIT) / obs-day" in RFC2822.
>
> I think you are reading ABNF wrong. [...]
>
> See the definition of "hour" and friends a few lines below what
> you quoted. It is defined as "2DIGIT / obs-hour" and that is
> why we say "01:23:45" not "1:23:45"
But it is "day = [...] 2DIGIT [...]"!
Besides, that what other mailers do (I checked the post I replied via
git-send-email to, i.e. your post). Although I don't think that it can
cause any problems, like using locale date with non US-ASCII characters
did...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-07-07 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 7:17 Strange date format in git-send-email Martijn Kuipers
2006-07-05 9:00 ` Jakub Narebski
2006-07-05 21:22 ` Junio C Hamano
2006-07-07 18:57 ` [PATCH] do not use locale specific strftime when preparing 2822 date Jakub Narebski
2006-07-07 19:03 ` Jakub Narebski
2006-07-07 19:25 ` Junio C Hamano
2006-07-07 19:53 ` Jakub Narebski [this message]
2006-07-07 19:08 ` Junio C Hamano
2006-07-07 20:01 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-07-07 18:53 Jakub Narebski
2006-07-07 19:59 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e8me2l$8ur$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.