From: David Ahern <dsahern@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
stephen@networkplumber.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, sgoutham@marvell.com
Subject: Re: [PATCH iproute2-next] devlink: support u32-array values in devlink param show/set
Date: Sun, 28 Jun 2026 11:19:48 -0600 [thread overview]
Message-ID: <e907ee3e-df70-4e32-a69f-29a9baaf1993@kernel.org> (raw)
In-Reply-To: <20260615041042.549715-1-rkannoth@marvell.com>
On 6/14/26 10:10 PM, Ratheesh Kannoth wrote:
> @@ -3904,6 +3935,14 @@ static int cmd_dev_param_set(struct dl *dl)
> if (!strcmp(dl->opts.param_value, ctx.value.vstr))
> return 0;
> break;
> + case 129:
no magic numbers. What does 129 represent? Is there a named macro for
it? If not, why not if this is part of a UAPI?
> + buf = (char *)dl->opts.param_value;
> + token = strtok(buf, delim);
> + while (token) {
> + mnl_attr_put_u32(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, atoi(token));
> + token = strtok(NULL, delim);
> + }
> + break;
> default:
> printf("Value type not supported\n");
> return -ENOTSUP;
next prev parent reply other threads:[~2026-06-28 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 4:10 [PATCH iproute2-next] devlink: support u32-array values in devlink param show/set Ratheesh Kannoth
2026-06-28 17:19 ` David Ahern [this message]
2026-06-29 2:22 ` Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e907ee3e-df70-4e32-a69f-29a9baaf1993@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.