From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index
Date: Fri, 11 Sep 2020 14:05:22 +0100 [thread overview]
Message-ID: <e90d64e3-e2c6-73be-7951-2fdd47668fff@intel.com> (raw)
In-Reply-To: <20200911093714.28346-1-sachin.saxena@oss.nxp.com>
On 9/11/2020 10:37 AM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
>
> Dpaa2 pmd has no need to bound host interface
> for which we require if_index field.
> Setting it to 0 as unused.
>
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 0e9f836e5..c91543131 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -241,7 +241,7 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>
> PMD_INIT_FUNC_TRACE();
>
> - dev_info->if_index = priv->hw_id;
> + dev_info->if_index = 0;
>
Same here, I think assignment can be dropped completely.
next prev parent reply other threads:[~2020-09-11 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 9:37 [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index Sachin Saxena (OSS)
2020-09-11 13:05 ` Ferruh Yigit [this message]
2020-09-14 14:21 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
2020-09-14 17:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e90d64e3-e2c6-73be-7951-2fdd47668fff@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.