Re: [PATCH 11/17] makefile: Fix symbol typo in binary_size_check

[Heinrich Schuchardt <xypron.glpk@gmx.de>]

On 2/24/25 06:55, Sam Edwards wrote:
> The start-of-image marker symbol is `__image_copy_start`; by searching
> for `_image_copy_start` instead, this check can accidentally match
> `_image_copy_start_ofs`.

_image_copy_start_ofs seems to be the only match for
git grep -n '[^_]_image_copy_start'.

Can _image_copy_start_ofs seems ever occur before __image_copy_start?

>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b32606b69f5..a9194b46ae1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1314,7 +1314,7 @@ binary_size_check: u-boot-nodtb.bin FORCE
>   	@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{ print $$1 }') ; \
>   	map_size=$(shell cat u-boot.map | \
>   		awk ' \
> -			/_image_copy_start/ { start = $$1 } \
> +			/__image_copy_start/ { start = $$1 } \

Most architectures don't define __image_copy_start so this code looks
broken. Please, provide a solution that works on all architectures.

Best regards

Heinrich

>   			/_image_binary_end/ { end = $$1 } \
>   			END { \
>   				if (start != "" && end != "") \