From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3719C83F1B for ; Thu, 17 Jul 2025 11:16:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucMav-0004rG-3j; Thu, 17 Jul 2025 07:16:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucMaM-0004nZ-7J for qemu-arm@nongnu.org; Thu, 17 Jul 2025 07:15:34 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucMaK-00068T-13 for qemu-arm@nongnu.org; Thu, 17 Jul 2025 07:15:33 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-45555e3317aso4931765e9.3 for ; Thu, 17 Jul 2025 04:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752750928; x=1753355728; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W2plJ6J2I3uEkS9s/RoI/iLItjcXG/U6oXtMhASgX4s=; b=nEU9eaScAnfR3bgKzY3koe/HmFnOenCS2atSbvm3uxqzHbBrcWjsJLVrNcMrLbbSfJ kp3liXBVD+OTRlt6KYul0sF34OwWwg8ZUweyv4+wFjRN3E7uw5aRogwXl/QAVXmfM0jb EDgHbfn31ipSLM7FWxMwP42hQEGnYj/Qaf4BCX6Ua3S/vtTt6ZGiIEqHRVdwj0Ep7usk 6MnFqLc3evgwIatDfCTC+fKEonKPe8FOZc96aYSRNH/0h7zu+NFPyOmuPknewozSxeZ7 WI2QyCewAYTnpF3gxrbdKNfDEdyrQoTIhbncucF+zsOtBNhZsH/ds2/ETgJhuhTsqc/Y P5eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752750928; x=1753355728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W2plJ6J2I3uEkS9s/RoI/iLItjcXG/U6oXtMhASgX4s=; b=QgHrAjJc2LoEm3FxQ+JGhMaWjJvJhA0reElqWAH59m+B1jtN1Rl9R+5Z3Sph+oq3Z0 fi/VOST4GamgKegEx4uFqdDJKBn3iTtp2N9P/Q2Dc6Sc15w2KkStVCZflnICc5K3Bpui v83PUq0g8VspCLeKhU+ZyRLCXPEoJTPFeqVh7jJT8k0AGe8jVnHuRkfbVfv5+p0SOuuv sz8t+WdOzS163GHK9fSdPUXG+WkTZkfNRfmNWcq7B9OvgsdfDdMO3rOep/vvsjWnHinh p6tEdpfb9CAs2YyDJX8VvUOHIwb79RS1SdPzdlbtez00cbpG4Ef5vGtfRstZyTSYlrmS pGrw== X-Forwarded-Encrypted: i=1; AJvYcCXzDXGrydbmOYeQfH7XSAthxAx2dUUTU3Y59X+QMN3Ge6gMKqiP265OUUAvyUxUstTmhojWdXwYHg==@nongnu.org X-Gm-Message-State: AOJu0YypLeA95BLaUNLX0JFSLGR02SpIkmCNn8jAK5CCBg+9PbhGL44U znRPJSaA05S1oRJ2JgcqnUGP3T3Ob0EGQfs4ozaDBjTKExtGG/k9beosZ8YlVvXuYLI= X-Gm-Gg: ASbGncvCwQyL4xAfrGwvNyYkfj20gvw+VaKEka/hTZDq4+5I8Oe6M3EJ7L905kwFshe qtJ+IyfJ5oXSUDrcJbWivSg9susaGF62ztK46uvX26n6uVTDG2qzXF/cJQo6vfxIItUTiJjq7uA GyFfHjidyEMXj2/wS89vF0PSpktTL+aA/cNA4tAapuhAhMY/BD7CigtecUK7AG9qe1k7ADYR4zR lvXTURp5Im0mUHrsljier6MVYMyh3NrUZ7brvY3P/f09w/jbmJ9N8aIP3SgjaG5+WtaCn+yiQAP IXMFLUmaHvLQL3a3nlUqwhjXYESMdqd2vCkAUGikEOoreFG2un43+h7vINi+36zNR7ofIym2aZi mjGFepVN+IwsYRvNNACUW+Bfbj025AonRtUqEq/FmZ35sQXplXYij0zSeww4nKCg2BA== X-Google-Smtp-Source: AGHT+IEwBtS17vkQ8tdLBxf1RxtutMZw9AuH/KjjR/nrxLAS7JNDF7P05sbX5z37XDDZdwwm28dKWQ== X-Received: by 2002:a05:6000:144f:b0:3b5:e5c9:93c5 with SMTP id ffacd0b85a97d-3b60e54ab07mr5290509f8f.49.1752750928099; Thu, 17 Jul 2025 04:15:28 -0700 (PDT) Received: from [192.168.69.239] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b60e3ed902sm4473107f8f.91.2025.07.17.04.15.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 04:15:27 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 13:15:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length To: Mads Ynddal Cc: qemu-devel@nongnu.org, Cameron Esfahani , Peter Maydell , qemu-arm@nongnu.org, Roman Bolshakov , Phil Dennis-Jordan , Alexander Graf References: <20250716172813.73405-1-philmd@linaro.org> <20250716172813.73405-4-philmd@linaro.org> <84250F37-CCCF-49A2-8CB1-5B5CD1839004@ynddal.dk> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <84250F37-CCCF-49A2-8CB1-5B5CD1839004@ynddal.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 17/7/25 12:06, Mads Ynddal wrote: > >> On 16 Jul 2025, at 19.28, Philippe Mathieu-Daudé wrote: >> >> Emit a warning when HVF doesn't return the IPA bit length >> and return -1 as "this accelerator is not usable", allowing >> QEMU to try with the next one (when using '-accel hvf:tcg'). >> >> Reported-by: Ivan Krasilnikov >> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2981 >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/virt.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) > > I haven't been able to verify that hv_vm_config_get_max_ipa_size and > hv_vm_config_get_default_ipa_size fail if HVF is not available, but This happens with nested macOS guest. Maybe we are missing an earlier check whether HVF is usable or not, but we shouldn't brutally abort(). I'll try to update the patch description. Annoyingly the GitLab issue reporter isn't Cc'ed via the mailing list. > assuming so, it looks fine to me. > > Reviewed-by: Mads Ynddal